From: Fabio Estevam <festevam@gmail.com>
To: shawnguo@kernel.org
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: [PATCH 3/4] Revert "dt-bindings: ifc: Fix the unit address format in the examples"
Date: Sun, 18 Mar 2018 11:17:30 -0300 [thread overview]
Message-ID: <1521382651-10256-3-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1521382651-10256-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <fabio.estevam@nxp.com>
This reverts commit 4e017f1419397473cf3db6e9fa020013998b1aa4.
As explained by Rob Herring:
"This "fix" is wrong. Memory controllers with chip selects should have
the chip select in the unit-address. The correct fix here is you should drop
"simple-bus"."
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
index a4d4b6a..89427b0 100644
--- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
+++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
@@ -43,7 +43,7 @@ Example:
0x1 0x0 0x0 0xffa00000 0x00010000
0x3 0x0 0x0 0xffb00000 0x00020000>;
- flash@0 {
+ flash@0,0 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "cfi-flash";
@@ -58,7 +58,7 @@ Example:
};
};
- flash@100000000 {
+ flash@1,0 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "fsl,ifc-nand";
@@ -73,7 +73,7 @@ Example:
};
};
- cpld@@300000000 {
+ cpld@3,0 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "fsl,p1010rdb-cpld";
--
2.7.4
next prev parent reply other threads:[~2018-03-18 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 14:17 [PATCH 1/4] Revert "arm64: dts: fsl: fix ifc simple-bus unit address format warnings" Fabio Estevam
2018-03-18 14:17 ` [PATCH 2/4] arm64: dts: ls: Remove "simple-bus" from ifc compatible Fabio Estevam
2018-03-26 22:23 ` Rob Herring
2018-03-18 14:17 ` Fabio Estevam [this message]
2018-03-26 22:23 ` [PATCH 3/4] Revert "dt-bindings: ifc: Fix the unit address format in the examples" Rob Herring
2018-03-18 14:17 ` [PATCH 4/4] dt-bindings: ifc: Remove "simple-bus" from ifc compatible string Fabio Estevam
2018-03-26 22:23 ` Rob Herring
2018-03-26 14:44 ` [PATCH 1/4] Revert "arm64: dts: fsl: fix ifc simple-bus unit address format warnings" Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521382651-10256-3-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.