From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Stephen Boyd <swboyd@chromium.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Timur Tabi <timur@codeaurora.org>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Grant Likely <grant.likely@secretlab.ca>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] gpiolib: Support 'gpio-reserved-ranges' property
Date: Wed, 21 Mar 2018 22:31:14 +0200 [thread overview]
Message-ID: <1521664274.23017.92.camel@linux.intel.com> (raw)
In-Reply-To: <152166234504.91116.14942145962035607739@swboyd.mtv.corp.google.com>
On Wed, 2018-03-21 at 12:59 -0700, Stephen Boyd wrote:
> Quoting Andy Shevchenko (2018-03-21 10:59:10)
> > On Wed, 2018-03-21 at 09:58 -0700, Stephen Boyd wrote:
> > >
> >
> > > + gpiochip->valid_mask = kcalloc(BITS_TO_LONGS(gpiochip-
> > > > ngpio),
> > >
> > > + sizeof(long), GFP_KERNEL);
> >
> > Just noticed that kcalloc is superfluous here.
> > kmalloc_array() would be enough.
> >
>
> Ok. I was copying the irqchip style. Should I fold them together into
> a
> helper function and also update to kmalloc_array?
Not sure about first part, but definitely makes sense the second one (as
a separate patch perhaps).
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] gpiolib: Support 'gpio-reserved-ranges' property
Date: Wed, 21 Mar 2018 22:31:14 +0200 [thread overview]
Message-ID: <1521664274.23017.92.camel@linux.intel.com> (raw)
In-Reply-To: <152166234504.91116.14942145962035607739@swboyd.mtv.corp.google.com>
On Wed, 2018-03-21 at 12:59 -0700, Stephen Boyd wrote:
> Quoting Andy Shevchenko (2018-03-21 10:59:10)
> > On Wed, 2018-03-21 at 09:58 -0700, Stephen Boyd wrote:
> > >
> >
> > > + gpiochip->valid_mask = kcalloc(BITS_TO_LONGS(gpiochip-
> > > > ngpio),
> > >
> > > + sizeof(long), GFP_KERNEL);
> >
> > Just noticed that kcalloc is superfluous here.
> > kmalloc_array() would be enough.
> >
>
> Ok. I was copying the irqchip style. Should I fold them together into
> a
> helper function and also update to kmalloc_array?
Not sure about first part, but definitely makes sense the second one (as
a separate patch perhaps).
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-03-21 20:31 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 16:58 [PATCH v3 0/3] Support qcom pinctrl protected pins Stephen Boyd
2018-03-21 16:58 ` Stephen Boyd
2018-03-21 16:58 ` [PATCH v3 1/3] dt-bindings: gpio: Add a gpio-reserved-ranges property Stephen Boyd
2018-03-21 16:58 ` Stephen Boyd
2018-03-21 16:58 ` [PATCH v3 2/3] gpiolib: Support 'gpio-reserved-ranges' property Stephen Boyd
2018-03-21 16:58 ` Stephen Boyd
2018-03-21 17:59 ` Andy Shevchenko
2018-03-21 17:59 ` Andy Shevchenko
2018-03-21 18:02 ` Andy Shevchenko
2018-03-21 18:02 ` Andy Shevchenko
2018-03-21 18:02 ` Andy Shevchenko
2018-03-21 19:59 ` Stephen Boyd
2018-03-21 19:59 ` Stephen Boyd
2018-03-21 20:31 ` Andy Shevchenko [this message]
2018-03-21 20:31 ` Andy Shevchenko
2018-03-27 13:24 ` Linus Walleij
2018-03-27 13:24 ` Linus Walleij
2018-03-21 16:58 ` [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested Stephen Boyd
2018-03-21 16:58 ` Stephen Boyd
2018-03-21 18:07 ` Andy Shevchenko
2018-03-21 18:07 ` Andy Shevchenko
2018-03-21 20:04 ` Stephen Boyd
2018-03-21 20:04 ` Stephen Boyd
2018-03-21 20:30 ` Andy Shevchenko
2018-03-21 20:30 ` Andy Shevchenko
2018-03-21 20:17 ` Stephen Boyd
2018-03-21 20:17 ` Stephen Boyd
2018-03-23 0:16 ` Timur Tabi
2018-03-23 0:16 ` Timur Tabi
2018-03-23 0:23 ` Timur Tabi
2018-03-23 0:23 ` Timur Tabi
2018-03-23 0:59 ` Timur Tabi
2018-03-23 0:59 ` Timur Tabi
2018-03-23 11:34 ` Andy Shevchenko
2018-03-23 11:34 ` Andy Shevchenko
2018-03-23 14:03 ` Timur Tabi
2018-03-23 14:03 ` Timur Tabi
2018-03-23 11:36 ` Andy Shevchenko
2018-03-23 11:36 ` Andy Shevchenko
2018-03-23 16:21 ` Stephen Boyd
2018-03-23 16:21 ` Stephen Boyd
2018-03-23 16:25 ` Timur Tabi
2018-03-23 16:25 ` Timur Tabi
2018-03-23 16:31 ` Andy Shevchenko
2018-03-23 16:31 ` Andy Shevchenko
2018-03-23 16:32 ` Andy Shevchenko
2018-03-23 16:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521664274.23017.92.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.