From: paul.kocialkowski@bootlin.com (Paul Kocialkowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10] drm/fourcc: Add definitions for Allwinner vendor and MB32 tiled format
Date: Thu, 22 Mar 2018 09:05:49 +0100 [thread overview]
Message-ID: <1521705949.1175.0.camel@bootlin.com> (raw)
In-Reply-To: <CAPj87rPNgga_pspx_0kTiP4itWUOL3O++2ZCiTUFfNBDGzkd0w@mail.gmail.com>
Hi,
On Wed, 2018-03-21 at 16:47 +0000, Daniel Stone wrote:
> Hi Paul,
>
> On 21 March 2018 at 15:29, Paul Kocialkowski
> <paul.kocialkowski@bootlin.com> wrote:
> > +/*
> > + * Allwinner "MB32" tiled format
> > + *
> > + * This is the primary layout coming out of the VPU, where pixels
> > are tiled
> > + * 32x32.
> > + */
>
> Can you please be a bit more specific here, following the other
> examples? In particular, it should list whether the tile order is row-
> or column-major.
Yes that would definitely make sense, I'll do that in v2.
Thanks for the review!
--
Paul Kocialkowski, Bootlin (formerly Free Electrons)
Embedded Linux and kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180322/27150a88/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: David Airlie <airlied@linux.ie>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Chen-Yu Tsai <wens@csie.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 08/10] drm/fourcc: Add definitions for Allwinner vendor and MB32 tiled format
Date: Thu, 22 Mar 2018 09:05:49 +0100 [thread overview]
Message-ID: <1521705949.1175.0.camel@bootlin.com> (raw)
In-Reply-To: <CAPj87rPNgga_pspx_0kTiP4itWUOL3O++2ZCiTUFfNBDGzkd0w@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 710 bytes --]
Hi,
On Wed, 2018-03-21 at 16:47 +0000, Daniel Stone wrote:
> Hi Paul,
>
> On 21 March 2018 at 15:29, Paul Kocialkowski
> <paul.kocialkowski@bootlin.com> wrote:
> > +/*
> > + * Allwinner "MB32" tiled format
> > + *
> > + * This is the primary layout coming out of the VPU, where pixels
> > are tiled
> > + * 32x32.
> > + */
>
> Can you please be a bit more specific here, following the other
> examples? In particular, it should list whether the tile order is row-
> or column-major.
Yes that would definitely make sense, I'll do that in v2.
Thanks for the review!
--
Paul Kocialkowski, Bootlin (formerly Free Electrons)
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-arm-kernel@lists.infradead.org,
Maxime Ripard <maxime.ripard@free-electrons.com>,
David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Gustavo Padovan <gustavo@padovan.org>,
Sean Paul <seanpaul@chromium.org>
Subject: Re: [PATCH 08/10] drm/fourcc: Add definitions for Allwinner vendor and MB32 tiled format
Date: Thu, 22 Mar 2018 09:05:49 +0100 [thread overview]
Message-ID: <1521705949.1175.0.camel@bootlin.com> (raw)
In-Reply-To: <CAPj87rPNgga_pspx_0kTiP4itWUOL3O++2ZCiTUFfNBDGzkd0w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
Hi,
On Wed, 2018-03-21 at 16:47 +0000, Daniel Stone wrote:
> Hi Paul,
>
> On 21 March 2018 at 15:29, Paul Kocialkowski
> <paul.kocialkowski@bootlin.com> wrote:
> > +/*
> > + * Allwinner "MB32" tiled format
> > + *
> > + * This is the primary layout coming out of the VPU, where pixels
> > are tiled
> > + * 32x32.
> > + */
>
> Can you please be a bit more specific here, following the other
> examples? In particular, it should list whether the tile order is row-
> or column-major.
Yes that would definitely make sense, I'll do that in v2.
Thanks for the review!
--
Paul Kocialkowski, Bootlin (formerly Free Electrons)
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-03-22 8:05 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 15:28 [PATCH 00/10] drm/sun4i: Frontend YUV and MB32 tile modifier support Paul Kocialkowski
2018-03-21 15:28 ` Paul Kocialkowski
2018-03-21 15:28 ` [PATCH 01/10] drm/sun4i: Disable frontend video channel before enabling a layer Paul Kocialkowski
2018-03-21 15:28 ` Paul Kocialkowski
2018-03-23 9:53 ` Maxime Ripard
2018-03-23 9:53 ` Maxime Ripard
2018-03-23 9:53 ` Maxime Ripard
2018-03-21 15:28 ` [PATCH 02/10] drm/sun4i: Disable YUV channel when using the frontend and set interlace Paul Kocialkowski
2018-03-21 15:28 ` Paul Kocialkowski
2018-03-23 9:55 ` Maxime Ripard
2018-03-23 9:55 ` Maxime Ripard
2018-03-23 9:55 ` Maxime Ripard
2018-03-27 8:00 ` Paul Kocialkowski
2018-03-27 8:00 ` Paul Kocialkowski
2018-03-27 8:00 ` Paul Kocialkowski
2018-03-27 8:17 ` Maxime Ripard
2018-03-27 8:17 ` Maxime Ripard
2018-03-27 8:17 ` Maxime Ripard
2018-03-27 8:44 ` Paul Kocialkowski
2018-03-27 8:44 ` Paul Kocialkowski
2018-03-27 8:44 ` Paul Kocialkowski
2018-03-27 8:48 ` Chen-Yu Tsai
2018-03-27 8:48 ` Chen-Yu Tsai
2018-03-27 8:48 ` Chen-Yu Tsai
2018-03-27 9:18 ` Maxime Ripard
2018-03-27 9:18 ` Maxime Ripard
2018-03-27 9:18 ` Maxime Ripard
2018-03-27 9:21 ` Paul Kocialkowski
2018-03-27 9:21 ` Paul Kocialkowski
2018-03-27 9:21 ` Paul Kocialkowski
2018-03-21 15:28 ` [PATCH 03/10] drm/sun4i: Don't pretend to handle ARGB8888 with the frontend Paul Kocialkowski
2018-03-21 15:28 ` Paul Kocialkowski
2018-03-22 6:47 ` Chen-Yu Tsai
2018-03-22 6:47 ` Chen-Yu Tsai
2018-03-22 6:47 ` Chen-Yu Tsai
2018-03-22 8:23 ` Paul Kocialkowski
2018-03-22 8:23 ` Paul Kocialkowski
2018-03-22 8:23 ` Paul Kocialkowski
2018-03-22 8:37 ` Chen-Yu Tsai
2018-03-22 8:37 ` Chen-Yu Tsai
2018-03-22 8:37 ` Chen-Yu Tsai
2018-03-22 8:41 ` Paul Kocialkowski
2018-03-22 8:41 ` Paul Kocialkowski
2018-03-22 8:41 ` Paul Kocialkowski
2018-03-22 16:12 ` Maxime Ripard
2018-03-22 16:12 ` Maxime Ripard
2018-03-22 16:12 ` Maxime Ripard
2018-03-22 16:18 ` Paul Kocialkowski
2018-03-22 16:18 ` Paul Kocialkowski
2018-03-22 16:18 ` Paul Kocialkowski
2018-03-21 15:28 ` [PATCH 04/10] drm/sun4i: Explicitly list and check formats supported by the backend Paul Kocialkowski
2018-03-21 15:28 ` Paul Kocialkowski
2018-03-21 15:28 ` Paul Kocialkowski
2018-03-23 10:03 ` Maxime Ripard
2018-03-23 10:03 ` Maxime Ripard
2018-03-23 10:03 ` Maxime Ripard
2018-03-27 8:08 ` Paul Kocialkowski
2018-03-27 8:08 ` Paul Kocialkowski
2018-03-27 8:08 ` Paul Kocialkowski
2018-03-29 7:56 ` Maxime Ripard
2018-03-29 7:56 ` Maxime Ripard
2018-03-29 7:56 ` Maxime Ripard
2018-10-16 13:55 ` Paul Kocialkowski
2018-10-16 13:55 ` Paul Kocialkowski
2018-10-17 15:33 ` Maxime Ripard
2018-10-17 15:33 ` Maxime Ripard
2018-03-21 15:28 ` [PATCH 05/10] drm/sun4i: Explicitly list and check formats supported by the frontend Paul Kocialkowski
2018-03-21 15:28 ` Paul Kocialkowski
2018-03-23 10:06 ` Maxime Ripard
2018-03-23 10:06 ` Maxime Ripard
2018-03-23 10:06 ` Maxime Ripard
2018-03-27 8:24 ` Paul Kocialkowski
2018-03-27 8:24 ` Paul Kocialkowski
2018-03-27 8:24 ` Paul Kocialkowski
2018-03-29 9:03 ` Maxime Ripard
2018-03-29 9:03 ` Maxime Ripard
2018-03-29 9:03 ` Maxime Ripard
2018-10-16 13:57 ` Paul Kocialkowski
2018-10-16 13:57 ` Paul Kocialkowski
2018-03-21 15:29 ` [PATCH 06/10] drm/sun4i: Move and extend format-related helpers and tables Paul Kocialkowski
2018-03-21 15:29 ` Paul Kocialkowski
2018-03-23 10:13 ` Maxime Ripard
2018-03-23 10:13 ` Maxime Ripard
2018-03-23 10:13 ` Maxime Ripard
2018-03-27 8:27 ` Paul Kocialkowski
2018-03-27 8:27 ` Paul Kocialkowski
2018-03-27 8:27 ` Paul Kocialkowski
2018-03-27 14:47 ` Maxime Ripard
2018-03-27 14:47 ` Maxime Ripard
2018-03-27 14:47 ` Maxime Ripard
2018-03-21 15:29 ` [PATCH 07/10] drm/sun4i: Add support for YUV formats through the frontend Paul Kocialkowski
2018-03-21 15:29 ` Paul Kocialkowski
2018-03-23 10:30 ` Maxime Ripard
2018-03-23 10:30 ` Maxime Ripard
2018-03-23 10:30 ` Maxime Ripard
2018-03-27 8:39 ` Paul Kocialkowski
2018-03-27 8:39 ` Paul Kocialkowski
2018-03-27 8:39 ` Paul Kocialkowski
2018-03-21 15:29 ` [PATCH 08/10] drm/fourcc: Add definitions for Allwinner vendor and MB32 tiled format Paul Kocialkowski
2018-03-21 15:29 ` Paul Kocialkowski
2018-03-21 16:47 ` Daniel Stone
2018-03-21 16:47 ` Daniel Stone
2018-03-22 8:05 ` Paul Kocialkowski [this message]
2018-03-22 8:05 ` Paul Kocialkowski
2018-03-22 8:05 ` Paul Kocialkowski
2018-03-21 15:29 ` [PATCH 09/10] drm/sun4i: Add a dedicated ioctl call for allocating tiled buffers Paul Kocialkowski
2018-03-21 15:29 ` Paul Kocialkowski
2018-03-23 10:48 ` Maxime Ripard
2018-03-23 10:48 ` Maxime Ripard
2018-03-23 10:48 ` Maxime Ripard
2018-03-27 8:41 ` Paul Kocialkowski
2018-03-27 8:41 ` Paul Kocialkowski
2018-03-27 8:41 ` Paul Kocialkowski
2018-03-27 14:48 ` Maxime Ripard
2018-03-27 14:48 ` Maxime Ripard
2018-03-27 14:48 ` Maxime Ripard
2018-03-21 15:29 ` [PATCH 10/10] drm/sun4i: Add support for YUV-based formats in MB32 tiles Paul Kocialkowski
2018-03-21 15:29 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521705949.1175.0.camel@bootlin.com \
--to=paul.kocialkowski@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.