From: Johannes Berg <johannes@sipsolutions.net>
To: akolli@codeaurora.org, Sven Eckelmann <sven.eckelmann@openmesh.com>
Cc: Johannes Berg <johannes.berg@intel.com>,
linux-wireless-owner@vger.kernel.org,
linux-wireless@vger.kernel.org, Antonio Quartulli <a@unstable.cc>,
ath10k@lists.infradead.org,
Tamizh chelvam <tamizhr@codeaurora.org>,
Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH] ath10k: Implement get_expected_throughput callback
Date: Fri, 23 Mar 2018 14:44:19 +0100 [thread overview]
Message-ID: <1521812659.28252.0.camel@sipsolutions.net> (raw)
In-Reply-To: <5434de1a4bcdf7341fdeb766e7638760@codeaurora.org> (sfid-20180323_144153_352630_7377CAE0)
On Fri, 2018-03-23 at 19:11 +0530, akolli@codeaurora.org wrote:
>
> > > +
> > > + sinfo->expected_throughput =
> > > +
> > > ewma_sta_txrate_read(&arsta->ave_sta_txrate);
> > > + sinfo->filled |=
> > > BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT);
> > > +}
> Yes. This looks redundant, I will remove this line,
> sinfo->filled |= BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT);
You don't need any of the changes here in ath10k_sta_statistics().
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: akolli@codeaurora.org, Sven Eckelmann <sven.eckelmann@openmesh.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Antonio Quartulli <a@unstable.cc>, Felix Fietkau <nbd@nbd.name>,
Johannes Berg <johannes.berg@intel.com>,
Tamizh chelvam <tamizhr@codeaurora.org>,
linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH] ath10k: Implement get_expected_throughput callback
Date: Fri, 23 Mar 2018 14:44:19 +0100 [thread overview]
Message-ID: <1521812659.28252.0.camel@sipsolutions.net> (raw)
In-Reply-To: <5434de1a4bcdf7341fdeb766e7638760@codeaurora.org> (sfid-20180323_144153_352630_7377CAE0)
On Fri, 2018-03-23 at 19:11 +0530, akolli@codeaurora.org wrote:
>
> > > +
> > > + sinfo->expected_throughput =
> > > +
> > > ewma_sta_txrate_read(&arsta->ave_sta_txrate);
> > > + sinfo->filled |=
> > > BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT);
> > > +}
> Yes. This looks redundant, I will remove this line,
> sinfo->filled |= BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT);
You don't need any of the changes here in ath10k_sta_statistics().
johannes
next prev parent reply other threads:[~2018-03-23 13:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 7:37 [PATCH] ath10k: Implement get_expected_throughput callback Anilkumar Kolli
2018-03-23 7:37 ` Anilkumar Kolli
2018-03-23 8:09 ` Sven Eckelmann
2018-03-23 8:09 ` Sven Eckelmann
2018-03-23 13:41 ` akolli
2018-03-23 13:41 ` akolli
2018-03-23 13:44 ` Johannes Berg [this message]
2018-03-23 13:44 ` Johannes Berg
2018-03-23 14:08 ` akolli
2018-03-23 14:08 ` akolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521812659.28252.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=a@unstable.cc \
--cc=akolli@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=johannes.berg@intel.com \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sven.eckelmann@openmesh.com \
--cc=tamizhr@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.