From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"bigeasy@linutronix.de" <bigeasy@linutronix.de>,
"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Cc: "daniel@bristot.me" <daniel@bristot.me>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"acme@kernel.org" <acme@kernel.org>,
"williams@redhat.com" <williams@redhat.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"lclaudio@redhat.com" <lclaudio@redhat.com>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH 1/2 v2] target: drop spin_lock_assert() + irqs_disabled() combo checks
Date: Fri, 23 Mar 2018 17:47:14 +0000 [thread overview]
Message-ID: <1521827233.2535.15.camel@wdc.com> (raw)
In-Reply-To: <20180323173633.kh5fwrfj6b5elki5@linutronix.de>
On Fri, 2018-03-23 at 18:36 +0100, Sebastian Andrzej Siewior wrote:
> There are a few functions which check for if the lock is held
> (spin_lock_assert()) and the interrupts are disabled (irqs_disabled()).
> > From looking at the code, each function is static, the caller is near by
>
> and does spin_lock_irq|safe(). As Linus puts it:
>
> > It's not like this is some function that is exported to random users,
> > and we should check that the calling convention is right.
> >
> > This looks like "it may have been useful during coding to document
> > things, but it's not useful long-term".
>
> Remove those checks.
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"bigeasy@linutronix.de" <bigeasy@linutronix.de>,
"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Cc: "daniel@bristot.me" <daniel@bristot.me>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"acme@kernel.org" <acme@kernel.org>,
"williams@redhat.com" <williams@redhat.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"lclaudio@redhat.com" <lclaudio@redhat.com>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH 1/2 v2] target: drop spin_lock_assert() + irqs_disabled() combo checks
Date: Fri, 23 Mar 2018 17:47:14 +0000 [thread overview]
Message-ID: <1521827233.2535.15.camel@wdc.com> (raw)
In-Reply-To: <20180323173633.kh5fwrfj6b5elki5@linutronix.de>
T24gRnJpLCAyMDE4LTAzLTIzIGF0IDE4OjM2ICswMTAwLCBTZWJhc3RpYW4gQW5kcnplaiBTaWV3
aW9yIHdyb3RlOg0KPiBUaGVyZSBhcmUgYSBmZXcgZnVuY3Rpb25zIHdoaWNoIGNoZWNrIGZvciBp
ZiB0aGUgbG9jayBpcyBoZWxkDQo+IChzcGluX2xvY2tfYXNzZXJ0KCkpIGFuZCB0aGUgaW50ZXJy
dXB0cyBhcmUgZGlzYWJsZWQgKGlycXNfZGlzYWJsZWQoKSkuDQo+ID4gRnJvbSBsb29raW5nIGF0
IHRoZSBjb2RlLCBlYWNoIGZ1bmN0aW9uIGlzIHN0YXRpYywgdGhlIGNhbGxlciBpcyBuZWFyIGJ5
DQo+IA0KPiBhbmQgZG9lcyBzcGluX2xvY2tfaXJxfHNhZmUoKS4gQXMgTGludXMgcHV0cyBpdDoN
Cj4gDQo+ID4gSXQncyBub3QgbGlrZSB0aGlzIGlzIHNvbWUgZnVuY3Rpb24gdGhhdCBpcyBleHBv
cnRlZCB0byByYW5kb20gdXNlcnMsDQo+ID4gYW5kIHdlIHNob3VsZCBjaGVjayB0aGF0IHRoZSBj
YWxsaW5nIGNvbnZlbnRpb24gaXMgcmlnaHQuDQo+ID4gDQo+ID4gVGhpcyBsb29rcyBsaWtlICJp
dCBtYXkgaGF2ZSBiZWVuIHVzZWZ1bCBkdXJpbmcgY29kaW5nIHRvIGRvY3VtZW50DQo+ID4gdGhp
bmdzLCBidXQgaXQncyBub3QgdXNlZnVsIGxvbmctdGVybSIuDQo+IA0KPiBSZW1vdmUgdGhvc2Ug
Y2hlY2tzLg0KDQpSZXZpZXdlZC1ieTogQmFydCBWYW4gQXNzY2hlIDxiYXJ0LnZhbmFzc2NoZUB3
ZGMuY29tPg0KDQoNCg0K
next prev parent reply other threads:[~2018-03-23 17:47 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 15:38 [PATCH] target: Use WARNON_NON_RT(!irqs_disabled()) Arnaldo Carvalho de Melo
2018-03-21 15:38 ` Arnaldo Carvalho de Melo
2018-03-21 15:38 ` Arnaldo Carvalho de Melo
2018-03-21 18:43 ` Linus Torvalds
2018-03-21 18:43 ` Linus Torvalds
2018-03-22 9:13 ` Thomas Gleixner
2018-03-22 9:13 ` Thomas Gleixner
2018-03-22 9:37 ` Arnaldo Carvalho de Melo
2018-03-22 9:37 ` Arnaldo Carvalho de Melo
2018-03-22 9:40 ` Arnaldo Carvalho de Melo
2018-03-22 9:40 ` Arnaldo Carvalho de Melo
2018-03-22 9:47 ` Thomas Gleixner
2018-03-22 9:47 ` Thomas Gleixner
2018-03-23 15:55 ` Sebastian Andrzej Siewior
2018-03-23 15:55 ` Sebastian Andrzej Siewior
2018-03-23 16:25 ` Bart Van Assche
2018-03-23 16:25 ` Bart Van Assche
2018-03-23 16:33 ` bigeasy
2018-03-23 16:33 ` bigeasy
2018-03-23 16:37 ` Linus Torvalds
2018-03-23 16:37 ` Linus Torvalds
2018-03-23 17:17 ` [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks bigeasy
2018-03-23 17:17 ` bigeasy
2018-03-23 17:19 ` [PATCH 2/2] target: remove spin_lock_assert() in __target_(attach|detach)_tg_pt_gp() bigeasy
2018-03-23 17:19 ` bigeasy
2018-03-23 17:44 ` Bart Van Assche
2018-03-23 17:44 ` Bart Van Assche
2018-03-23 17:50 ` bigeasy
2018-03-23 17:50 ` bigeasy
2018-03-23 17:55 ` Bart Van Assche
2018-03-23 17:55 ` Bart Van Assche
2018-03-26 15:38 ` Steven Rostedt
2018-03-26 15:38 ` Steven Rostedt
2018-03-23 17:36 ` [PATCH 1/2 v2] target: drop spin_lock_assert() + irqs_disabled() combo checks Sebastian Andrzej Siewior
2018-03-23 17:36 ` Sebastian Andrzej Siewior
2018-03-23 17:47 ` Bart Van Assche [this message]
2018-03-23 17:47 ` Bart Van Assche
2018-03-26 15:13 ` [PATCH 1/2] " Steven Rostedt
2018-03-26 15:13 ` Steven Rostedt
2018-03-28 10:15 ` bigeasy
2018-03-28 10:15 ` bigeasy
2018-03-28 15:05 ` Bart Van Assche
2018-03-28 15:05 ` Bart Van Assche
2018-03-28 15:14 ` bigeasy
2018-03-28 15:14 ` bigeasy
2018-03-28 15:31 ` Bart Van Assche
2018-03-28 15:31 ` Bart Van Assche
2018-05-28 14:35 ` bigeasy
2018-05-28 14:35 ` bigeasy
2018-06-04 7:02 ` Bart Van Assche
2018-06-04 7:02 ` Bart Van Assche
2018-06-04 7:16 ` bigeasy
2018-06-04 7:16 ` bigeasy
2018-03-26 14:21 ` [PATCH] target: Use WARNON_NON_RT(!irqs_disabled()) Arnaldo Carvalho de Melo
2018-03-26 14:21 ` Arnaldo Carvalho de Melo
2018-03-21 18:50 ` Christoph Hellwig
2018-03-21 18:50 ` Christoph Hellwig
2018-03-21 19:01 ` Steven Rostedt
2018-03-21 19:01 ` Steven Rostedt
2018-03-22 10:25 ` kbuild test robot
2018-03-22 10:25 ` kbuild test robot
2018-03-22 10:45 ` kbuild test robot
2018-03-22 10:45 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521827233.2535.15.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=acme@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=daniel@bristot.me \
--cc=lclaudio@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=target-devel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.