From: Sinan Kaya <okaya@codeaurora.org>
To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org
Cc: Dept-GELinuxNICDev@cavium.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, Sinan Kaya <okaya@codeaurora.org>,
Harish Patil <harish.patil@cavium.com>,
linux-arm-kernel@lists.infradead.org,
Manish Chopra <manish.chopra@cavium.com>
Subject: [PATCH v6 2/6] qlcnic: Eliminate duplicate barriers on weakly-ordered archs
Date: Fri, 23 Mar 2018 18:23:07 -0400 [thread overview]
Message-ID: <1521843791-21201-3-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1521843791-21201-1-git-send-email-okaya@codeaurora.org>
Code includes wmb() followed by writel(). writel() already has a
barrier on some architectures like arm64.
This ends up CPU observing two barriers back to back before executing
the register write.
Since code already has an explicit barrier call, changing writel() to
writel_relaxed().
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Acked-by: Manish Chopra <manish.chopra@cavium.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
index 46b0372..97c146e7 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
@@ -478,7 +478,7 @@ irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *adapter)
wmb();
/* clear the interrupt trigger control register */
- writel(0, adapter->isr_int_vec);
+ writel_relaxed(0, adapter->isr_int_vec);
intr_val = readl(adapter->isr_int_vec);
do {
intr_val = readl(adapter->tgt_status_reg);
--
2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/6] qlcnic: Eliminate duplicate barriers on weakly-ordered archs
Date: Fri, 23 Mar 2018 18:23:07 -0400 [thread overview]
Message-ID: <1521843791-21201-3-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1521843791-21201-1-git-send-email-okaya@codeaurora.org>
Code includes wmb() followed by writel(). writel() already has a
barrier on some architectures like arm64.
This ends up CPU observing two barriers back to back before executing
the register write.
Since code already has an explicit barrier call, changing writel() to
writel_relaxed().
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Acked-by: Manish Chopra <manish.chopra@cavium.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
index 46b0372..97c146e7 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
@@ -478,7 +478,7 @@ irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *adapter)
wmb();
/* clear the interrupt trigger control register */
- writel(0, adapter->isr_int_vec);
+ writel_relaxed(0, adapter->isr_int_vec);
intr_val = readl(adapter->isr_int_vec);
do {
intr_val = readl(adapter->tgt_status_reg);
--
2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@codeaurora.org>
To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sinan Kaya <okaya@codeaurora.org>,
Harish Patil <harish.patil@cavium.com>,
Manish Chopra <manish.chopra@cavium.com>,
Dept-GELinuxNICDev@cavium.com, linux-kernel@vger.kernel.org
Subject: [PATCH v6 2/6] qlcnic: Eliminate duplicate barriers on weakly-ordered archs
Date: Fri, 23 Mar 2018 18:23:07 -0400 [thread overview]
Message-ID: <1521843791-21201-3-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1521843791-21201-1-git-send-email-okaya@codeaurora.org>
Code includes wmb() followed by writel(). writel() already has a
barrier on some architectures like arm64.
This ends up CPU observing two barriers back to back before executing
the register write.
Since code already has an explicit barrier call, changing writel() to
writel_relaxed().
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Acked-by: Manish Chopra <manish.chopra@cavium.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
index 46b0372..97c146e7 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
@@ -478,7 +478,7 @@ irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *adapter)
wmb();
/* clear the interrupt trigger control register */
- writel(0, adapter->isr_int_vec);
+ writel_relaxed(0, adapter->isr_int_vec);
intr_val = readl(adapter->isr_int_vec);
do {
intr_val = readl(adapter->tgt_status_reg);
--
2.7.4
next prev parent reply other threads:[~2018-03-23 22:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 22:23 [PATCH v6 0/6] netdev: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-23 22:23 ` Sinan Kaya
2018-03-23 22:23 ` [PATCH v6 1/6] net: qla3xxx: " Sinan Kaya
2018-03-23 22:23 ` Sinan Kaya
2018-03-23 22:23 ` Sinan Kaya [this message]
2018-03-23 22:23 ` [PATCH v6 2/6] qlcnic: " Sinan Kaya
2018-03-23 22:23 ` Sinan Kaya
2018-03-23 22:23 ` [PATCH v6 3/6] bnx2x: Replace doorbell barrier() with wmb() Sinan Kaya
2018-03-23 22:23 ` Sinan Kaya
2018-03-23 22:23 ` Sinan Kaya
2018-03-23 22:23 ` [PATCH v6 4/6] bnx2x: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-23 22:23 ` Sinan Kaya
2018-03-23 22:23 ` [PATCH v6 5/6] net: qlge: " Sinan Kaya
2018-03-23 22:23 ` Sinan Kaya
2018-03-23 22:23 ` [PATCH v6 6/6] bnxt_en: " Sinan Kaya
2018-03-23 22:23 ` Sinan Kaya
2018-03-23 22:36 ` Michael Chan
2018-03-23 22:36 ` Michael Chan
2018-03-24 4:02 ` Sinan Kaya
2018-03-24 4:02 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521843791-21201-3-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=harish.patil@cavium.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.chopra@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=sulrich@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.