All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Al Cooper <alcooperx@gmail.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema
Date: Thu, 22 Jun 2023 08:00:48 +0200	[thread overview]
Message-ID: <1521fc62-1c8d-ff74-fa52-2acc8dab4c19@gmail.com> (raw)
In-Reply-To: <20230621230958.3815818-1-robh@kernel.org>

On 22.06.2023 01:09, Rob Herring wrote:
> The conditional if/then schema has an error as the "enum" values have
> "const" in them. Drop the "const".
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Oops, it's my mistake.

Fixes: 46b616c1574d ("dt-bindings: phy: brcm, brcmstb-usb-phy: add BCM4908 binding")

Acked-by: Rafał Miłecki <rafal@milecki.pl>

Thanks!


> ---
>   .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml         | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> index 43a4b880534c..580fbe37b37f 100644
> --- a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> @@ -115,8 +115,8 @@ allOf:
>           compatible:
>             contains:
>               enum:
> -              - const: brcm,bcm4908-usb-phy
> -              - const: brcm,brcmstb-usb-phy
> +              - brcm,bcm4908-usb-phy
> +              - brcm,brcmstb-usb-phy
>       then:
>         properties:
>           reg:


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Al Cooper <alcooperx@gmail.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema
Date: Thu, 22 Jun 2023 08:00:48 +0200	[thread overview]
Message-ID: <1521fc62-1c8d-ff74-fa52-2acc8dab4c19@gmail.com> (raw)
In-Reply-To: <20230621230958.3815818-1-robh@kernel.org>

On 22.06.2023 01:09, Rob Herring wrote:
> The conditional if/then schema has an error as the "enum" values have
> "const" in them. Drop the "const".
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Oops, it's my mistake.

Fixes: 46b616c1574d ("dt-bindings: phy: brcm, brcmstb-usb-phy: add BCM4908 binding")

Acked-by: Rafał Miłecki <rafal@milecki.pl>

Thanks!


> ---
>   .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml         | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> index 43a4b880534c..580fbe37b37f 100644
> --- a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> @@ -115,8 +115,8 @@ allOf:
>           compatible:
>             contains:
>               enum:
> -              - const: brcm,bcm4908-usb-phy
> -              - const: brcm,brcmstb-usb-phy
> +              - brcm,bcm4908-usb-phy
> +              - brcm,brcmstb-usb-phy
>       then:
>         properties:
>           reg:


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Broadcom internal kernel review list 
	<bcm-kernel-feedback-list@broadcom.com>,
	Al Cooper <alcooperx@gmail.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema
Date: Thu, 22 Jun 2023 08:00:48 +0200	[thread overview]
Message-ID: <1521fc62-1c8d-ff74-fa52-2acc8dab4c19@gmail.com> (raw)
In-Reply-To: <20230621230958.3815818-1-robh@kernel.org>

On 22.06.2023 01:09, Rob Herring wrote:
> The conditional if/then schema has an error as the "enum" values have
> "const" in them. Drop the "const".
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Oops, it's my mistake.

Fixes: 46b616c1574d ("dt-bindings: phy: brcm, brcmstb-usb-phy: add BCM4908 binding")

Acked-by: Rafał Miłecki <rafal@milecki.pl>

Thanks!


> ---
>   .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml         | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> index 43a4b880534c..580fbe37b37f 100644
> --- a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> @@ -115,8 +115,8 @@ allOf:
>           compatible:
>             contains:
>               enum:
> -              - const: brcm,bcm4908-usb-phy
> -              - const: brcm,brcmstb-usb-phy
> +              - brcm,bcm4908-usb-phy
> +              - brcm,brcmstb-usb-phy
>       then:
>         properties:
>           reg:


  reply	other threads:[~2023-06-22  6:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 23:09 [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema Rob Herring
2023-06-21 23:09 ` Rob Herring
2023-06-21 23:09 ` Rob Herring
2023-06-22  6:00 ` Rafał Miłecki [this message]
2023-06-22  6:00   ` Rafał Miłecki
2023-06-22  6:00   ` Rafał Miłecki
2023-06-22  8:00 ` Vinod Koul
2023-06-22  8:00   ` Vinod Koul
2023-06-22  8:00   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521fc62-1c8d-ff74-fa52-2acc8dab4c19@gmail.com \
    --to=zajec5@gmail.com \
    --cc=alcooperx@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kishon@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.