From: Joe Perches <joe@perches.com>
To: Colin King <colin.king@canonical.com>,
Boaz Harrosh <ooo@electrozaur.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ore: fix spelling mistake: "Multples" -> "multiples"
Date: Wed, 28 Mar 2018 23:21:14 +0000 [thread overview]
Message-ID: <1522279274.2210.15.camel@perches.com> (raw)
In-Reply-To: <20180328230705.28145-1-colin.king@canonical.com>
On Thu, 2018-03-29 at 00:07 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in ORE_ERR error message text and
> make it all lowercase.
thanks and more trivially:
> diff --git a/fs/exofs/ore.c b/fs/exofs/ore.c
[]
> @@ -68,7 +68,7 @@ int ore_verify_layout(unsigned total_comps, struct ore_layout *layout)
> }
> if (0 != (layout->stripe_unit & ~PAGE_MASK)) {
> ORE_ERR("Stripe Unit(0x%llx)"
> - " must be Multples of PAGE_SIZE(0x%lx)\n",
> + " must be multiples of PAGE_SIZE(0x%lx)\n",
"a multiple" might be more intelligible than "multiples"
It would be a more common usage too.
$ git grep -i "\".*multiples" | wc -l
10
$ git grep -i "\".*a multiple" | wc -l
62
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Colin King <colin.king@canonical.com>,
Boaz Harrosh <ooo@electrozaur.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ore: fix spelling mistake: "Multples" -> "multiples"
Date: Wed, 28 Mar 2018 16:21:14 -0700 [thread overview]
Message-ID: <1522279274.2210.15.camel@perches.com> (raw)
In-Reply-To: <20180328230705.28145-1-colin.king@canonical.com>
On Thu, 2018-03-29 at 00:07 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in ORE_ERR error message text and
> make it all lowercase.
thanks and more trivially:
> diff --git a/fs/exofs/ore.c b/fs/exofs/ore.c
[]
> @@ -68,7 +68,7 @@ int ore_verify_layout(unsigned total_comps, struct ore_layout *layout)
> }
> if (0 != (layout->stripe_unit & ~PAGE_MASK)) {
> ORE_ERR("Stripe Unit(0x%llx)"
> - " must be Multples of PAGE_SIZE(0x%lx)\n",
> + " must be multiples of PAGE_SIZE(0x%lx)\n",
"a multiple" might be more intelligible than "multiples"
It would be a more common usage too.
$ git grep -i "\".*multiples" | wc -l
10
$ git grep -i "\".*a multiple" | wc -l
62
next prev parent reply other threads:[~2018-03-28 23:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 23:07 [PATCH] ore: fix spelling mistake: "Multples" -> "multiples" Colin King
2018-03-28 23:07 ` Colin King
2018-03-28 23:21 ` Joe Perches [this message]
2018-03-28 23:21 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2017-04-22 12:48 Colin King
2017-04-23 9:37 ` Boaz Harrosh
2017-04-24 0:08 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522279274.2210.15.camel@perches.com \
--to=joe@perches.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ooo@electrozaur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.