Re: [igt-dev] [PATCH i-g-t] lib/gen6_render: Refactoring lib

["Kalamarz, Lukasz" <lukasz.kalamarz@intel.com>]

On Tue, 2018-04-10 at 12:35 +0200, Katarzyna Dec wrote:
> On Mon, Apr 09, 2018 at 05:42:29PM +0200, Lukasz Kalamarz wrote:
> > This patch is starting a series of refactoring changes for *render*
> > libs. A lot of code in those libraries is copy/pasted and renamed
> > for
> > different gen.
> > 
> > Changes made in this patch:
> > - removal of duplicated registers definitions
> > - move field definitions above it register definition
> > - move definitions of register into ascending order
> > - unify spaces between register name and it's address/value
> > 
> > Signed-off-by: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
> > Cc: Katarzyna Dec <katarzyna.dec@intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > +#define GEN6_REGISTER_TYPE_UB			4
> > +#define GEN6_REGISTER_TYPE_B			5
> > +#define GEN6_REGISTER_TYPE_VF			5	/*
> > packed float vector, immediates only? */
> > +#define GEN6_REGISTER_TYPE_HF			6
> > +#define GEN6_REGISTER_TYPE_V			6	/*
> > packed int vector, immediates only, uword dest only */
> > +#define GEN6_REGISTER_TYPE_F			7
> > 
> 
> Generally looks good. There are few style issues: too long lines
> (like the one above),
> mixed tabs and spaces, etc. Use checkpatch for see what needs to be
> changed.

Fixed in next version of patch.
> I think that this changes can be introduced in another patch, so it
> will be easier
> to review.

Since similar changes were introduced in v1 I simply updated it with
Your suggestion.
--
Lukasz
> 
> Kasia
> > -- 
> > 2.9.5
> > 
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev