All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kalamarz, Lukasz" <lukasz.kalamarz@intel.com>
To: "Dec, Katarzyna" <katarzyna.dec@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v5 3/4] lib/gpgpu_fill: Add missing configuration parameters for gpgpu_fill
Date: Tue, 10 Apr 2018 13:16:23 +0000	[thread overview]
Message-ID: <1523366182.3558.49.camel@intel.com> (raw)
In-Reply-To: <20180410113453.30881-4-katarzyna.dec@intel.com>

On Tue, 2018-04-10 at 13:34 +0200, Katarzyna Dec wrote:
> There are missing parameters for Gen8 configuration of gpgpu_fill
> that are causing GPU hangs on newer hardware. We need to set the
> number of threads in TG in gen8_fill_interface_descriptor. This
> field was omitted (apparently without any side effects), but
> according to bspec from BDW this field cannot be set to 0. We also
> need to use pipeline selection mask to gen9_gpgpu_fillfunc, which
> is necessary from SKL.
> 
> v2: rebased on refactored library
> v3: Removed replacing gen7_emit_interface_descriptor_load with gen8
> version in gen9_gpgpgu_fillfunc, because during refactoring gen8
> function was removed.
> v4: rebase on series new version
> 
> Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
> Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Looks good for me.
Reviewed-by: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-04-10 13:17 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09 15:42 [igt-dev] [PATCH i-g-t] lib/gen6_render: Refactoring lib Lukasz Kalamarz
2018-04-09 16:49 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-04-09 22:07 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-04-10 10:35 ` [igt-dev] [PATCH i-g-t] " Katarzyna Dec
2018-04-10 11:29   ` Kalamarz, Lukasz
2018-04-10 10:48 ` [igt-dev] [PATCH i-g-t v4 0/4] Refactoring of *_fill libraries Katarzyna Dec
2018-04-10 10:48 ` [igt-dev] [PATCH i-g-t v4 1/4] lib: Move common gpgpu/media fill functions to gpu_fill library Katarzyna Dec
2018-04-10 10:48 ` [igt-dev] [PATCH i-g-t v4 2/4] lib: Remove duplications in " Katarzyna Dec
2018-04-10 10:48 ` [igt-dev] [PATCH i-g-t v4 3/4] lib/gpgpu_fill: Add missing configuration parameters for gpgpu_fill Katarzyna Dec
2018-04-10 10:48 ` [igt-dev] [PATCH i-g-t v4 4/4] lib: Adjust refactored gpu_fill library to our coding style Katarzyna Dec
2018-04-10 11:28 ` [igt-dev] [PATCH i-g-t v2] lib/gen6_render: Refactoring lib Lukasz Kalamarz
2018-04-10 13:28   ` Katarzyna Dec
2018-04-10 14:19   ` [igt-dev] [PATCH i-g-t v6 1/4] lib: Move common gpgpu/media fill functions to gpu_fill library Katarzyna Dec
2018-04-10 16:01     ` Antonio Argenziano
2018-04-10 14:19   ` [igt-dev] [PATCH i-g-t v6 2/4] lib: Remove duplications in " Katarzyna Dec
2018-04-10 14:19   ` [igt-dev] [PATCH i-g-t v6 3/4] lib/gpgpu_fill: Add missing configuration parameters for gpgpu_fill Katarzyna Dec
2018-04-10 14:19   ` [igt-dev] [PATCH i-g-t v6 4/4] lib: Adjust refactored gpu_fill library to our coding style Katarzyna Dec
2018-04-10 11:34 ` [igt-dev] [PATCH i-g-t v5 0/4] Refactoring of *_fill libraries Katarzyna Dec
2018-04-10 11:34 ` [igt-dev] [PATCH i-g-t v5 1/4] lib: Move common gpgpu/media fill functions to gpu_fill library Katarzyna Dec
2018-04-10 11:34 ` [igt-dev] [PATCH i-g-t v5 2/4] lib: Remove duplications in " Katarzyna Dec
2018-04-10 13:14   ` Kalamarz, Lukasz
2018-04-10 13:35     ` Katarzyna Dec
2018-04-10 11:34 ` [igt-dev] [PATCH i-g-t v5 3/4] lib/gpgpu_fill: Add missing configuration parameters for gpgpu_fill Katarzyna Dec
2018-04-10 13:16   ` Kalamarz, Lukasz [this message]
2018-04-10 11:34 ` [igt-dev] [PATCH i-g-t v5 4/4] lib: Adjust refactored gpu_fill library to our coding style Katarzyna Dec
2018-04-10 13:42   ` Katarzyna Dec
2018-04-10 13:46 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/gen6_render: Refactoring lib (rev4) Patchwork
2018-04-10 15:04 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1523366182.3558.49.camel@intel.com \
    --to=lukasz.kalamarz@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=katarzyna.dec@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.