From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/omap: Fix missing includes
Date: Tue, 19 Apr 2016 05:17:55 +0300 [thread overview]
Message-ID: <1523377.BVFxig5LNh@avalon> (raw)
In-Reply-To: <1460994134-12587-1-git-send-email-tomi.valkeinen@ti.com>
Hi Tomi,
Thank you for the patch.
On Monday 18 Apr 2016 18:42:11 Tomi Valkeinen wrote:
> With certain kernel config options many omapdrm files fail to compile
> due to missing include of linux/gpio/consumer.h and linux/of.h.
>
> This patch adds those includes.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Reported-by: Dan Murphy <dmurphy@ti.com>
> ---
> drivers/gpu/drm/omapdrm/displays/encoder-opa362.c | 1 +
> drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 1 +
> drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c | 1 +
> drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c | 1 +
> drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 +
> drivers/gpu/drm/omapdrm/dss/hdmi5.c | 1 +
> 6 files changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
> b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c index
> 8c246c213e06..9f06a87e80c4 100644
> --- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
> +++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
> @@ -15,6 +15,7 @@
> */
>
> #include <linux/gpio.h>
This driver uses the gpiod API only, you can remove gpio.h and of_gpio.h.
> +#include <linux/gpio/consumer.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c index
> e780fd4f8b46..ddf4f3be9a3d 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> @@ -10,6 +10,7 @@
> */
>
> #include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c index
> 458f77bc473d..ac680e1de603 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> @@ -15,6 +15,7 @@
> #include <linux/spi/spi.h>
> #include <linux/mutex.h>
> #include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>
> #include <video/omapdss.h>
> #include <video/omap-panel-data.h>
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
> b/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c index
> 529a017602e4..1de5146c83c0 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
> @@ -11,6 +11,7 @@
>
> #include <linux/delay.h>
> #include <linux/gpio.h>
Same here.
With that fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +#include <linux/gpio/consumer.h>
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_gpio.h>
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c
> b/drivers/gpu/drm/omapdrm/dss/hdmi4.c index f892ae157ff3..eef260ff420d
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
> @@ -33,6 +33,7 @@
> #include <linux/gpio.h>
> #include <linux/regulator/consumer.h>
> #include <linux/component.h>
> +#include <linux/of.h>
> #include <video/omapdss.h>
> #include <sound/omap-hdmi-audio.h>
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c
> b/drivers/gpu/drm/omapdrm/dss/hdmi5.c index a43f7b10e113..417dff5eb7cb
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
> @@ -38,6 +38,7 @@
> #include <linux/gpio.h>
> #include <linux/regulator/consumer.h>
> #include <linux/component.h>
> +#include <linux/of.h>
> #include <video/omapdss.h>
> #include <sound/omap-hdmi-audio.h>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-04-19 2:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 15:42 [PATCH 1/4] drm/omap: Fix missing includes Tomi Valkeinen
2016-04-18 15:42 ` [PATCH 2/4] drm/omap: remove unnecessary pitch round-up Tomi Valkeinen
2016-04-19 2:11 ` Laurent Pinchart
2016-04-18 15:42 ` [PATCH 3/4] drm/omap: remove align_pitch() Tomi Valkeinen
2016-04-19 2:12 ` Laurent Pinchart
2016-04-19 6:15 ` Tomi Valkeinen
2016-04-19 8:34 ` Laurent Pinchart
2016-04-18 15:42 ` [PATCH 4/4] drm/omap: fix OMAP4 hdmi_core_powerdown_disable() Tomi Valkeinen
2016-04-19 2:17 ` Laurent Pinchart [this message]
2016-04-19 5:36 ` [PATCH 1/4] drm/omap: Fix missing includes Tomi Valkeinen
2016-04-19 8:32 ` Laurent Pinchart
2016-04-19 8:48 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523377.BVFxig5LNh@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.