From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/omap: Fix missing includes
Date: Tue, 19 Apr 2016 11:48:00 +0300 [thread overview]
Message-ID: <5715F0C0.4090104@ti.com> (raw)
In-Reply-To: <1942777.PjVu1ImbyT@avalon>
[-- Attachment #1.1.1: Type: text/plain, Size: 950 bytes --]
On 19/04/16 11:32, Laurent Pinchart wrote:
>>> This driver uses the gpiod API only, you can remove gpio.h and of_gpio.h.
>>
>> True. I don't want to mix fixes and cleanups, so I made a new patch for
>> that:
>
> Given that you touch the two files in your "Fix missing includes" patch that
> seems a bit overkill to me, I would have squashed the two together, but it
> doesn't matter too much.
If the only thing the "Fix missing includes" patch would do is to touch
those two files and add the gpio/consumer.h, then... maybe. But it's
touching other files, and adding of.h too.
Maybe I'm being too pedantic, but I don't want to mix separate things
into the same patch. If in the description I write "This patch also does
xyz", I know I should split it up =).
I could have squashed the patch and just talked about "cleaning up the
includes". But that's not true, as the first patch is fixing compilation
issues.
Tomi
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-04-19 8:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 15:42 [PATCH 1/4] drm/omap: Fix missing includes Tomi Valkeinen
2016-04-18 15:42 ` [PATCH 2/4] drm/omap: remove unnecessary pitch round-up Tomi Valkeinen
2016-04-19 2:11 ` Laurent Pinchart
2016-04-18 15:42 ` [PATCH 3/4] drm/omap: remove align_pitch() Tomi Valkeinen
2016-04-19 2:12 ` Laurent Pinchart
2016-04-19 6:15 ` Tomi Valkeinen
2016-04-19 8:34 ` Laurent Pinchart
2016-04-18 15:42 ` [PATCH 4/4] drm/omap: fix OMAP4 hdmi_core_powerdown_disable() Tomi Valkeinen
2016-04-19 2:17 ` [PATCH 1/4] drm/omap: Fix missing includes Laurent Pinchart
2016-04-19 5:36 ` Tomi Valkeinen
2016-04-19 8:32 ` Laurent Pinchart
2016-04-19 8:48 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5715F0C0.4090104@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.