All of lore.kernel.org
 help / color / mirror / Atom feed
From: ben.hutchings@codethink.co.uk (Ben Hutchings)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] [PATCH 09/15] serial: sh-sci: Add pin initialization for SCIFA/SCIFB
Date: Tue, 10 Apr 2018 17:39:55 +0100	[thread overview]
Message-ID: <1523378395.2654.184.camel@codethink.co.uk> (raw)
In-Reply-To: <TYXPR01MB1775A455092699B98F41D92DC0D00@TYXPR01MB1775.jpnprd01.prod.outlook.com>

On Thu, 2018-03-15 at 14:33 +0000, Fabrizio Castro wrote:
> Hi Ben,
> 
> > Subject: Re: [cip-dev][PATCH 09/15] serial: sh-sci: Add pin initialization for SCIFA/SCIFB
> > 
> > [This sender failed our fraud detection checks and may not be who they appear to be. Learn about spoofing at
> > http://aka.ms/LearnAboutSpoofing]
> > 
> > On Mon, 2018-03-05 at 11:02 +0000, Fabrizio Castro wrote:
> > > From: Geert Uytterhoeven <geert+renesas@glider.be>
> > > 
> > > Before, the driver relied on initialization by the boot loader, or by
> > > implicit reset state.
> > > 
> > > Note that unlike on (H)SCIF, the RTS/CTS bits exist only if dedicated
> > > RTS/CTS pins are available, which depends on the SoC and UART instance.
> > > 
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > (cherry picked from commit e9d7a45a039913497a57887d85f5decfda4679f0)
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > 
> > [...]
> > 
> > Shouldn't we also take:
> > 
> > 5f76895e4c71 serial: sh-sci: Fix late enablement of AUTORTS
> > cfa6eb239154 serial: sh-sci: Fix (AUTO)RTS in sci_init_pins()
> 
> I had a quick look at those patches before submitting the series, and it looks
> like the second patch comes with a little bit of baggage (more backporting),
> and I wasn't sure where to draw the line.
> If you feel like those fixes are necessary I'll backport them, just let me know.

I'll accept your decision; I just wanted to make sure you didn't
accidentally leave them out.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.

  reply	other threads:[~2018-04-10 16:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05 11:01 [cip-dev] [PATCH 00/15] Add UART support to r8a7743 Fabrizio Castro
2018-03-05 11:01 ` [cip-dev] [PATCH 01/15] serial: sh-sci: Update DT binding documentation for GPIO modem lines Fabrizio Castro
2018-03-05 11:01 ` [cip-dev] [PATCH 02/15] serial: sh-sci: Update DT binding documentation for dedicated RTS/CTS Fabrizio Castro
2018-03-05 11:01 ` [cip-dev] [PATCH 03/15] serial: sh-sci: Always set TIOCM_CTS in .get_mctrl() callback Fabrizio Castro
2018-03-05 11:02 ` [cip-dev] [PATCH 04/15] serial: sh-sci: Add support for GPIO-controlled modem lines Fabrizio Castro
2018-03-05 11:02 ` [cip-dev] [PATCH 05/15] serial: sh-sci: Do not open-code sci_getreg() Fabrizio Castro
2018-03-05 11:02 ` [cip-dev] [PATCH 06/15] serial: sh-sci: Add more Serial Port Register documentation Fabrizio Castro
2018-03-05 11:02 ` [cip-dev] [PATCH 07/15] serial: sh-sci: Add more Serial Port Control/Data " Fabrizio Castro
2018-03-05 11:02 ` [cip-dev] [PATCH 08/15] serial: sh-sci: Correct pin initialization on (H)SCIF Fabrizio Castro
2018-03-05 11:02 ` [cip-dev] [PATCH 09/15] serial: sh-sci: Add pin initialization for SCIFA/SCIFB Fabrizio Castro
2018-03-12 16:26   ` Ben Hutchings
2018-03-15 14:33     ` Fabrizio Castro
2018-04-10 16:39       ` Ben Hutchings [this message]
2018-03-05 11:02 ` [cip-dev] [PATCH 10/15] serial: sh-sci: Fix support for hardware-assisted RTS/CTS Fabrizio Castro
2018-03-05 11:02 ` [cip-dev] [PATCH 11/15] serial: sh-sci: Add DT support for dedicated RTS/CTS Fabrizio Castro
2018-03-05 11:02 ` [cip-dev] [PATCH 12/15] ARM: dts: iwg20d-q7: Rework DT architecture Fabrizio Castro
2018-03-07 17:47   ` Ben Hutchings
2018-03-07 17:49     ` Ben Hutchings
2018-03-15 14:16       ` Fabrizio Castro
2018-03-15 14:08     ` Fabrizio Castro
2018-03-05 11:02 ` [cip-dev] [PATCH 13/15] ARM: dts: iwg20d-q7-dbcm-ca: Add device trees for camera DB Fabrizio Castro
2018-03-05 11:02 ` [cip-dev] [PATCH 14/15] ARM: dts: iwg20d-q7: Add support for ttySC3 Fabrizio Castro
2018-03-05 11:02 ` [cip-dev] [PATCH 15/15] ARM: dts: iwg20d-q7: Add chosen node Fabrizio Castro
2018-04-10 17:13 ` [cip-dev] [PATCH 00/15] Add UART support to r8a7743 Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1523378395.2654.184.camel@codethink.co.uk \
    --to=ben.hutchings@codethink.co.uk \
    --cc=cip-dev@lists.cip-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.