All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Pan <jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Alex Williamson
	<alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Jean-Philippe Brucker
	<jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
Cc: Raj Ashok <ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Rafael Wysocki
	<rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Subject: [PATCH v4 19/22] iommu/intel-svm: do not flush iotlb for viommu
Date: Mon, 16 Apr 2018 14:49:08 -0700	[thread overview]
Message-ID: <1523915351-54415-20-git-send-email-jacob.jun.pan@linux.intel.com> (raw)
In-Reply-To: <1523915351-54415-1-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

vIOMMU passdown invalidation will be inclusive, PASID cache invalidation
includes TLBs. See Intel VT-d Specification Ch 6.5.2.2 for details.

Signed-off-by: Jacob Pan <jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/iommu/intel-svm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c
index bdda1b6..697d5c2 100644
--- a/drivers/iommu/intel-svm.c
+++ b/drivers/iommu/intel-svm.c
@@ -284,7 +284,9 @@ static void intel_mm_release(struct mmu_notifier *mn, struct mm_struct *mm)
 	rcu_read_lock();
 	list_for_each_entry_rcu(sdev, &svm->devs, list) {
 		intel_flush_pasid_dev(svm, sdev, svm->pasid);
-		intel_flush_svm_range_dev(svm, sdev, 0, -1, 0, !svm->mm);
+		/* for emulated iommu, PASID cache invalidation implies IOTLB/DTLB */
+		if (!cap_caching_mode(svm->iommu->cap))
+			intel_flush_svm_range_dev(svm, sdev, 0, -1, 0, !svm->mm);
 	}
 	rcu_read_unlock();
 
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: iommu@lists.linux-foundation.org,
	LKML <linux-kernel@vger.kernel.org>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: Rafael Wysocki <rafael.j.wysocki@intel.com>,
	"Liu, Yi L" <yi.l.liu@intel.com>,
	"Tian, Kevin" <kevin.tian@intel.com>,
	Raj Ashok <ashok.raj@intel.com>,
	Jean Delvare <khali@linux-fr.org>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Lu Baolu" <baolu.lu@linux.intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: [PATCH v4 19/22] iommu/intel-svm: do not flush iotlb for viommu
Date: Mon, 16 Apr 2018 14:49:08 -0700	[thread overview]
Message-ID: <1523915351-54415-20-git-send-email-jacob.jun.pan@linux.intel.com> (raw)
In-Reply-To: <1523915351-54415-1-git-send-email-jacob.jun.pan@linux.intel.com>

vIOMMU passdown invalidation will be inclusive, PASID cache invalidation
includes TLBs. See Intel VT-d Specification Ch 6.5.2.2 for details.

Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
 drivers/iommu/intel-svm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c
index bdda1b6..697d5c2 100644
--- a/drivers/iommu/intel-svm.c
+++ b/drivers/iommu/intel-svm.c
@@ -284,7 +284,9 @@ static void intel_mm_release(struct mmu_notifier *mn, struct mm_struct *mm)
 	rcu_read_lock();
 	list_for_each_entry_rcu(sdev, &svm->devs, list) {
 		intel_flush_pasid_dev(svm, sdev, svm->pasid);
-		intel_flush_svm_range_dev(svm, sdev, 0, -1, 0, !svm->mm);
+		/* for emulated iommu, PASID cache invalidation implies IOTLB/DTLB */
+		if (!cap_caching_mode(svm->iommu->cap))
+			intel_flush_svm_range_dev(svm, sdev, 0, -1, 0, !svm->mm);
 	}
 	rcu_read_unlock();
 
-- 
2.7.4

  parent reply	other threads:[~2018-04-16 21:49 UTC|newest]

Thread overview: 129+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16 21:48 [PATCH v4 00/22] IOMMU and VT-d driver support for Shared Virtual Address (SVA) Jacob Pan
2018-04-16 21:48 ` Jacob Pan
2018-04-16 21:48 ` [PATCH v4 09/22] iommu/vt-d: add svm/sva invalidate function Jacob Pan
2018-04-16 21:48   ` Jacob Pan
     [not found]   ` <1523915351-54415-10-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-04-17 19:10     ` Alex Williamson
2018-04-17 19:10       ` Alex Williamson
     [not found]       ` <20180417131045.7635a63d-DGNDKt5SQtizQB+pC5nmwQ@public.gmane.org>
2018-04-20 22:36         ` Jacob Pan
2018-04-20 22:36           ` Jacob Pan
2018-04-16 21:48 ` [PATCH v4 10/22] iommu: introduce device fault data Jacob Pan
2018-04-16 21:48   ` Jacob Pan
     [not found]   ` <1523915351-54415-11-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-04-23 10:11     ` Jean-Philippe Brucker
2018-04-23 10:11       ` Jean-Philippe Brucker
     [not found]       ` <20180423101140.GA38106-U/l+663ovUtSq9BJjBFyUp/QNRX+jHPU@public.gmane.org>
2018-04-23 11:54         ` Jacob Pan
2018-04-23 11:54           ` Jacob Pan
2018-05-20  8:17   ` Liu, Yi L
     [not found]     ` <A2975661238FB949B60364EF0F2C257439BF3E05-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2018-05-21 23:16       ` Jacob Pan
2018-05-21 23:16         ` Jacob Pan
     [not found] ` <1523915351-54415-1-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-04-16 21:48   ` [PATCH v4 01/22] iommu: introduce bind_pasid_table API function Jacob Pan
2018-04-16 21:48     ` Jacob Pan
2018-04-16 21:48   ` [PATCH v4 02/22] iommu/vt-d: move device_domain_info to header Jacob Pan
2018-04-16 21:48     ` Jacob Pan
2018-04-16 21:48   ` [PATCH v4 03/22] iommu/vt-d: add a flag for pasid table bound status Jacob Pan
2018-04-16 21:48     ` Jacob Pan
2018-04-16 21:48   ` [PATCH v4 04/22] iommu/vt-d: add bind_pasid_table function Jacob Pan
2018-04-16 21:48     ` Jacob Pan
     [not found]     ` <1523915351-54415-5-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-04-17 19:10       ` Alex Williamson
2018-04-17 19:10         ` Alex Williamson
     [not found]         ` <20180417131047.0a9c310f-DGNDKt5SQtizQB+pC5nmwQ@public.gmane.org>
2018-04-20 18:25           ` Jean-Philippe Brucker
2018-04-20 18:25             ` Jean-Philippe Brucker
     [not found]             ` <AM4PR0802MB2369F739C91B630CA99B3D3BA3B40-Gx+wUQKpQCVHkdfAM7dXeUdOKmgb957onBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-04-20 23:42               ` Jacob Pan
2018-04-20 23:42                 ` Jacob Pan
2018-05-29 20:09                 ` Alex Williamson
2018-05-29 20:09                   ` Alex Williamson
     [not found]                   ` <20180529140915.1f174689-DGNDKt5SQtizQB+pC5nmwQ@public.gmane.org>
2018-05-30  1:41                     ` Tian, Kevin
2018-05-30  1:41                       ` Tian, Kevin
     [not found]                       ` <AADFC41AFE54684AB9EE6CBC0274A5D1911E59C4-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2018-05-30  3:17                         ` Alex Williamson
2018-05-30  3:17                           ` Alex Williamson
     [not found]                           ` <20180529211746.74f1dd23-DGNDKt5SQtizQB+pC5nmwQ@public.gmane.org>
2018-05-30  3:45                             ` Tian, Kevin
2018-05-30  3:45                               ` Tian, Kevin
     [not found]                               ` <AADFC41AFE54684AB9EE6CBC0274A5D1911E5F06-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2018-05-30 11:53                                 ` Jean-Philippe Brucker
2018-05-30 11:53                                   ` Jean-Philippe Brucker
     [not found]                                   ` <a07a0a0a-ebdd-c81a-7ed6-cff19e6078d7-5wv7dgnIgG8@public.gmane.org>
2018-05-30 19:52                                     ` Jacob Pan
2018-05-30 19:52                                       ` Jacob Pan
2018-05-31  9:09                                       ` Jean-Philippe Brucker
2018-05-31  9:09                                         ` Jean-Philippe Brucker
2018-06-05 17:32                                         ` Jacob Pan
2018-06-06 11:20                                           ` Jean-Philippe Brucker
2018-06-06 11:20                                             ` Jean-Philippe Brucker
2018-06-06 21:22                                             ` Jacob Pan
2018-06-07 13:21                                               ` Jean-Philippe Brucker
2018-04-20 23:22           ` Jacob Pan
2018-04-20 23:22             ` Jacob Pan
2018-04-16 21:48   ` [PATCH v4 05/22] iommu: introduce iommu invalidate API function Jacob Pan
2018-04-16 21:48     ` Jacob Pan
     [not found]     ` <1523915351-54415-6-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-04-20 18:19       ` Jean-Philippe Brucker
2018-04-20 18:19         ` Jean-Philippe Brucker
     [not found]         ` <20180420181951.GA50099-U/l+663ovUtSq9BJjBFyUp/QNRX+jHPU@public.gmane.org>
2018-04-23 20:43           ` Jacob Pan
2018-04-23 20:43             ` Jacob Pan
2018-04-27 18:07             ` Jean-Philippe Brucker
2018-04-27 18:07               ` Jean-Philippe Brucker
     [not found]               ` <72ee47c4-55fa-4ff1-d94e-cc26203e3eda-5wv7dgnIgG8@public.gmane.org>
2018-04-28  2:41                 ` Tian, Kevin
2018-04-28  2:41                   ` Tian, Kevin
2018-05-01 22:58                 ` Jacob Pan
2018-05-01 22:58                   ` Jacob Pan
2018-05-02  9:31                   ` Jean-Philippe Brucker
2018-05-02  9:31                     ` Jean-Philippe Brucker
     [not found]                     ` <b12bcd35-9472-83ed-a26f-e5be3794e2d2-5wv7dgnIgG8@public.gmane.org>
2018-05-04  4:46                       ` Jacob Pan
2018-05-04  4:46                         ` Jacob Pan
2018-05-04 18:07                         ` Jacob Pan
2018-05-04 18:07                           ` Jacob Pan
2018-05-08 10:35                           ` Jean-Philippe Brucker
2018-05-08 10:35                             ` Jean-Philippe Brucker
     [not found]                             ` <ef462e73-01e3-d581-cf91-3e012a337c61-5wv7dgnIgG8@public.gmane.org>
2018-05-09 12:55                               ` Jacob Pan
2018-05-09 12:55                                 ` Jacob Pan
2018-05-05 22:19       ` Jerry Snitselaar
2018-05-05 22:19         ` Jerry Snitselaar
2018-05-07 15:41         ` Jacob Pan
2018-05-07 15:41           ` Jacob Pan
2018-04-16 21:48   ` [PATCH v4 06/22] iommu/vt-d: add definitions for PFSID Jacob Pan
2018-04-16 21:48     ` Jacob Pan
2018-04-16 21:48   ` [PATCH v4 07/22] iommu/vt-d: fix dev iotlb pfsid use Jacob Pan
2018-04-16 21:48     ` Jacob Pan
2018-04-16 21:48   ` [PATCH v4 08/22] iommu/vt-d: support flushing more translation cache types Jacob Pan
2018-04-16 21:48     ` Jacob Pan
2018-04-16 21:49   ` [PATCH v4 11/22] driver core: add per device iommu param Jacob Pan
2018-04-16 21:49     ` Jacob Pan
     [not found]     ` <1523915351-54415-12-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-04-23 10:26       ` Greg Kroah-Hartman
2018-04-23 10:26         ` Greg Kroah-Hartman
2018-04-16 21:49   ` [PATCH v4 12/22] iommu: introduce device fault report API Jacob Pan
2018-04-16 21:49     ` Jacob Pan
     [not found]     ` <1523915351-54415-13-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-04-23 11:30       ` Jean-Philippe Brucker
2018-04-23 11:30         ` Jean-Philippe Brucker
     [not found]         ` <20180423113013.GB38106-U/l+663ovUtSq9BJjBFyUp/QNRX+jHPU@public.gmane.org>
2018-04-24 18:29           ` Jacob Pan
2018-04-24 18:29             ` Jacob Pan
2018-04-30 16:53       ` Jean-Philippe Brucker
2018-04-30 16:53         ` Jean-Philippe Brucker
2018-04-30 18:54         ` Jacob Pan
2018-04-16 21:49   ` [PATCH v4 13/22] iommu: introduce page response function Jacob Pan
2018-04-16 21:49     ` Jacob Pan
     [not found]     ` <1523915351-54415-14-git-send-email-jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-04-23 11:47       ` Jean-Philippe Brucker
2018-04-23 11:47         ` Jean-Philippe Brucker
     [not found]         ` <AM4PR0802MB23698019B80CCE6B083D1448A3890-Gx+wUQKpQCVHkdfAM7dXeUdOKmgb957onBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-04-23 12:16           ` Jacob Pan
2018-04-23 12:16             ` Jacob Pan
2018-04-23 15:50             ` Jean-Philippe Brucker
2018-04-23 15:50               ` Jean-Philippe Brucker
2018-04-16 21:49   ` [PATCH v4 14/22] iommu: handle page response timeout Jacob Pan
2018-04-16 21:49     ` Jacob Pan
2018-04-23 15:36     ` Jean-Philippe Brucker
     [not found]       ` <20180423153622.GC38106-U/l+663ovUtSq9BJjBFyUp/QNRX+jHPU@public.gmane.org>
2018-04-25 15:37         ` Jacob Pan
2018-04-25 15:37           ` Jacob Pan
2018-04-30 10:58           ` Jean-Philippe Brucker
2018-04-30 10:58             ` Jean-Philippe Brucker
     [not found]             ` <e98a1385-9e55-c021-4e89-7d07701f4b84-5wv7dgnIgG8@public.gmane.org>
2018-04-30 17:54               ` Jacob Pan
2018-04-30 17:54                 ` Jacob Pan
2018-04-16 21:49   ` [PATCH v4 15/22] iommu/config: add build dependency for dmar Jacob Pan
2018-04-16 21:49     ` Jacob Pan
2018-04-16 21:49   ` [PATCH v4 16/22] iommu/vt-d: report non-recoverable faults to device Jacob Pan
2018-04-16 21:49     ` Jacob Pan
2018-04-16 21:49   ` [PATCH v4 17/22] iommu/intel-svm: report device page request Jacob Pan
2018-04-16 21:49     ` Jacob Pan
2018-04-16 21:49   ` [PATCH v4 18/22] iommu/intel-svm: replace dev ops with fault report API Jacob Pan
2018-04-16 21:49     ` Jacob Pan
2018-04-16 21:49   ` Jacob Pan [this message]
2018-04-16 21:49     ` [PATCH v4 19/22] iommu/intel-svm: do not flush iotlb for viommu Jacob Pan
2018-04-16 21:49   ` [PATCH v4 20/22] iommu/vt-d: add intel iommu page response function Jacob Pan
2018-04-16 21:49     ` Jacob Pan
2018-04-16 21:49 ` [PATCH v4 21/22] trace/iommu: add sva trace events Jacob Pan
2018-04-16 21:49 ` [PATCH v4 22/22] iommu: use sva invalidate and device fault trace event Jacob Pan
  -- strict thread matches above, loose matches on Subject: below --
2018-03-23  3:11 [PATCH v4 00/22] IOMMU and VT-d driver support for Shared Virtual Address (SVA) Jacob Pan
2018-03-23  3:12 ` [PATCH v4 19/22] iommu/intel-svm: do not flush iotlb for viommu Jacob Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1523915351-54415-20-git-send-email-jacob.jun.pan@linux.intel.com \
    --to=jacob.jun.pan-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.