From: Johannes Berg <johannes@sipsolutions.net>
To: Sriram R <srirrama@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 0/2] nl80211/mac80211 Add support for per-rate rx statistics
Date: Tue, 15 May 2018 09:00:03 +0200 [thread overview]
Message-ID: <1526367603.3255.3.camel@sipsolutions.net> (raw)
In-Reply-To: <1526361481-7159-1-git-send-email-srirrama@codeaurora.org>
On Tue, 2018-05-15 at 10:47 +0530, Sriram R wrote:
> This patchset adds support for the collection and propagating of
> per-rate, per-station rx statistics when enabled by a userspace application.
>
> These statistics can be useful in understanding the quality of
> communication with our peers and in evaluating how different peers
> are communicating in different MCS/BW/NSS during different time periods and environment.
So ... I know that you're aware of my rate statistics collection code
(at least you should be, I showed it to Jouni), so I think you should
state why that approach isn't suitable.
In particular, I don't like the idea that you implement here of allowing
unresponsive (or dead) userspace to let the data pile up indefinitely. I
think we should be sending it out upon reaching a threshold to limit the
memory consumption in the kernel more reliably.
johannes
next prev parent reply other threads:[~2018-05-15 7:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 5:17 [RFC 0/2] nl80211/mac80211 Add support for per-rate rx statistics Sriram R
2018-05-15 5:18 ` [RFC 1/2] nl80211: Add support for collection of per rate " Sriram R
2018-05-15 5:18 ` [RFC 2/2] mac80211: Add support for per-rate " Sriram R
2018-05-15 7:00 ` Johannes Berg [this message]
2018-05-16 4:34 ` [RFC 0/2] nl80211/mac80211 " Sriram R
2018-05-18 9:30 ` Johannes Berg
2018-05-21 3:46 ` Sriram R
2018-05-15 8:51 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526367603.3255.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=srirrama@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.