From: Johannes Berg <johannes@sipsolutions.net>
To: Sriram R <srirrama@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 0/2] nl80211/mac80211 Add support for per-rate rx statistics
Date: Fri, 18 May 2018 11:30:05 +0200 [thread overview]
Message-ID: <1526635805.3805.7.camel@sipsolutions.net> (raw)
In-Reply-To: <44cd0e995e3caf7b44fcf5676cb57b5a@codeaurora.org>
On Wed, 2018-05-16 at 10:04 +0530, Sriram R wrote:
> But, I wanted to avoid,
> 1. Static indexing and memory allocation based on MCS count((8x3)24
> entries for HT and (10x3)30 for VHT within allocated 36 entries) so that
> it's scalable.
Do you expect that the rate control on the other side flips through
MCSes so fast that this little cache will need to be flushed
significantly?
> 2. Remote chance of dropping a stats(Though it does not have much
> impact)
Yeah this doesn't seem like a concern either way. How many packets and
how little time ... :)
> And to allow,
> 1. A 'station dump' kind of interface to dump the complete collected
> stats instead of returning only current snapshot of the stats within
> kernel.
This *completely* contradict keeping limits on the kernel memory
consumed, so basically I don't think this is feasible.
> Also, do you feel it would be good to have both ,i.e complete stats
> collection within kernel(this approach) and dump+clear of stats on
> reaching threshold(your approach) and have one of these two modes
> selected based on the requirement.
No, honestly, I don't. If an application wants these statistics, then I
feel that we can impose *some* requirements and not leave it at "let me
just enable it and have the kernel do all the work for me".
johannes
next prev parent reply other threads:[~2018-05-18 9:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 5:17 [RFC 0/2] nl80211/mac80211 Add support for per-rate rx statistics Sriram R
2018-05-15 5:18 ` [RFC 1/2] nl80211: Add support for collection of per rate " Sriram R
2018-05-15 5:18 ` [RFC 2/2] mac80211: Add support for per-rate " Sriram R
2018-05-15 7:00 ` [RFC 0/2] nl80211/mac80211 " Johannes Berg
2018-05-16 4:34 ` Sriram R
2018-05-18 9:30 ` Johannes Berg [this message]
2018-05-21 3:46 ` Sriram R
2018-05-15 8:51 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526635805.3805.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=srirrama@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.