From: Ray Jui <ray.jui@broadcom.com>
To: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Frank Rowand <frowand.list@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Robin Murphy <robin.murphy@arm.com>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Ray Jui <ray.jui@broadcom.com>
Subject: [PATCH v4 4/6] watchdog: sp805: set WDOG_HW_RUNNING when appropriate
Date: Mon, 28 May 2018 11:01:35 -0700 [thread overview]
Message-ID: <1527530497-10392-5-git-send-email-ray.jui@broadcom.com> (raw)
In-Reply-To: <1527530497-10392-1-git-send-email-ray.jui@broadcom.com>
If the watchdog hardware is already enabled during the boot process,
when the Linux watchdog driver loads, it should reset the watchdog and
tell the watchdog framework. As a result, ping can be generated from
the watchdog framework, until the userspace watchdog daemon takes over
control
Signed-off-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/watchdog/sp805_wdt.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
index 1484609..d662a6f 100644
--- a/drivers/watchdog/sp805_wdt.c
+++ b/drivers/watchdog/sp805_wdt.c
@@ -42,6 +42,7 @@
/* control register masks */
#define INT_ENABLE (1 << 0)
#define RESET_ENABLE (1 << 1)
+ #define ENABLE_MASK (INT_ENABLE | RESET_ENABLE)
#define WDTINTCLR 0x00C
#define WDTRIS 0x010
#define WDTMIS 0x014
@@ -74,6 +75,15 @@ module_param(nowayout, bool, 0);
MODULE_PARM_DESC(nowayout,
"Set to 1 to keep watchdog running after device release");
+/* returns true if wdt is running; otherwise returns false */
+static bool wdt_is_running(struct watchdog_device *wdd)
+{
+ struct sp805_wdt *wdt = watchdog_get_drvdata(wdd);
+ u32 wdtcontrol = readl_relaxed(wdt->base + WDTCONTROL);
+
+ return (wdtcontrol & ENABLE_MASK) == ENABLE_MASK;
+}
+
/* This routine finds load value that will reset system in required timout */
static int wdt_setload(struct watchdog_device *wdd, unsigned int timeout)
{
@@ -239,6 +249,15 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id)
watchdog_init_timeout(&wdt->wdd, 0, &adev->dev);
wdt_setload(&wdt->wdd, wdt->wdd.timeout);
+ /*
+ * If HW is already running, enable/reset the wdt and set the running
+ * bit to tell the wdt subsystem
+ */
+ if (wdt_is_running(&wdt->wdd)) {
+ wdt_enable(&wdt->wdd);
+ set_bit(WDOG_HW_RUNNING, &wdt->wdd.status);
+ }
+
ret = watchdog_register_device(&wdt->wdd);
if (ret) {
dev_err(&adev->dev, "watchdog_register_device() failed: %d\n",
--
2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: ray.jui@broadcom.com (Ray Jui)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/6] watchdog: sp805: set WDOG_HW_RUNNING when appropriate
Date: Mon, 28 May 2018 11:01:35 -0700 [thread overview]
Message-ID: <1527530497-10392-5-git-send-email-ray.jui@broadcom.com> (raw)
In-Reply-To: <1527530497-10392-1-git-send-email-ray.jui@broadcom.com>
If the watchdog hardware is already enabled during the boot process,
when the Linux watchdog driver loads, it should reset the watchdog and
tell the watchdog framework. As a result, ping can be generated from
the watchdog framework, until the userspace watchdog daemon takes over
control
Signed-off-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/watchdog/sp805_wdt.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
index 1484609..d662a6f 100644
--- a/drivers/watchdog/sp805_wdt.c
+++ b/drivers/watchdog/sp805_wdt.c
@@ -42,6 +42,7 @@
/* control register masks */
#define INT_ENABLE (1 << 0)
#define RESET_ENABLE (1 << 1)
+ #define ENABLE_MASK (INT_ENABLE | RESET_ENABLE)
#define WDTINTCLR 0x00C
#define WDTRIS 0x010
#define WDTMIS 0x014
@@ -74,6 +75,15 @@ module_param(nowayout, bool, 0);
MODULE_PARM_DESC(nowayout,
"Set to 1 to keep watchdog running after device release");
+/* returns true if wdt is running; otherwise returns false */
+static bool wdt_is_running(struct watchdog_device *wdd)
+{
+ struct sp805_wdt *wdt = watchdog_get_drvdata(wdd);
+ u32 wdtcontrol = readl_relaxed(wdt->base + WDTCONTROL);
+
+ return (wdtcontrol & ENABLE_MASK) == ENABLE_MASK;
+}
+
/* This routine finds load value that will reset system in required timout */
static int wdt_setload(struct watchdog_device *wdd, unsigned int timeout)
{
@@ -239,6 +249,15 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id)
watchdog_init_timeout(&wdt->wdd, 0, &adev->dev);
wdt_setload(&wdt->wdd, wdt->wdd.timeout);
+ /*
+ * If HW is already running, enable/reset the wdt and set the running
+ * bit to tell the wdt subsystem
+ */
+ if (wdt_is_running(&wdt->wdd)) {
+ wdt_enable(&wdt->wdd);
+ set_bit(WDOG_HW_RUNNING, &wdt->wdd.status);
+ }
+
ret = watchdog_register_device(&wdt->wdd);
if (ret) {
dev_err(&adev->dev, "watchdog_register_device() failed: %d\n",
--
2.1.4
next prev parent reply other threads:[~2018-05-28 18:02 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 18:01 [PATCH v4 0/6] Enhance support for the SP805 WDT Ray Jui
2018-05-28 18:01 ` Ray Jui
2018-05-28 18:01 ` [PATCH v4 1/6] Documentation: DT: Consolidate SP805 binding docs Ray Jui
2018-05-28 18:01 ` Ray Jui
2018-06-05 19:41 ` Rob Herring
2018-06-05 19:41 ` Rob Herring
2018-06-06 16:19 ` Guenter Roeck
2018-06-06 16:19 ` Guenter Roeck
2018-06-06 16:33 ` Rob Herring
2018-06-06 16:33 ` Rob Herring
2018-06-06 23:39 ` Ray Jui
2018-06-06 23:39 ` Ray Jui
2018-06-20 17:39 ` Ray Jui
2018-06-20 17:39 ` Ray Jui
2018-06-27 18:33 ` Guenter Roeck
2018-06-27 18:33 ` Guenter Roeck
2018-06-27 18:38 ` Ray Jui
2018-06-27 18:38 ` Ray Jui
2018-06-27 18:42 ` Guenter Roeck
2018-06-27 18:42 ` Guenter Roeck
2018-06-27 18:47 ` Ray Jui
2018-06-27 18:47 ` Ray Jui
2018-06-27 18:55 ` Guenter Roeck
2018-06-27 18:55 ` Guenter Roeck
2018-06-28 23:50 ` Ray Jui
2018-06-28 23:50 ` Ray Jui
2018-06-29 3:00 ` Guenter Roeck
2018-06-29 3:00 ` Guenter Roeck
2018-06-29 2:55 ` [v4,1/6] " Guenter Roeck
2018-06-29 2:55 ` Guenter Roeck
2018-05-28 18:01 ` [PATCH v4 2/6] Documentation: DT: Add optional 'timeout-sec' property for sp805 Ray Jui
2018-05-28 18:01 ` Ray Jui
2018-05-28 18:01 ` Ray Jui
2018-06-05 19:55 ` Rob Herring
2018-06-05 19:55 ` Rob Herring
2018-06-29 2:55 ` [v4, " Guenter Roeck
2018-06-29 2:55 ` Guenter Roeck
2018-05-28 18:01 ` [PATCH v4 3/6] watchdog: sp805: add 'timeout-sec' DT property support Ray Jui
2018-05-28 18:01 ` Ray Jui
2018-05-28 18:01 ` Ray Jui [this message]
2018-05-28 18:01 ` [PATCH v4 4/6] watchdog: sp805: set WDOG_HW_RUNNING when appropriate Ray Jui
2018-05-28 18:01 ` [PATCH v4 5/6] arm64: dt: set initial SR watchdog timeout to 60 seconds Ray Jui
2018-05-28 18:01 ` Ray Jui
2018-07-09 17:40 ` Florian Fainelli
2018-07-09 17:40 ` Florian Fainelli
2018-05-28 18:01 ` [PATCH v4 6/6] arm64: defconfig: add CONFIG_ARM_SP805_WATCHDOG Ray Jui
2018-05-28 18:01 ` Ray Jui
2018-07-09 17:40 ` Florian Fainelli
2018-07-09 17:40 ` Florian Fainelli
2018-06-06 19:29 ` [PATCH v4 0/6] Enhance support for the SP805 WDT Florian Fainelli
2018-06-06 19:29 ` Florian Fainelli
2018-06-06 23:40 ` Ray Jui
2018-06-06 23:40 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527530497-10392-5-git-send-email-ray.jui@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.