From: "Duyck, Alexander H" <alexander.h.duyck@intel.com>
To: "mst@redhat.com" <mst@redhat.com>,
"alexander.duyck@gmail.com" <alexander.duyck@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"Rustad, Mark D" <mark.d.rustad@intel.com>,
"Daly, Dan" <dan.daly@intel.com>,
"Bie, Tiwei" <tiwei.bie@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"Liang, Cunming" <cunming.liang@intel.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>
Subject: Re: [virtio-dev] [PATCH] virtio_pci: support enabling VFs
Date: Wed, 30 May 2018 16:26:30 +0000 [thread overview]
Message-ID: <1527697588.16245.136.camel@intel.com> (raw)
In-Reply-To: <20180530192215-mutt-send-email-mst@kernel.org>
T24gV2VkLCAyMDE4LTA1LTMwIGF0IDE5OjIyICswMzAwLCBNaWNoYWVsIFMuIFRzaXJraW4gd3Jv
dGU6DQo+IE9uIFdlZCwgTWF5IDMwLCAyMDE4IGF0IDA5OjEwOjU3QU0gLTA3MDAsIEFsZXhhbmRl
ciBEdXljayB3cm90ZToNCj4gPiBPbiBXZWQsIE1heSAzMCwgMjAxOCBhdCAxOjU1IEFNLCBUaXdl
aSBCaWUgPHRpd2VpLmJpZUBpbnRlbC5jb20+IHdyb3RlOg0KPiA+ID4gVGhlcmUgaXMgYSBuZXcg
ZmVhdHVyZSBiaXQgYWxsb2NhdGVkIGluIHZpcnRpbyBzcGVjIHRvDQo+ID4gPiBzdXBwb3J0IFNS
LUlPViAoU2luZ2xlIFJvb3QgSS9PIFZpcnR1YWxpemF0aW9uKToNCj4gPiA+IA0KPiA+ID4gaHR0
cHM6Ly9naXRodWIuY29tL29hc2lzLXRjcy92aXJ0aW8tc3BlYy9pc3N1ZXMvMTENCj4gPiA+IA0K
PiA+ID4gVGhpcyBwYXRjaCBlbmFibGVzIHRoZSBzdXBwb3J0IGZvciB0aGlzIGZlYXR1cmUgYml0
IGluDQo+ID4gPiB2aXJ0aW8gZHJpdmVyLg0KPiA+ID4gDQo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBU
aXdlaSBCaWUgPHRpd2VpLmJpZUBpbnRlbC5jb20+DQo+ID4gDQo+ID4gU28gZnJvbSBhIHF1aWNr
IGdsYW5jZSBpdCBsb29rcyBsaWtlIHdlIGFyZSBsZWF2aW5nIFNSLUlPViBlbmFibGVkIGlmDQo+
ID4gdGhlIGRyaXZlciBpcyByZW1vdmVkLiBEbyB3ZSB3YW50IHRvIGhhdmUgdGhhdCBiZWhhdmlv
ciBvciBzaG91bGQgd2UNCj4gPiBiZSBhZGRpbmcgdGhlIGNvZGUgdG8gZGlzYWJsZSBTUi1JT1Yg
YW5kIGZyZWUgdGhlIFZGcyBvbiBkcml2ZXINCj4gPiByZW1vdmFsPw0KPiANCj4gQ291bGQgcGNp
IGNvcmUgaGFuZGxlIGl0IGZvciB1cyBzb21laG93Pw0KDQpNYXliZSwgYnV0IGl0IHdvdWxkIHJl
cXVpcmUgY2hhbmdlcyB0byB0aGUgcGNpIGNvcmUgdG8gZG8gaXQuDQoNClRoZSBwcm9ibGVtIGlz
IHNvbWUgZHJpdmVycyB3YW50IHRvIGxlYXZlIHRoZSBWRnMgdGhlcmUgc2luY2UgdGhlIFBGDQpk
b2Vzbid0IHJlYWxseSBkbyBhbnl0aGluZywgb3IgdGhleSBoYXZlIHRoZSBvcHRpb24gb2YgZXNz
ZW50aWFsbHkNCnB1dHRpbmcgdGhlIFZGcyBpbnRvIGEgc3RhbmRieSBzdGF0ZSB3aGVuIHRoZSBQ
RiBpcyBnb25lLg0KDQpNeSBtYWluIGNvbmNlcm4gaXMgZG8gd2UgY2FyZSBpZiBWRnMgYXJlIGFs
bG9jYXRlZCBhbmQgdGhlbiBzb21lYm9keQ0KcmVtb3ZlcyB0aGUgZHJpdmVyIGFuZCBiaW5kcyBh
IGRpZmZlcmVudCBkcml2ZXIgdG8gdGhlIGludGVyZmFjZT8gSWYNCm5vdCB0aGVuIHRoaXMgY29k
ZSBhbmQgYmUgbGVmdCBhcyBpcywgYnV0IEkganVzdCB3YW50ZWQgdG8gYmUgY2VydGFpbg0Kc2lu
Y2UgSSBrbm93IHRoaXMgaXNuJ3QganVzdCBlbmFibGluZyBTUi1JT1Ygd2UgYXJlIGhhdmluZyB0
byBkbyBhDQpudW1iZXIgb2Ygb3RoZXIgY2hlY2tzIGFnYWluc3QgdGhlIHZpcnRpbyBkZXZpY2Uu
WARNING: multiple messages have this Message-ID (diff)
From: "Duyck, Alexander H" <alexander.h.duyck@intel.com>
To: "mst@redhat.com" <mst@redhat.com>,
"alexander.duyck@gmail.com" <alexander.duyck@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"Rustad, Mark D" <mark.d.rustad@intel.com>,
"Daly, Dan" <dan.daly@intel.com>,
"Bie, Tiwei" <tiwei.bie@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"Liang, Cunming" <cunming.liang@intel.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>
Subject: Re: [virtio-dev] [PATCH] virtio_pci: support enabling VFs
Date: Wed, 30 May 2018 16:26:30 +0000 [thread overview]
Message-ID: <1527697588.16245.136.camel@intel.com> (raw)
In-Reply-To: <20180530192215-mutt-send-email-mst@kernel.org>
On Wed, 2018-05-30 at 19:22 +0300, Michael S. Tsirkin wrote:
> On Wed, May 30, 2018 at 09:10:57AM -0700, Alexander Duyck wrote:
> > On Wed, May 30, 2018 at 1:55 AM, Tiwei Bie <tiwei.bie@intel.com> wrote:
> > > There is a new feature bit allocated in virtio spec to
> > > support SR-IOV (Single Root I/O Virtualization):
> > >
> > > https://github.com/oasis-tcs/virtio-spec/issues/11
> > >
> > > This patch enables the support for this feature bit in
> > > virtio driver.
> > >
> > > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> >
> > So from a quick glance it looks like we are leaving SR-IOV enabled if
> > the driver is removed. Do we want to have that behavior or should we
> > be adding the code to disable SR-IOV and free the VFs on driver
> > removal?
>
> Could pci core handle it for us somehow?
Maybe, but it would require changes to the pci core to do it.
The problem is some drivers want to leave the VFs there since the PF
doesn't really do anything, or they have the option of essentially
putting the VFs into a standby state when the PF is gone.
My main concern is do we care if VFs are allocated and then somebody
removes the driver and binds a different driver to the interface? If
not then this code and be left as is, but I just wanted to be certain
since I know this isn't just enabling SR-IOV we are having to do a
number of other checks against the virtio device.
next prev parent reply other threads:[~2018-05-30 16:26 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 8:55 [PATCH] virtio_pci: support enabling VFs Tiwei Bie
2018-05-30 8:55 ` [virtio-dev] " Tiwei Bie
2018-05-30 12:29 ` Stefan Hajnoczi
2018-05-30 12:29 ` Stefan Hajnoczi
2018-05-30 12:41 ` Michael S. Tsirkin
2018-05-30 12:41 ` [virtio-dev] " Michael S. Tsirkin
2018-05-30 12:41 ` Michael S. Tsirkin
2018-05-30 16:03 ` [virtio-dev] " Rustad, Mark D
2018-05-30 16:03 ` Rustad, Mark D
2018-05-30 16:09 ` Michael S. Tsirkin
2018-05-30 16:09 ` Michael S. Tsirkin
2018-05-31 2:55 ` Tiwei Bie
2018-05-31 2:55 ` Tiwei Bie
2018-05-31 2:55 ` Tiwei Bie
2018-06-01 1:21 ` Michael S. Tsirkin
2018-06-01 1:21 ` Michael S. Tsirkin
2018-06-01 1:36 ` Tiwei Bie
2018-06-01 1:36 ` Tiwei Bie
2018-06-01 1:36 ` Tiwei Bie
2018-06-01 1:21 ` Michael S. Tsirkin
2018-05-30 16:09 ` Michael S. Tsirkin
2018-05-30 16:10 ` Alexander Duyck
2018-05-30 16:10 ` Alexander Duyck
2018-05-30 16:22 ` Michael S. Tsirkin
2018-05-30 16:22 ` Michael S. Tsirkin
2018-05-30 16:22 ` Michael S. Tsirkin
2018-05-30 16:26 ` Duyck, Alexander H
2018-05-30 16:26 ` Duyck, Alexander H [this message]
2018-05-30 16:26 ` Duyck, Alexander H
2018-05-30 17:15 ` Michael S. Tsirkin
2018-05-30 17:15 ` Michael S. Tsirkin
2018-05-30 17:15 ` Michael S. Tsirkin
2018-05-30 16:10 ` Alexander Duyck
2018-05-30 16:22 ` Michael S. Tsirkin
2018-05-30 16:22 ` [virtio-dev] " Michael S. Tsirkin
2018-05-30 16:44 ` Rustad, Mark D
2018-05-30 16:44 ` Rustad, Mark D
2018-05-30 16:44 ` [virtio-dev] " Rustad, Mark D
2018-05-30 16:54 ` Duyck, Alexander H
2018-05-30 16:54 ` Duyck, Alexander H
2018-05-30 17:11 ` Rustad, Mark D
2018-05-30 17:11 ` Rustad, Mark D
2018-05-30 17:11 ` [virtio-dev] " Rustad, Mark D
2018-05-31 3:20 ` Tiwei Bie
2018-05-31 3:20 ` Tiwei Bie
2018-05-31 3:20 ` [virtio-dev] " Tiwei Bie
2018-05-31 14:27 ` Alexander Duyck
2018-05-31 14:27 ` Alexander Duyck
2018-05-31 14:27 ` [virtio-dev] " Alexander Duyck
2018-06-01 2:30 ` Tiwei Bie
2018-06-01 2:30 ` [virtio-dev] " Tiwei Bie
2018-06-01 2:30 ` Tiwei Bie
2018-05-30 16:54 ` Duyck, Alexander H
2018-05-30 16:22 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527697588.16245.136.camel@intel.com \
--to=alexander.h.duyck@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=bhelgaas@google.com \
--cc=cunming.liang@intel.com \
--cc=dan.daly@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
--cc=mst@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.