* [PATCH] drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw
@ 2018-05-17 13:26 Mahesh Kumar
2018-05-17 14:00 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mahesh Kumar @ 2018-05-17 13:26 UTC (permalink / raw)
To: intel-gfx; +Cc: rodrigo.vivi
Do not update number of enabled dbuf slices in dev_priv struct until we
actually enable/disable dbuf slice in hw. This is leading to never
updating dbuf slices and resulting in DBuf slice mismatch warning.
Fixes: aa9664ffe863 ("drm/i915/icl: Enable 2nd DBuf slice only when needed")
Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index b85229e153c4..53aaaa3e6886 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5150,7 +5150,6 @@ skl_copy_ddb_for_pipe(struct skl_ddb_values *dst,
sizeof(dst->ddb.uv_plane[pipe]));
memcpy(dst->ddb.plane[pipe], src->ddb.plane[pipe],
sizeof(dst->ddb.plane[pipe]));
- dst->ddb.enabled_slices = src->ddb.enabled_slices;
}
static void
--
2.16.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw
2018-05-17 13:26 [PATCH] drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw Mahesh Kumar
@ 2018-05-17 14:00 ` Patchwork
2018-05-17 17:02 ` ✓ Fi.CI.IGT: " Patchwork
2018-06-04 23:49 ` [PATCH] " Paulo Zanoni
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-05-17 14:00 UTC (permalink / raw)
To: Mahesh Kumar; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw
URL : https://patchwork.freedesktop.org/series/43330/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4196 -> Patchwork_9028 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/43330/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9028 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-FAIL (fdo#106103, fdo#102614)
==== Possible fixes ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-cnl-y3: DMESG-FAIL (fdo#104724, fdo#103191) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: INCOMPLETE (fdo#103927) -> PASS
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
== Participating hosts (40 -> 38) ==
Additional (3): fi-byt-j1900 fi-cfl-guc fi-kbl-guc
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-glk-j4005 fi-bsw-cyan fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4196 -> Patchwork_9028
CI_DRM_4196: 624ef35328293cfb60f26b5fbc9cc97eeab505b5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4487: eccae1360d6d01e73c6af2bd97122cef708207ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9028: e81bef60683f2aac798bb75836ae7bf0e6d8f89a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4487: 6ab75f7eb5e1dccbb773e1739beeb2d7cbd6ad0d @ git://anongit.freedesktop.org/piglit
== Linux commits ==
e81bef60683f drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9028/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw
2018-05-17 13:26 [PATCH] drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw Mahesh Kumar
2018-05-17 14:00 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-05-17 17:02 ` Patchwork
2018-06-04 23:49 ` [PATCH] " Paulo Zanoni
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-05-17 17:02 UTC (permalink / raw)
To: Mahesh Kumar; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw
URL : https://patchwork.freedesktop.org/series/43330/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4196_full -> Patchwork_9028_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9028_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9028_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/43330/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9028_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-bsd1:
shard-kbl: PASS -> SKIP +2
igt@gem_exec_schedule@deep-bsd2:
shard-kbl: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_9028_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
shard-glk: PASS -> FAIL (fdo#105703)
igt@kms_flip@flip-vs-dpms-off-vs-modeset-interruptible:
shard-hsw: PASS -> DMESG-WARN (fdo#102614)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
shard-glk: PASS -> FAIL (fdo#104724, fdo#103167)
igt@perf@polling:
shard-hsw: PASS -> FAIL (fdo#102252)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
shard-kbl: DMESG-FAIL -> PASS
shard-glk: DMESG-FAIL -> PASS
igt@gem_exec_store@cachelines-bsd:
shard-hsw: FAIL (fdo#100007) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#102887) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS +1
igt@kms_flip@plain-flip-fb-recreate-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS +1
igt@kms_flip_tiling@flip-x-tiled:
shard-glk: FAIL (fdo#103822, fdo#104724) -> PASS +2
igt@kms_rotation_crc@sprite-rotation-180:
shard-hsw: FAIL (fdo#103925, fdo#104724) -> PASS
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
== Participating hosts (9 -> 9) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4196 -> Patchwork_9028
CI_DRM_4196: 624ef35328293cfb60f26b5fbc9cc97eeab505b5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4487: eccae1360d6d01e73c6af2bd97122cef708207ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9028: e81bef60683f2aac798bb75836ae7bf0e6d8f89a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4487: 6ab75f7eb5e1dccbb773e1739beeb2d7cbd6ad0d @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9028/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw
2018-05-17 13:26 [PATCH] drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw Mahesh Kumar
2018-05-17 14:00 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-05-17 17:02 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-06-04 23:49 ` Paulo Zanoni
2 siblings, 0 replies; 4+ messages in thread
From: Paulo Zanoni @ 2018-06-04 23:49 UTC (permalink / raw)
To: Mahesh Kumar, intel-gfx; +Cc: rodrigo.vivi
Em Qui, 2018-05-17 às 18:56 +0530, Mahesh Kumar escreveu:
> Do not update number of enabled dbuf slices in dev_priv struct until
> we
> actually enable/disable dbuf slice in hw. This is leading to never
> updating dbuf slices and resulting in DBuf slice mismatch warning.
>
> Fixes: aa9664ffe863 ("drm/i915/icl: Enable 2nd DBuf slice only when
> needed")
> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
I'll merge it.
> ---
> drivers/gpu/drm/i915/intel_pm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c
> b/drivers/gpu/drm/i915/intel_pm.c
> index b85229e153c4..53aaaa3e6886 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5150,7 +5150,6 @@ skl_copy_ddb_for_pipe(struct skl_ddb_values
> *dst,
> sizeof(dst->ddb.uv_plane[pipe]));
> memcpy(dst->ddb.plane[pipe], src->ddb.plane[pipe],
> sizeof(dst->ddb.plane[pipe]));
> - dst->ddb.enabled_slices = src->ddb.enabled_slices;
> }
>
> static void
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-04 23:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-17 13:26 [PATCH] drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw Mahesh Kumar
2018-05-17 14:00 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-05-17 17:02 ` ✓ Fi.CI.IGT: " Patchwork
2018-06-04 23:49 ` [PATCH] " Paulo Zanoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.