All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization.
Date: Tue, 23 Aug 2016 18:15:15 +0200	[thread overview]
Message-ID: <1528160.BtdbmuP27T@diego> (raw)
In-Reply-To: <1471101978-1881-1-git-send-email-arvind.yadav.cs@gmail.com>

Hi Arvind,

Am Samstag, 13. August 2016, 20:56:18 schrieb Arvind Yadav:
> -check return of 'of_iomap'.if It's falied to remap then abort.
> 
> -Unmap a region obtained by remap. iounmap frees the mapping when failed
> to allocate the memory.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/clk/rockchip/clk-rockchip.c | 7 ++++++-

I've applied the patch, after rewording both patch subject and message [0].

That driver is deprecated for quite some time, see
Documenation/devicetree/bindings/clock/rockchip.txt - so I'm hoping this is
more of a random find and you're not actually using it?


Thanks
Heiko

[0] https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=023a8280b8355a0aebe094299afec8d8b7b264cd

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization.
Date: Tue, 23 Aug 2016 18:15:15 +0200	[thread overview]
Message-ID: <1528160.BtdbmuP27T@diego> (raw)
In-Reply-To: <1471101978-1881-1-git-send-email-arvind.yadav.cs@gmail.com>

Hi Arvind,

Am Samstag, 13. August 2016, 20:56:18 schrieb Arvind Yadav:
> -check return of 'of_iomap'.if It's falied to remap then abort.
> 
> -Unmap a region obtained by remap. iounmap frees the mapping when failed
> to allocate the memory.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/clk/rockchip/clk-rockchip.c | 7 ++++++-

I've applied the patch, after rewording both patch subject and message [0].

That driver is deprecated for quite some time, see
Documenation/devicetree/bindings/clock/rockchip.txt - so I'm hoping this is
more of a random find and you're not actually using it?


Thanks
Heiko

[0] https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=023a8280b8355a0aebe094299afec8d8b7b264cd

  reply	other threads:[~2016-08-23 16:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-13 15:26 [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization Arvind Yadav
2016-08-23 16:15 ` Heiko Stübner [this message]
2016-08-23 16:15   ` Heiko Stübner
2016-08-24 14:22   ` arvind Yadav
2016-08-24 14:22     ` arvind Yadav
2016-08-24 14:22     ` arvind Yadav
2016-08-24 14:56     ` Heiko Stübner
2016-08-24 14:56       ` Heiko Stübner
2016-08-24 14:56       ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1528160.BtdbmuP27T@diego \
    --to=heiko@sntech.de \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.