All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Elaine Zhang <zhangqing@rock-chips.com>
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, xxx@rock-chips.com,
	xf@rock-chips.com, huangtao@rock-chips.com, cl@rock-chips.com
Subject: Re: [PATCH v3 2/2] dt-bindings: add documentation for rk3126 clock
Date: Mon, 31 Jul 2017 13:24:27 +0200	[thread overview]
Message-ID: <1528313.SDTh7a5k6t@diego> (raw)
In-Reply-To: <1501497728-7805-3-git-send-email-zhangqing@rock-chips.com>

Hi Elaine,

Am Montag, 31. Juli 2017, 18:42:08 CEST schrieb Elaine Zhang:
> This add bindings documentation for rk3126 SoCs.
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>

thanks for noticing that the binding doc was missing, I meant to
write a response about that but didn't find the time yet.

> ---
>  Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt
> b/Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt index
> 455a9a00a623..25098fa8595f 100644
> --- a/Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt
> +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt
> @@ -1,12 +1,12 @@
> -* Rockchip RK3128 Clock and Reset Unit
> +* Rockchip RK3128/RK3126 Clock and Reset Unit
> 
> -The RK3128 clock controller generates and supplies clock to various
> +The RK3128/RK3126 clock controller generates and supplies clock to various
>  controllers within the SoC and also implements a reset controller for SoC
>  peripherals.
> 
>  Required Properties:
> 
> -- compatible: should be "rockchip,rk3128-cru"
> +- compatible: should be "rockchip,rk3128-cru", "rockchip,rk3126-cru"

- compatible: should be one of "rockchip,rk3128-cru" or "rockchip,rk3126-cru".


Heiko


>  - reg: physical base address of the controller and length of memory mapped
>    region.
>  - #clock-cells: should be 1.

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] dt-bindings: add documentation for rk3126 clock
Date: Mon, 31 Jul 2017 13:24:27 +0200	[thread overview]
Message-ID: <1528313.SDTh7a5k6t@diego> (raw)
In-Reply-To: <1501497728-7805-3-git-send-email-zhangqing@rock-chips.com>

Hi Elaine,

Am Montag, 31. Juli 2017, 18:42:08 CEST schrieb Elaine Zhang:
> This add bindings documentation for rk3126 SoCs.
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>

thanks for noticing that the binding doc was missing, I meant to
write a response about that but didn't find the time yet.

> ---
>  Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt
> b/Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt index
> 455a9a00a623..25098fa8595f 100644
> --- a/Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt
> +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3128-cru.txt
> @@ -1,12 +1,12 @@
> -* Rockchip RK3128 Clock and Reset Unit
> +* Rockchip RK3128/RK3126 Clock and Reset Unit
> 
> -The RK3128 clock controller generates and supplies clock to various
> +The RK3128/RK3126 clock controller generates and supplies clock to various
>  controllers within the SoC and also implements a reset controller for SoC
>  peripherals.
> 
>  Required Properties:
> 
> -- compatible: should be "rockchip,rk3128-cru"
> +- compatible: should be "rockchip,rk3128-cru", "rockchip,rk3126-cru"

- compatible: should be one of "rockchip,rk3128-cru" or "rockchip,rk3126-cru".


Heiko


>  - reg: physical base address of the controller and length of memory mapped
>    region.
>  - #clock-cells: should be 1.

  reply	other threads:[~2017-07-31 11:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31 10:42 [PATCH v3 0/2] clk: rockchip: support clk drivers for RK3126 SoC Elaine Zhang
2017-07-31 10:42 ` Elaine Zhang
2017-07-31 10:42 ` [PATCH v3 1/2] clk: rockchip: rk3128: modify rk3128 clk driver to support rk3126 Elaine Zhang
2017-07-31 10:42   ` Elaine Zhang
2017-07-31 10:42 ` [PATCH v3 2/2] dt-bindings: add documentation for rk3126 clock Elaine Zhang
2017-07-31 10:42   ` Elaine Zhang
2017-07-31 11:24   ` Heiko Stübner [this message]
2017-07-31 11:24     ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1528313.SDTh7a5k6t@diego \
    --to=heiko@sntech.de \
    --cc=cl@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=huangtao@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=xf@rock-chips.com \
    --cc=xxx@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.