From: Johannes Berg <johannes@sipsolutions.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v3] bitfield: fix *_encode_bits()
Date: Mon, 18 Jun 2018 22:42:29 +0200 [thread overview]
Message-ID: <1529354549.3092.36.camel@sipsolutions.net> (raw)
In-Reply-To: <CAHp75VesXgrh-XR-3bFMOF6eE0K=NyRvyY1tw1yOX44rJS9fag@mail.gmail.com> (sfid-20180618_224029_738852_AF216451)
On Mon, 2018-06-18 at 23:40 +0300, Andy Shevchenko wrote:
> The idea is to print what was the input, expected output and actual result.
> Then you would see what exactly is broken.
Yeah, I guess we could. I did some of that work.
> I dunno how much we may take away from this certain test case, though
> it would be better for my opinion.
TBH though, I'm not sure I want to do this (right now at least). I don't
think we gain anything from it, it's so basic ... so to me it's just
pointless extra code.
johannes
next prev parent reply other threads:[~2018-06-18 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 19:56 [PATCH v3] bitfield: fix *_encode_bits() Johannes Berg
2018-06-18 20:21 ` Andy Shevchenko
2018-06-18 20:28 ` Johannes Berg
2018-06-18 20:33 ` Jakub Kicinski
2018-06-18 20:40 ` Andy Shevchenko
2018-06-18 20:42 ` Johannes Berg [this message]
2018-06-18 20:46 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529354549.3092.36.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.