From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v3] bitfield: fix *_encode_bits()
Date: Mon, 18 Jun 2018 13:33:30 -0700 [thread overview]
Message-ID: <20180618133330.707f3efd@cakuba.netronome.com> (raw)
In-Reply-To: <1529353683.3092.32.camel@sipsolutions.net>
On Mon, 18 Jun 2018 22:28:03 +0200, Johannes Berg wrote:
> > For me looks like for consistency we may add fake conversion macros
> > for this, such as
> >
> > #define cpu_to_le8(x) x
> > #define le8_to_cpu(x) x
> > ...
> > #undef le8_to_cpu
> > #undef cpu_to_le8
> >
> > And do in the same way like below
> >
> > __MAKE_OP(8)
>
> I disagree with this. I don't see why we should have le8_encode_bits()
> and be8_encode_bits() and friends, that makes no sense.
+1
next prev parent reply other threads:[~2018-06-18 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 19:56 [PATCH v3] bitfield: fix *_encode_bits() Johannes Berg
2018-06-18 20:21 ` Andy Shevchenko
2018-06-18 20:28 ` Johannes Berg
2018-06-18 20:33 ` Jakub Kicinski [this message]
2018-06-18 20:40 ` Andy Shevchenko
2018-06-18 20:42 ` Johannes Berg
2018-06-18 20:46 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618133330.707f3efd@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=andy.shevchenko@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.