* [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Enable test for ARGB888/ABGR8888
@ 2018-06-21 13:32 Vandita Kulkarni
2018-06-21 14:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Vandita Kulkarni @ 2018-06-21 13:32 UTC (permalink / raw)
To: igt-dev; +Cc: maarten.lankhorst
icl onwards hw supports bypass for 0xff and 0x00 per-pixel alpha,
fixing the crc mismatch problem.
Hence enabling this test for ARGB8888/ABGR8888 format planes.
Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
---
tests/kms_available_modes_crc.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/tests/kms_available_modes_crc.c b/tests/kms_available_modes_crc.c
index b70ef5d..2c6f707 100644
--- a/tests/kms_available_modes_crc.c
+++ b/tests/kms_available_modes_crc.c
@@ -143,7 +143,7 @@ static const struct {
* and getting crc is skipped.
*/
{ DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff},
- { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff},
+ { DRM_FORMAT_ABGR8888, 0, SKIP4, 0xffffffff},
{ DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff},
{ DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff},
@@ -223,21 +223,21 @@ static bool fill_in_fb(data_t *data, igt_output_t *output, igt_plane_t *plane,
writesize = data->size+data->size/2;
break;
case SKIP4:
- if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 &&
- plane->type == DRM_PLANE_TYPE_CURSOR) {
+ ptemp_32_buf = (unsigned int *)data->buf;
+ for (c = 0; c < data->size/4; c++)
+ ptemp_32_buf[c] = fillers[i].value;
+ writesize = data->size;
/*
- * special for cursor plane where blending works correctly.
+ * HW WA to fix per-pixel alpha 0x00 and 0xff
+ * on non cursor planes is icl onwards only.
*/
- ptemp_32_buf = (unsigned int*)data->buf;
- for (c = 0; c < data->size/4; c++)
- ptemp_32_buf[c] = fillers[i].value;
- writesize = data->size;
- break;
+ if ((intel_gen(intel_get_drm_devid(data->gfx_fd)) < 11) &&
+ plane->type != DRM_PLANE_TYPE_CURSOR) {
+ igt_info("Format %s CRC comparison skipped by design.\n",
+ (char *)&fillers[i].fourcc);
+ return false;
}
- igt_info("Format %s CRC comparison skipped by design.\n",
- (char*)&fillers[i].fourcc);
-
- return false;
+ break;
default:
igt_info("Unsupported mode for test %s\n",
(char*)&fillers[i].fourcc);
--
1.9.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_available_modes_crc: Enable test for ARGB888/ABGR8888 2018-06-21 13:32 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Enable test for ARGB888/ABGR8888 Vandita Kulkarni @ 2018-06-21 14:22 ` Patchwork 2018-06-21 18:24 ` [igt-dev] [PATCH i-g-t] " Lankhorst, Maarten 2018-06-21 19:27 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2018-06-21 14:22 UTC (permalink / raw) To: Vandita Kulkarni; +Cc: igt-dev == Series Details == Series: tests/kms_available_modes_crc: Enable test for ARGB888/ABGR8888 URL : https://patchwork.freedesktop.org/series/45174/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4359 -> IGTPW_1495 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/45174/revisions/1/mbox/ == Known issues == Here are the changes found in IGTPW_1495 that come from known issues: === IGT changes === ==== Issues hit ==== igt@gem_exec_gttfill@basic: fi-byt-n2820: PASS -> FAIL (fdo#106744) igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: fi-snb-2520m: PASS -> INCOMPLETE (fdo#103713) igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c: fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927) ==== Possible fixes ==== igt@gem_ctx_create@basic-files: fi-skl-gvtdvm: INCOMPLETE (fdo#105600, fdo#106988) -> PASS fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713 fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927 fdo#105600 https://bugs.freedesktop.org/show_bug.cgi?id=105600 fdo#106744 https://bugs.freedesktop.org/show_bug.cgi?id=106744 fdo#106988 https://bugs.freedesktop.org/show_bug.cgi?id=106988 == Participating hosts (42 -> 37) == Missing (5): fi-byt-squawks fi-kbl-x1275 fi-ilk-m540 fi-glk-dsi fi-hsw-4200u == Build changes == * IGT: IGT_4527 -> IGTPW_1495 CI_DRM_4359: fe0300c16bff0f9c82050e56cdbc3880f87e39bd @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_1495: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1495/ IGT_4527: 04afec3ccfcb35e994f2e78254ff499f6b94f097 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1495/issues.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Enable test for ARGB888/ABGR8888 2018-06-21 13:32 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Enable test for ARGB888/ABGR8888 Vandita Kulkarni 2018-06-21 14:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2018-06-21 18:24 ` Lankhorst, Maarten 2018-06-22 7:46 ` Kulkarni, Vandita 2018-06-21 19:27 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork 2 siblings, 1 reply; 5+ messages in thread From: Lankhorst, Maarten @ 2018-06-21 18:24 UTC (permalink / raw) To: igt-dev@lists.freedesktop.org, Kulkarni, Vandita [-- Attachment #1.1: Type: text/plain, Size: 2412 bytes --] Hey, tor 2018-06-21 klockan 19:02 +0530 skrev Vandita Kulkarni: > icl onwards hw supports bypass for 0xff and 0x00 per-pixel alpha, > fixing the crc mismatch problem. > Hence enabling this test for ARGB8888/ABGR8888 format planes. > > Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com> > --- > tests/kms_available_modes_crc.c | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/tests/kms_available_modes_crc.c > b/tests/kms_available_modes_crc.c > index b70ef5d..2c6f707 100644 > --- a/tests/kms_available_modes_crc.c > +++ b/tests/kms_available_modes_crc.c > @@ -143,7 +143,7 @@ static const struct { > * and getting crc is skipped. > */ > { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff}, > - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff}, > + { DRM_FORMAT_ABGR8888, 0, SKIP4, 0xffffffff}, > > { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff}, > { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff}, > @@ -223,21 +223,21 @@ static bool fill_in_fb(data_t *data, > igt_output_t *output, igt_plane_t *plane, > writesize = data->size+data->size/2; > break; > case SKIP4: > - if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 && > - plane->type == DRM_PLANE_TYPE_CURSOR) { > + ptemp_32_buf = (unsigned int *)data->buf; > + for (c = 0; c < data->size/4; c++) > + ptemp_32_buf[c] = fillers[i].value; > + writesize = data->size; > /* > - * special for cursor plane where blending works > correctly. > + * HW WA to fix per-pixel alpha 0x00 and 0xff > + * on non cursor planes is icl onwards only. > */ > - ptemp_32_buf = (unsigned int*)data->buf; > - for (c = 0; c < data->size/4; c++) > - ptemp_32_buf[c] = fillers[i].value; > - writesize = data->size; > - break; > + if ((intel_gen(intel_get_drm_devid(data->gfx_fd)) < > 11) && > + plane->type != DRM_PLANE_TYPE_CURSOR) { > + igt_info("Format %s CRC comparison skipped > by design.\n", > + (char *)&fillers[i].fourcc); > + return false; > } > - igt_info("Format %s CRC comparison skipped by > design.\n", > - (char*)&fillers[i].fourcc); > - > - return false; > + break; > default: > igt_info("Unsupported mode for test %s\n", > (char*)&fillers[i].fourcc); Could we only blacklist gen9 and gen10? Earlier platforms should handle alpha correctly. ~Maarten [-- Attachment #1.2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 3282 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Enable test for ARGB888/ABGR8888 2018-06-21 18:24 ` [igt-dev] [PATCH i-g-t] " Lankhorst, Maarten @ 2018-06-22 7:46 ` Kulkarni, Vandita 0 siblings, 0 replies; 5+ messages in thread From: Kulkarni, Vandita @ 2018-06-22 7:46 UTC (permalink / raw) To: Lankhorst, Maarten, igt-dev@lists.freedesktop.org > -----Original Message----- > From: Lankhorst, Maarten > Sent: Thursday, June 21, 2018 11:54 PM > To: igt-dev@lists.freedesktop.org; Kulkarni, Vandita > <vandita.kulkarni@intel.com> > Subject: Re: [PATCH i-g-t] tests/kms_available_modes_crc: Enable test for > ARGB888/ABGR8888 > > Hey, > > tor 2018-06-21 klockan 19:02 +0530 skrev Vandita Kulkarni: > > icl onwards hw supports bypass for 0xff and 0x00 per-pixel alpha, > > fixing the crc mismatch problem. > > Hence enabling this test for ARGB8888/ABGR8888 format planes. > > > > Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com> > > --- > > tests/kms_available_modes_crc.c | 26 +++++++++++++------------- > > 1 file changed, 13 insertions(+), 13 deletions(-) > > > > diff --git a/tests/kms_available_modes_crc.c > > b/tests/kms_available_modes_crc.c > > index b70ef5d..2c6f707 100644 > > --- a/tests/kms_available_modes_crc.c > > +++ b/tests/kms_available_modes_crc.c > > @@ -143,7 +143,7 @@ static const struct { > > * and getting crc is skipped. > > */ > > { DRM_FORMAT_ARGB8888, 0, SKIP4, 0xffffffff}, > > - { DRM_FORMAT_ABGR8888, 0, SKIP4, 0x00ffffff}, > > + { DRM_FORMAT_ABGR8888, 0, SKIP4, 0xffffffff}, > > > > { DRM_FORMAT_XRGB2101010, 0, BYTES_PP_4, 0xffffffff}, > > { DRM_FORMAT_XBGR2101010, 0, BYTES_PP_4, 0xffffffff}, > > @@ -223,21 +223,21 @@ static bool fill_in_fb(data_t *data, > > igt_output_t *output, igt_plane_t *plane, > > writesize = data->size+data->size/2; > > break; > > case SKIP4: > > - if (fillers[i].fourcc == DRM_FORMAT_ARGB8888 && > > - plane->type == DRM_PLANE_TYPE_CURSOR) { > > + ptemp_32_buf = (unsigned int *)data->buf; > > + for (c = 0; c < data->size/4; c++) > > + ptemp_32_buf[c] = fillers[i].value; > > + writesize = data->size; > > /* > > - * special for cursor plane where blending works > > correctly. > > + * HW WA to fix per-pixel alpha 0x00 and 0xff > > + * on non cursor planes is icl onwards only. > > */ > > - ptemp_32_buf = (unsigned int*)data->buf; > > - for (c = 0; c < data->size/4; c++) > > - ptemp_32_buf[c] = fillers[i].value; > > - writesize = data->size; > > - break; > > + if ((intel_gen(intel_get_drm_devid(data->gfx_fd)) < > > 11) && > > + plane->type != DRM_PLANE_TYPE_CURSOR) { > > + igt_info("Format %s CRC comparison skipped > > by design.\n", > > + (char *)&fillers[i].fourcc); > > + return false; > > } > > - igt_info("Format %s CRC comparison skipped by > > design.\n", > > - (char*)&fillers[i].fourcc); > > - > > - return false; > > + break; > > default: > > igt_info("Unsupported mode for test %s\n", > > (char*)&fillers[i].fourcc); > Could we only blacklist gen9 and gen10? Earlier platforms should handle > alpha correctly. > Sure, will submit the next version with this change. Thanks Vandita > ~Maarten _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_available_modes_crc: Enable test for ARGB888/ABGR8888 2018-06-21 13:32 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Enable test for ARGB888/ABGR8888 Vandita Kulkarni 2018-06-21 14:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2018-06-21 18:24 ` [igt-dev] [PATCH i-g-t] " Lankhorst, Maarten @ 2018-06-21 19:27 ` Patchwork 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2018-06-21 19:27 UTC (permalink / raw) To: Vandita Kulkarni; +Cc: igt-dev == Series Details == Series: tests/kms_available_modes_crc: Enable test for ARGB888/ABGR8888 URL : https://patchwork.freedesktop.org/series/45174/ State : success == Summary == = CI Bug Log - changes from IGT_4527_full -> IGTPW_1495_full = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/45174/revisions/1/mbox/ == Known issues == Here are the changes found in IGTPW_1495_full that come from known issues: === IGT changes === ==== Issues hit ==== igt@drv_selftest@live_hangcheck: shard-glk: PASS -> DMESG-FAIL (fdo#106560, fdo#106947) igt@drv_suspend@shrink: shard-glk: PASS -> FAIL (fdo#106886) igt@gem_ctx_isolation@rcs0-s3: shard-kbl: PASS -> INCOMPLETE (fdo#103665) igt@kms_available_modes_crc@available_mode_test_crc: shard-snb: PASS -> FAIL (fdo#106641) igt@kms_flip@dpms-vs-vblank-race-interruptible: shard-glk: PASS -> FAIL (fdo#103060) igt@kms_flip_tiling@flip-x-tiled: shard-glk: PASS -> FAIL (fdo#104724, fdo#103822) igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: shard-glk: PASS -> FAIL (fdo#103375) igt@kms_plane_multiple@atomic-pipe-a-tiling-x: shard-snb: PASS -> FAIL (fdo#104724, fdo#103166) igt@kms_rotation_crc@sprite-rotation-180: shard-snb: PASS -> FAIL (fdo#103925, fdo#104724) igt@kms_setmode@basic: shard-kbl: PASS -> FAIL (fdo#99912) ==== Possible fixes ==== igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic: shard-glk: FAIL (fdo#106509, fdo#105454) -> PASS igt@kms_flip@2x-plain-flip-ts-check-interruptible: shard-glk: FAIL (fdo#100368) -> PASS igt@kms_flip@flip-vs-expired-vblank: shard-glk: FAIL (fdo#102887, fdo#105363) -> PASS igt@kms_flip_tiling@flip-to-y-tiled: shard-glk: FAIL (fdo#104724, fdo#103822) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887 fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060 fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166 fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375 fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665 fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822 fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925 fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724 fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363 fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454 fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509 fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560 fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641 fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886 fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * IGT: IGT_4527 -> IGTPW_1495 * Linux: CI_DRM_4348 -> CI_DRM_4359 CI_DRM_4348: 3a2fbf8fe32d909c5d44e61e7d212ae694e9e473 @ git://anongit.freedesktop.org/gfx-ci/linux CI_DRM_4359: fe0300c16bff0f9c82050e56cdbc3880f87e39bd @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_1495: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1495/ IGT_4527: 04afec3ccfcb35e994f2e78254ff499f6b94f097 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1495/shards.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-22 7:46 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-06-21 13:32 [igt-dev] [PATCH i-g-t] tests/kms_available_modes_crc: Enable test for ARGB888/ABGR8888 Vandita Kulkarni 2018-06-21 14:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2018-06-21 18:24 ` [igt-dev] [PATCH i-g-t] " Lankhorst, Maarten 2018-06-22 7:46 ` Kulkarni, Vandita 2018-06-21 19:27 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.