All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume
@ 2018-06-22 17:05 Anusha Srivatsa
  2018-06-22 17:25 ` Daniele Ceraolo Spurio
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Anusha Srivatsa @ 2018-06-22 17:05 UTC (permalink / raw)
  To: intel-gfx

In the guc_ctl_debug_flags, the ads struct is programmed only
when USES_GUC_SUBMISSION is satisfied. But, this has to be
programmed for all suspend/resume cases.
Remove the condition and program the ads struct for
both huc loading and guc submission.

This issue was noticed when CI threw errors for enable_guc=2
(load huc; disable submission)

Credits to: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: John Spotswood <john.a.spotswood@intel.com>
Cc: Oscar Mateo <oscar.mateo@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/intel_guc.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
index 1aff30b..b1d1a10 100644
--- a/drivers/gpu/drm/i915/intel_guc.c
+++ b/drivers/gpu/drm/i915/intel_guc.c
@@ -207,6 +207,7 @@ static u32 guc_ctl_debug_flags(struct intel_guc *guc)
 {
 	u32 level = intel_guc_log_get_level(&guc->log);
 	u32 flags = 0;
+	u32 ads = 0;
 
 	if (!GUC_LOG_LEVEL_IS_ENABLED(level))
 		flags |= GUC_LOG_DEFAULT_DISABLED;
@@ -217,12 +218,10 @@ static u32 guc_ctl_debug_flags(struct intel_guc *guc)
 		flags |= GUC_LOG_LEVEL_TO_VERBOSITY(level) <<
 			 GUC_LOG_VERBOSITY_SHIFT;
 
-	if (USES_GUC_SUBMISSION(guc_to_i915(guc))) {
-		u32 ads = intel_guc_ggtt_offset(guc, guc->ads_vma)
-			>> PAGE_SHIFT;
+	ads = intel_guc_ggtt_offset(guc, guc->ads_vma) <<
+			PAGE_SHIFT;
 
-		flags |= ads << GUC_ADS_ADDR_SHIFT | GUC_ADS_ENABLED;
-	}
+	flags |= ads << GUC_ADS_ADDR_SHIFT | GUC_ADS_ENABLED;
 
 	return flags;
 }
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume
  2018-06-22 17:05 [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume Anusha Srivatsa
@ 2018-06-22 17:25 ` Daniele Ceraolo Spurio
  2018-06-22 17:34   ` John Spotswood
  2018-06-22 17:38   ` Srivatsa, Anusha
  2018-06-22 17:39 ` ✓ Fi.CI.BAT: success for " Patchwork
  2018-06-22 19:33 ` ✓ Fi.CI.IGT: " Patchwork
  2 siblings, 2 replies; 7+ messages in thread
From: Daniele Ceraolo Spurio @ 2018-06-22 17:25 UTC (permalink / raw)
  To: Anusha Srivatsa, intel-gfx

Commit title is slightly misleading, as the USES_GUC_SUBMISSION is not 
removed from a suspend/resume path. the firmware tag is also confusing 
since this fixes an i915 bug. Maybe something like "drm/i915/guc: Remove 
USES_GUC_SUBMISSION for ads programming" would be clearer

On 22/06/18 10:05, Anusha Srivatsa wrote:
> In the guc_ctl_debug_flags, the ads struct is programmed only
> when USES_GUC_SUBMISSION is satisfied. But, this has to be
> programmed for all suspend/resume cases.
> Remove the condition and program the ads struct for
> both huc loading and guc submission.
> 
> This issue was noticed when CI threw errors for enable_guc=2
> (load huc; disable submission)
> 

Do we need a fixes: tag? Not sure we want this backported since GuC is 
off by default.

> Credits to: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: John Spotswood <john.a.spotswood@intel.com>
> Cc: Oscar Mateo <oscar.mateo@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_guc.c | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
> index 1aff30b..b1d1a10 100644
> --- a/drivers/gpu/drm/i915/intel_guc.c
> +++ b/drivers/gpu/drm/i915/intel_guc.c
> @@ -207,6 +207,7 @@ static u32 guc_ctl_debug_flags(struct intel_guc *guc)
>   {
>   	u32 level = intel_guc_log_get_level(&guc->log);
>   	u32 flags = 0;
> +	u32 ads = 0;
>   
>   	if (!GUC_LOG_LEVEL_IS_ENABLED(level))
>   		flags |= GUC_LOG_DEFAULT_DISABLED;
> @@ -217,12 +218,10 @@ static u32 guc_ctl_debug_flags(struct intel_guc *guc)
>   		flags |= GUC_LOG_LEVEL_TO_VERBOSITY(level) <<
>   			 GUC_LOG_VERBOSITY_SHIFT;
>   
> -	if (USES_GUC_SUBMISSION(guc_to_i915(guc))) {
> -		u32 ads = intel_guc_ggtt_offset(guc, guc->ads_vma)
> -			>> PAGE_SHIFT;
> +	ads = intel_guc_ggtt_offset(guc, guc->ads_vma) <<

You've flipped the shift here. With that fixed:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

> +			PAGE_SHIFT;
>   
> -		flags |= ads << GUC_ADS_ADDR_SHIFT | GUC_ADS_ENABLED;
> -	}
> +	flags |= ads << GUC_ADS_ADDR_SHIFT | GUC_ADS_ENABLED;
>   
>   	return flags;
>   }
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume
  2018-06-22 17:25 ` Daniele Ceraolo Spurio
@ 2018-06-22 17:34   ` John Spotswood
  2018-06-22 17:38   ` Srivatsa, Anusha
  1 sibling, 0 replies; 7+ messages in thread
From: John Spotswood @ 2018-06-22 17:34 UTC (permalink / raw)
  To: Daniele Ceraolo Spurio, Anusha Srivatsa, intel-gfx

On Fri, 2018-06-22 at 10:25 -0700, Daniele Ceraolo Spurio wrote:
> Commit title is slightly misleading, as the USES_GUC_SUBMISSION is
> not 
> removed from a suspend/resume path. the firmware tag is also
> confusing 
> since this fixes an i915 bug. Maybe something like "drm/i915/guc:
> Remove 
> USES_GUC_SUBMISSION for ads programming" would be clearer
> 
> On 22/06/18 10:05, Anusha Srivatsa wrote:
> > 
> > In the guc_ctl_debug_flags, the ads struct is programmed only
> > when USES_GUC_SUBMISSION is satisfied. But, this has to be
> > programmed for all suspend/resume cases.
> > Remove the condition and program the ads struct for
> > both huc loading and guc submission.
> > 
> > This issue was noticed when CI threw errors for enable_guc=2
> > (load huc; disable submission)
> > 
> Do we need a fixes: tag? Not sure we want this backported since GuC
> is 
> off by default.
> 
> > 
> > Credits to: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com
> > >
> > Cc: John Spotswood <john.a.spotswood@intel.com>
> > Cc: Oscar Mateo <oscar.mateo@intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > ---
> >   drivers/gpu/drm/i915/intel_guc.c | 9 ++++-----
> >   1 file changed, 4 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_guc.c
> > b/drivers/gpu/drm/i915/intel_guc.c
> > index 1aff30b..b1d1a10 100644
> > --- a/drivers/gpu/drm/i915/intel_guc.c
> > +++ b/drivers/gpu/drm/i915/intel_guc.c
> > @@ -207,6 +207,7 @@ static u32 guc_ctl_debug_flags(struct intel_guc
> > *guc)
> >   {
> >   	u32 level = intel_guc_log_get_level(&guc->log);
> >   	u32 flags = 0;
> > +	u32 ads = 0;
> >   
> >   	if (!GUC_LOG_LEVEL_IS_ENABLED(level))
> >   		flags |= GUC_LOG_DEFAULT_DISABLED;
> > @@ -217,12 +218,10 @@ static u32 guc_ctl_debug_flags(struct
> > intel_guc *guc)
> >   		flags |= GUC_LOG_LEVEL_TO_VERBOSITY(level) <<
> >   			 GUC_LOG_VERBOSITY_SHIFT;
> >   
> > -	if (USES_GUC_SUBMISSION(guc_to_i915(guc))) {
> > -		u32 ads = intel_guc_ggtt_offset(guc, guc->ads_vma)
> > -			>> PAGE_SHIFT;
> > +	ads = intel_guc_ggtt_offset(guc, guc->ads_vma) <<
> You've flipped the shift here. With that fixed:
> 
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> 

With Daniele's recommended changes:

Reviewed-by:  John Spotswood <john.a.spotswood@intel.com>

> > 
> > +			PAGE_SHIFT;
> >   
> > -		flags |= ads << GUC_ADS_ADDR_SHIFT |
> > GUC_ADS_ENABLED;
> > -	}
> > +	flags |= ads << GUC_ADS_ADDR_SHIFT | GUC_ADS_ENABLED;
> >   
> >   	return flags;
> >   }
> > 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume
  2018-06-22 17:25 ` Daniele Ceraolo Spurio
  2018-06-22 17:34   ` John Spotswood
@ 2018-06-22 17:38   ` Srivatsa, Anusha
  2018-06-22 17:44     ` Daniele Ceraolo Spurio
  1 sibling, 1 reply; 7+ messages in thread
From: Srivatsa, Anusha @ 2018-06-22 17:38 UTC (permalink / raw)
  To: Ceraolo Spurio, Daniele, intel-gfx@lists.freedesktop.org



>-----Original Message-----
>From: Ceraolo Spurio, Daniele
>Sent: Friday, June 22, 2018 10:26 AM
>To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
>gfx@lists.freedesktop.org
>Cc: Spotswood, John A <john.a.spotswood@intel.com>; Mateo Lozano, Oscar
><oscar.mateo@intel.com>
>Subject: Re: [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for
>suspend/resume
>
>Commit title is slightly misleading, as the USES_GUC_SUBMISSION is not removed
>from a suspend/resume path. the firmware tag is also confusing since this fixes
>an i915 bug. Maybe something like "drm/i915/guc: Remove
>USES_GUC_SUBMISSION for ads programming" would be clearer
Sure.
Makes sense.

>On 22/06/18 10:05, Anusha Srivatsa wrote:
>> In the guc_ctl_debug_flags, the ads struct is programmed only when
>> USES_GUC_SUBMISSION is satisfied. But, this has to be programmed for
>> all suspend/resume cases.
>> Remove the condition and program the ads struct for both huc loading
>> and guc submission.
>>
>> This issue was noticed when CI threw errors for enable_guc=2 (load
>> huc; disable submission)
>>
>
>Do we need a fixes: tag? Not sure we want this backported since GuC is off by
>default.

Hmm...so the patch - Load Guc,HuC on GLK is still not merged. 
Maybe skip the fixes tag? 


>> Credits to: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: John Spotswood <john.a.spotswood@intel.com>
>> Cc: Oscar Mateo <oscar.mateo@intel.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> ---
>>   drivers/gpu/drm/i915/intel_guc.c | 9 ++++-----
>>   1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_guc.c
>> b/drivers/gpu/drm/i915/intel_guc.c
>> index 1aff30b..b1d1a10 100644
>> --- a/drivers/gpu/drm/i915/intel_guc.c
>> +++ b/drivers/gpu/drm/i915/intel_guc.c
>> @@ -207,6 +207,7 @@ static u32 guc_ctl_debug_flags(struct intel_guc *guc)
>>   {
>>   	u32 level = intel_guc_log_get_level(&guc->log);
>>   	u32 flags = 0;
>> +	u32 ads = 0;
>>
>>   	if (!GUC_LOG_LEVEL_IS_ENABLED(level))
>>   		flags |= GUC_LOG_DEFAULT_DISABLED; @@ -217,12 +218,10
>@@ static
>> u32 guc_ctl_debug_flags(struct intel_guc *guc)
>>   		flags |= GUC_LOG_LEVEL_TO_VERBOSITY(level) <<
>>   			 GUC_LOG_VERBOSITY_SHIFT;
>>
>> -	if (USES_GUC_SUBMISSION(guc_to_i915(guc))) {
>> -		u32 ads = intel_guc_ggtt_offset(guc, guc->ads_vma)
>> -			>> PAGE_SHIFT;
>> +	ads = intel_guc_ggtt_offset(guc, guc->ads_vma) <<
>
>You've flipped the shift here. With that fixed:
Oops...thanks for pointing it out.

>Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

And thanks for the review. Will re-spin the patch asap.

Anusha 
>> +			PAGE_SHIFT;
>>
>> -		flags |= ads << GUC_ADS_ADDR_SHIFT | GUC_ADS_ENABLED;
>> -	}
>> +	flags |= ads << GUC_ADS_ADDR_SHIFT | GUC_ADS_ENABLED;
>>
>>   	return flags;
>>   }
>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* ✓ Fi.CI.BAT: success for firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume
  2018-06-22 17:05 [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume Anusha Srivatsa
  2018-06-22 17:25 ` Daniele Ceraolo Spurio
@ 2018-06-22 17:39 ` Patchwork
  2018-06-22 19:33 ` ✓ Fi.CI.IGT: " Patchwork
  2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-06-22 17:39 UTC (permalink / raw)
  To: Srivatsa, Anusha; +Cc: intel-gfx

== Series Details ==

Series: firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume
URL   : https://patchwork.freedesktop.org/series/45270/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4369 -> Patchwork_9403 =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_9403 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9403, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/45270/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9403:

  === IGT changes ===

    ==== Warnings ====

    igt@kms_addfb_basic@addfb25-modifier-no-flag:
      fi-cfl-guc:         PASS -> SKIP +243

    igt@prime_self_import@basic-llseek-bad:
      fi-skl-guc:         PASS -> SKIP +243

    igt@prime_vgem@basic-read:
      fi-kbl-guc:         PASS -> SKIP +206

    
== Known issues ==

  Here are the changes found in Patchwork_9403 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload:
      fi-skl-guc:         PASS -> DMESG-FAIL (fdo#106685) +2
      fi-kbl-guc:         PASS -> DMESG-FAIL (fdo#106685) +2
      fi-cfl-guc:         PASS -> DMESG-FAIL (fdo#106685) +2

    
  fdo#106685 https://bugs.freedesktop.org/show_bug.cgi?id=106685


== Participating hosts (41 -> 34) ==

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-glk-dsi fi-bsw-cyan fi-ctg-p8600 fi-kbl-x1275 fi-kbl-7560u 


== Build changes ==

    * Linux: CI_DRM_4369 -> Patchwork_9403

  CI_DRM_4369: cf1a331121ec497115239b06a60385c9db797892 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4528: 6be300d405de5974b262e8b93a445be4ac618e6a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9403: b981adfcb28890d299d03e504bc63f1f1215159b @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

b981adfcb288 firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9403/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume
  2018-06-22 17:38   ` Srivatsa, Anusha
@ 2018-06-22 17:44     ` Daniele Ceraolo Spurio
  0 siblings, 0 replies; 7+ messages in thread
From: Daniele Ceraolo Spurio @ 2018-06-22 17:44 UTC (permalink / raw)
  To: Srivatsa, Anusha, intel-gfx@lists.freedesktop.org



On 22/06/18 10:38, Srivatsa, Anusha wrote:
> 
> 
>> -----Original Message-----
>> From: Ceraolo Spurio, Daniele
>> Sent: Friday, June 22, 2018 10:26 AM
>> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
>> gfx@lists.freedesktop.org
>> Cc: Spotswood, John A <john.a.spotswood@intel.com>; Mateo Lozano, Oscar
>> <oscar.mateo@intel.com>
>> Subject: Re: [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for
>> suspend/resume
>>
>> Commit title is slightly misleading, as the USES_GUC_SUBMISSION is not removed
>>from a suspend/resume path. the firmware tag is also confusing since this fixes
>> an i915 bug. Maybe something like "drm/i915/guc: Remove
>> USES_GUC_SUBMISSION for ads programming" would be clearer
> Sure.
> Makes sense.
> 
>> On 22/06/18 10:05, Anusha Srivatsa wrote:
>>> In the guc_ctl_debug_flags, the ads struct is programmed only when
>>> USES_GUC_SUBMISSION is satisfied. But, this has to be programmed for
>>> all suspend/resume cases.
>>> Remove the condition and program the ads struct for both huc loading
>>> and guc submission.
>>>
>>> This issue was noticed when CI threw errors for enable_guc=2 (load
>>> huc; disable submission)
>>>
>>
>> Do we need a fixes: tag? Not sure we want this backported since GuC is off by
>> default.
> 
> Hmm...so the patch - Load Guc,HuC on GLK is still not merged.
> Maybe skip the fixes tag?
> 

This fails on SKL as well and we had FW there for a while. I still think 
we can skip the tag because guc is off by default, but don't take my 
word as assurance :)

Daniele

> 
>>> Credits to: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>>> Cc: John Spotswood <john.a.spotswood@intel.com>
>>> Cc: Oscar Mateo <oscar.mateo@intel.com>
>>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>>> ---
>>>    drivers/gpu/drm/i915/intel_guc.c | 9 ++++-----
>>>    1 file changed, 4 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_guc.c
>>> b/drivers/gpu/drm/i915/intel_guc.c
>>> index 1aff30b..b1d1a10 100644
>>> --- a/drivers/gpu/drm/i915/intel_guc.c
>>> +++ b/drivers/gpu/drm/i915/intel_guc.c
>>> @@ -207,6 +207,7 @@ static u32 guc_ctl_debug_flags(struct intel_guc *guc)
>>>    {
>>>    	u32 level = intel_guc_log_get_level(&guc->log);
>>>    	u32 flags = 0;
>>> +	u32 ads = 0;
>>>
>>>    	if (!GUC_LOG_LEVEL_IS_ENABLED(level))
>>>    		flags |= GUC_LOG_DEFAULT_DISABLED; @@ -217,12 +218,10
>> @@ static
>>> u32 guc_ctl_debug_flags(struct intel_guc *guc)
>>>    		flags |= GUC_LOG_LEVEL_TO_VERBOSITY(level) <<
>>>    			 GUC_LOG_VERBOSITY_SHIFT;
>>>
>>> -	if (USES_GUC_SUBMISSION(guc_to_i915(guc))) {
>>> -		u32 ads = intel_guc_ggtt_offset(guc, guc->ads_vma)
>>> -			>> PAGE_SHIFT;
>>> +	ads = intel_guc_ggtt_offset(guc, guc->ads_vma) <<
>>
>> You've flipped the shift here. With that fixed:
> Oops...thanks for pointing it out.
> 
>> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> 
> And thanks for the review. Will re-spin the patch asap.
> 
> Anusha
>>> +			PAGE_SHIFT;
>>>
>>> -		flags |= ads << GUC_ADS_ADDR_SHIFT | GUC_ADS_ENABLED;
>>> -	}
>>> +	flags |= ads << GUC_ADS_ADDR_SHIFT | GUC_ADS_ENABLED;
>>>
>>>    	return flags;
>>>    }
>>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* ✓ Fi.CI.IGT: success for firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume
  2018-06-22 17:05 [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume Anusha Srivatsa
  2018-06-22 17:25 ` Daniele Ceraolo Spurio
  2018-06-22 17:39 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-06-22 19:33 ` Patchwork
  2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-06-22 19:33 UTC (permalink / raw)
  To: Anusha Srivatsa; +Cc: intel-gfx

== Series Details ==

Series: firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume
URL   : https://patchwork.freedesktop.org/series/45270/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4369_full -> Patchwork_9403_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_9403_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9403_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9403_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_mocs_settings@mocs-rc6-blt:
      shard-kbl:          SKIP -> PASS +1

    igt@kms_cursor_legacy@cursorb-vs-flipb-legacy:
      shard-hsw:          SKIP -> PASS

    igt@perf_pmu@rc6:
      shard-kbl:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in Patchwork_9403_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_workarounds@suspend-resume-context:
      shard-apl:          PASS -> FAIL (fdo#103375) +1

    igt@kms_rotation_crc@primary-rotation-270:
      shard-apl:          PASS -> FAIL (fdo#103925, fdo#104724)

    igt@kms_setmode@basic:
      shard-hsw:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@gem_exec_await@wide-contexts:
      shard-kbl:          FAIL (fdo#105900) -> PASS

    igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          FAIL (fdo#106509, fdo#105454) -> PASS

    igt@kms_flip@plain-flip-fb-recreate-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS +1

    igt@perf@blocking:
      shard-hsw:          FAIL (fdo#102252) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
  fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
  fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
  fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4369 -> Patchwork_9403

  CI_DRM_4369: cf1a331121ec497115239b06a60385c9db797892 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4528: 6be300d405de5974b262e8b93a445be4ac618e6a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9403: b981adfcb28890d299d03e504bc63f1f1215159b @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9403/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-06-22 19:33 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-22 17:05 [PATCH] firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume Anusha Srivatsa
2018-06-22 17:25 ` Daniele Ceraolo Spurio
2018-06-22 17:34   ` John Spotswood
2018-06-22 17:38   ` Srivatsa, Anusha
2018-06-22 17:44     ` Daniele Ceraolo Spurio
2018-06-22 17:39 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-22 19:33 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.