From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-arm@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-arm] [PATCH 2/5] hw/core/sysbus: Add a function for creating and attaching an object
Date: Thu, 12 Jul 2018 17:31:00 +0200 [thread overview]
Message-ID: <1531409463-3843-3-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1531409463-3843-1-git-send-email-thuth@redhat.com>
A lot of functions are initializing an object and attach it immediately
afterwards to the system bus. Provide a common function for this, which
also uses object_initialize_as_child() to make sure that the reference
counter is correctly initialized to 1 afterwards.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/core/sysbus.c | 8 ++++++++
include/hw/sysbus.h | 3 +++
2 files changed, 11 insertions(+)
diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
index ecfb0cf..c164318 100644
--- a/hw/core/sysbus.c
+++ b/hw/core/sysbus.c
@@ -376,6 +376,14 @@ BusState *sysbus_get_default(void)
return main_system_bus;
}
+void sysbus_init_child_obj(Object *parent, const char *childname, void *child,
+ size_t childsize, const char *childtype)
+{
+ object_initialize_as_child(parent, childname, child, childsize, childtype,
+ &error_abort);
+ qdev_set_parent_bus(DEVICE(child), sysbus_get_default());
+}
+
static void sysbus_register_types(void)
{
type_register_static(&system_bus_info);
diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h
index e88bb6d..e405232 100644
--- a/include/hw/sysbus.h
+++ b/include/hw/sysbus.h
@@ -96,6 +96,9 @@ void sysbus_add_io(SysBusDevice *dev, hwaddr addr,
MemoryRegion *mem);
MemoryRegion *sysbus_address_space(SysBusDevice *dev);
+void sysbus_init_child_obj(Object *parent, const char *childname, void *child,
+ size_t childsize, const char *childtype);
+
/* Call func for every dynamically created sysbus device in the system */
void foreach_dynamic_sysbus_device(FindSysbusDeviceFunc *func, void *opaque);
--
1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-arm@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PATCH 2/5] hw/core/sysbus: Add a function for creating and attaching an object
Date: Thu, 12 Jul 2018 17:31:00 +0200 [thread overview]
Message-ID: <1531409463-3843-3-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1531409463-3843-1-git-send-email-thuth@redhat.com>
A lot of functions are initializing an object and attach it immediately
afterwards to the system bus. Provide a common function for this, which
also uses object_initialize_as_child() to make sure that the reference
counter is correctly initialized to 1 afterwards.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/core/sysbus.c | 8 ++++++++
include/hw/sysbus.h | 3 +++
2 files changed, 11 insertions(+)
diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
index ecfb0cf..c164318 100644
--- a/hw/core/sysbus.c
+++ b/hw/core/sysbus.c
@@ -376,6 +376,14 @@ BusState *sysbus_get_default(void)
return main_system_bus;
}
+void sysbus_init_child_obj(Object *parent, const char *childname, void *child,
+ size_t childsize, const char *childtype)
+{
+ object_initialize_as_child(parent, childname, child, childsize, childtype,
+ &error_abort);
+ qdev_set_parent_bus(DEVICE(child), sysbus_get_default());
+}
+
static void sysbus_register_types(void)
{
type_register_static(&system_bus_info);
diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h
index e88bb6d..e405232 100644
--- a/include/hw/sysbus.h
+++ b/include/hw/sysbus.h
@@ -96,6 +96,9 @@ void sysbus_add_io(SysBusDevice *dev, hwaddr addr,
MemoryRegion *mem);
MemoryRegion *sysbus_address_space(SysBusDevice *dev);
+void sysbus_init_child_obj(Object *parent, const char *childname, void *child,
+ size_t childsize, const char *childtype);
+
/* Call func for every dynamically created sysbus device in the system */
void foreach_dynamic_sysbus_device(FindSysbusDeviceFunc *func, void *opaque);
--
1.8.3.1
next prev parent reply other threads:[~2018-07-12 15:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 15:30 [Qemu-arm] [PATCH v1 0/5] Fix crashes with introspection Thomas Huth
2018-07-12 15:30 ` [Qemu-devel] " Thomas Huth
2018-07-12 15:30 ` [Qemu-arm] [PATCH 1/5] qom/object: Add a new function object_initialize_as_child() Thomas Huth
2018-07-12 15:30 ` [Qemu-devel] " Thomas Huth
2018-07-12 16:52 ` [Qemu-arm] " Eduardo Habkost
2018-07-12 16:52 ` [Qemu-devel] " Eduardo Habkost
2018-07-12 16:55 ` [Qemu-arm] " Thomas Huth
2018-07-12 16:55 ` [Qemu-devel] " Thomas Huth
2018-07-12 17:02 ` [Qemu-arm] " Eduardo Habkost
2018-07-12 17:02 ` [Qemu-devel] " Eduardo Habkost
2018-07-12 17:09 ` [Qemu-arm] " Peter Maydell
2018-07-12 17:09 ` [Qemu-devel] " Peter Maydell
2018-07-13 6:27 ` Paolo Bonzini
2018-07-13 6:27 ` Paolo Bonzini
2018-07-13 6:26 ` [Qemu-arm] " Paolo Bonzini
2018-07-13 6:26 ` [Qemu-devel] " Paolo Bonzini
2018-07-13 7:57 ` [Qemu-arm] " Thomas Huth
2018-07-13 7:57 ` [Qemu-devel] " Thomas Huth
2018-07-13 10:12 ` [Qemu-arm] " Paolo Bonzini
2018-07-13 10:12 ` [Qemu-devel] " Paolo Bonzini
2018-07-13 11:20 ` [Qemu-arm] " Thomas Huth
2018-07-13 11:20 ` [Qemu-devel] " Thomas Huth
2018-07-12 17:15 ` [Qemu-arm] " Eduardo Habkost
2018-07-12 17:15 ` Eduardo Habkost
2018-07-12 15:31 ` Thomas Huth [this message]
2018-07-12 15:31 ` [Qemu-devel] [PATCH 2/5] hw/core/sysbus: Add a function for creating and attaching an object Thomas Huth
2018-07-12 15:31 ` [Qemu-arm] [PATCH 3/5] hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported machines Thomas Huth
2018-07-12 15:31 ` [Qemu-devel] " Thomas Huth
2018-07-12 15:31 ` [Qemu-arm] [PATCH 4/5] hw/arm/armv7: Fix crash when introspecting the "iotkit" device Thomas Huth
2018-07-12 15:31 ` [Qemu-devel] " Thomas Huth
2018-07-12 15:31 ` [Qemu-arm] [PATCH 5/5] hw/cpu/a15mpcore: Fix introspection problem with the a15mpcore_priv device Thomas Huth
2018-07-12 15:31 ` [Qemu-devel] " Thomas Huth
2018-07-12 15:40 ` [Qemu-devel] [PATCH v1 0/5] Fix crashes with introspection Paolo Bonzini
2018-07-12 15:48 ` [Qemu-arm] " Peter Maydell
2018-07-12 15:48 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531409463-3843-3-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.