All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
	"Beniamino Galvani" <b.galvani@gmail.com>,
	qemu-arm@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-arm] [PATCH v2 00/16] Fix crashes with introspection of ARM devices
Date: Fri, 13 Jul 2018 10:27:28 +0200	[thread overview]
Message-ID: <1531470464-21522-1-git-send-email-thuth@redhat.com> (raw)

As discovered recently, you can crash QEMU with a lot of devices
that do not get the reference counting of child objects right.
You just have to run 'device-list-properties' and call 'info qtree'
afterwards.
This patch series fixes a bunch of these problems in the ARM code.
I did not fix all problems yet, since it is quite time consuming,
and this series is big enough already. The remaining problems can
be fixed in an independent patch series later.

v2:
 - Updated the first patch according to the review feedback from v1
 - Added more patches with additional fixes

Thomas Huth (16):
  qom/object: Add a new function object_initialize_child()
  hw/core/sysbus: Add a function for creating and attaching an object
  hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported
    machines
  hw/arm/armv7: Fix crash when introspecting the "iotkit" device
  hw/cpu/a15mpcore: Fix introspection problem with the a15mpcore_priv
    device
  hw/display/xlnx_dp: Move problematic code from instance_init to
    realize
  hw/arm/xlnx-zynqmp: Fix crash when introspecting the "xlnx,zynqmp"
    device
  hw/arm/msf2-soc: Fix introspection problem with the "msf2-soc" device
  hw/cpu/a9mpcore: Fix introspection problems with the "a9mpcore_priv"
    device
  hw/arm/fsl-imx6: Fix introspection problems with the "fsl,imx6" device
  hw/arm/fsl-imx7: Fix introspection problems with the "fsl,imx7" device
  hw/arm/fsl-imx25: Fix introspection problem with the "fsl,imx25"
    device
  hw/arm/fsl-imx31: Fix introspection problem with the "fsl,imx31"
    device
  hw/cpu/arm11mpcore: Fix introspection problem with 'arm11mpcore_priv'
  hw/*/realview: Fix introspection problem with 'realview_mpcore' &
    'realview_gic'
  hw/arm/allwinner-a10: Fix introspection problem with 'allwinner-a10'

 hw/arm/allwinner-a10.c   | 19 +++++-----
 hw/arm/armv7m.c          |  7 ++--
 hw/arm/bcm2836.c         | 18 +++------
 hw/arm/fsl-imx25.c       | 30 +++++++--------
 hw/arm/fsl-imx31.c       | 26 ++++++-------
 hw/arm/fsl-imx6.c        | 56 ++++++++++------------------
 hw/arm/fsl-imx7.c        | 96 ++++++++++++++++--------------------------------
 hw/arm/iotkit.c          | 74 ++++++++++++++++---------------------
 hw/arm/msf2-soc.c        | 15 ++++----
 hw/arm/xlnx-zynqmp.c     | 61 ++++++++++++++----------------
 hw/core/sysbus.c         |  8 ++++
 hw/cpu/a15mpcore.c       |  8 ++--
 hw/cpu/a9mpcore.c        | 18 ++++-----
 hw/cpu/arm11mpcore.c     | 14 +++----
 hw/cpu/realview_mpcore.c |  8 ++--
 hw/display/xlnx_dp.c     | 23 +++++-------
 hw/intc/armv7m_nvic.c    |  5 +--
 hw/intc/realview_gic.c   |  7 +---
 include/hw/sysbus.h      |  3 ++
 include/qom/object.h     | 23 +++++++++++-
 qom/object.c             | 15 ++++++++
 21 files changed, 244 insertions(+), 290 deletions(-)

-- 
1.8.3.1


WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-arm@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Beniamino Galvani" <b.galvani@gmail.com>,
	"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v2 00/16] Fix crashes with introspection of ARM devices
Date: Fri, 13 Jul 2018 10:27:28 +0200	[thread overview]
Message-ID: <1531470464-21522-1-git-send-email-thuth@redhat.com> (raw)

As discovered recently, you can crash QEMU with a lot of devices
that do not get the reference counting of child objects right.
You just have to run 'device-list-properties' and call 'info qtree'
afterwards.
This patch series fixes a bunch of these problems in the ARM code.
I did not fix all problems yet, since it is quite time consuming,
and this series is big enough already. The remaining problems can
be fixed in an independent patch series later.

v2:
 - Updated the first patch according to the review feedback from v1
 - Added more patches with additional fixes

Thomas Huth (16):
  qom/object: Add a new function object_initialize_child()
  hw/core/sysbus: Add a function for creating and attaching an object
  hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported
    machines
  hw/arm/armv7: Fix crash when introspecting the "iotkit" device
  hw/cpu/a15mpcore: Fix introspection problem with the a15mpcore_priv
    device
  hw/display/xlnx_dp: Move problematic code from instance_init to
    realize
  hw/arm/xlnx-zynqmp: Fix crash when introspecting the "xlnx,zynqmp"
    device
  hw/arm/msf2-soc: Fix introspection problem with the "msf2-soc" device
  hw/cpu/a9mpcore: Fix introspection problems with the "a9mpcore_priv"
    device
  hw/arm/fsl-imx6: Fix introspection problems with the "fsl,imx6" device
  hw/arm/fsl-imx7: Fix introspection problems with the "fsl,imx7" device
  hw/arm/fsl-imx25: Fix introspection problem with the "fsl,imx25"
    device
  hw/arm/fsl-imx31: Fix introspection problem with the "fsl,imx31"
    device
  hw/cpu/arm11mpcore: Fix introspection problem with 'arm11mpcore_priv'
  hw/*/realview: Fix introspection problem with 'realview_mpcore' &
    'realview_gic'
  hw/arm/allwinner-a10: Fix introspection problem with 'allwinner-a10'

 hw/arm/allwinner-a10.c   | 19 +++++-----
 hw/arm/armv7m.c          |  7 ++--
 hw/arm/bcm2836.c         | 18 +++------
 hw/arm/fsl-imx25.c       | 30 +++++++--------
 hw/arm/fsl-imx31.c       | 26 ++++++-------
 hw/arm/fsl-imx6.c        | 56 ++++++++++------------------
 hw/arm/fsl-imx7.c        | 96 ++++++++++++++++--------------------------------
 hw/arm/iotkit.c          | 74 ++++++++++++++++---------------------
 hw/arm/msf2-soc.c        | 15 ++++----
 hw/arm/xlnx-zynqmp.c     | 61 ++++++++++++++----------------
 hw/core/sysbus.c         |  8 ++++
 hw/cpu/a15mpcore.c       |  8 ++--
 hw/cpu/a9mpcore.c        | 18 ++++-----
 hw/cpu/arm11mpcore.c     | 14 +++----
 hw/cpu/realview_mpcore.c |  8 ++--
 hw/display/xlnx_dp.c     | 23 +++++-------
 hw/intc/armv7m_nvic.c    |  5 +--
 hw/intc/realview_gic.c   |  7 +---
 include/hw/sysbus.h      |  3 ++
 include/qom/object.h     | 23 +++++++++++-
 qom/object.c             | 15 ++++++++
 21 files changed, 244 insertions(+), 290 deletions(-)

-- 
1.8.3.1

             reply	other threads:[~2018-07-13  8:28 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13  8:27 Thomas Huth [this message]
2018-07-13  8:27 ` [Qemu-devel] [PATCH v2 00/16] Fix crashes with introspection of ARM devices Thomas Huth
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 01/16] qom/object: Add a new function object_initialize_child() Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13 11:14   ` Paolo Bonzini
2018-07-13 11:14     ` Paolo Bonzini
2018-07-13 21:16   ` [Qemu-arm] " Eduardo Habkost
2018-07-13 21:16     ` [Qemu-devel] " Eduardo Habkost
2018-07-13 21:29     ` [Qemu-arm] " Andreas Färber
2018-07-13 21:29       ` [Qemu-devel] " Andreas Färber
2018-07-13 21:46       ` [Qemu-arm] " Eduardo Habkost
2018-07-13 21:46         ` [Qemu-devel] " Eduardo Habkost
2018-07-16  7:05         ` [Qemu-arm] " Thomas Huth
2018-07-16  7:05           ` [Qemu-devel] " Thomas Huth
2018-07-13 22:57   ` [Qemu-arm] " Eduardo Habkost
2018-07-13 22:57     ` Eduardo Habkost
2018-07-16  7:16     ` [Qemu-arm] " Thomas Huth
2018-07-16  7:16       ` Thomas Huth
2018-08-16 11:59     ` [Qemu-arm] " Thomas Huth
2018-08-16 11:59       ` Thomas Huth
2018-08-17  1:40       ` [Qemu-arm] " Eduardo Habkost
2018-08-17  1:40         ` Eduardo Habkost
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 02/16] hw/core/sysbus: Add a function for creating and attaching an object Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13 21:17   ` [Qemu-arm] " Eduardo Habkost
2018-07-13 21:17     ` [Qemu-devel] " Eduardo Habkost
2018-07-13  8:27 ` [Qemu-devel] [PATCH v2 03/16] hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported machines Thomas Huth
2018-07-13  8:27   ` Thomas Huth
2018-07-13 21:26   ` [Qemu-arm] " Eduardo Habkost
2018-07-13 21:26     ` [Qemu-devel] " Eduardo Habkost
2018-07-16  7:09     ` [Qemu-arm] " Thomas Huth
2018-07-16  7:09       ` [Qemu-devel] " Thomas Huth
2018-07-16 19:48       ` [Qemu-arm] " Eduardo Habkost
2018-07-16 19:48         ` [Qemu-devel] " Eduardo Habkost
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 04/16] hw/arm/armv7: Fix crash when introspecting the "iotkit" device Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13 21:31   ` [Qemu-arm] " Eduardo Habkost
2018-07-13 21:31     ` [Qemu-devel] " Eduardo Habkost
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 05/16] hw/cpu/a15mpcore: Fix introspection problem with the a15mpcore_priv device Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13 21:48   ` [Qemu-arm] " Eduardo Habkost
2018-07-13 21:48     ` [Qemu-devel] " Eduardo Habkost
2018-07-13  8:27 ` [Qemu-devel] [PATCH v2 06/16] hw/display/xlnx_dp: Move problematic code from instance_init to realize Thomas Huth
2018-07-13  8:27   ` Thomas Huth
2018-07-13 11:13   ` [Qemu-arm] " Paolo Bonzini
2018-07-13 11:13     ` [Qemu-devel] " Paolo Bonzini
2018-07-13 15:59     ` [Qemu-arm] " Thomas Huth
2018-07-13 15:59       ` [Qemu-devel] " Thomas Huth
2018-07-13 17:13       ` [Qemu-arm] " Paolo Bonzini
2018-07-13 17:13         ` [Qemu-devel] " Paolo Bonzini
2018-07-16 11:34         ` [Qemu-arm] " Thomas Huth
2018-07-16 11:34           ` Thomas Huth
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 07/16] hw/arm/xlnx-zynqmp: Fix crash when introspecting the "xlnx, zynqmp" device Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13 21:49   ` Eduardo Habkost
2018-07-13 21:49     ` Eduardo Habkost
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 08/16] hw/arm/msf2-soc: Fix introspection problem with the "msf2-soc" device Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13 21:53   ` [Qemu-arm] " Eduardo Habkost
2018-07-13 21:53     ` [Qemu-devel] " Eduardo Habkost
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 09/16] hw/cpu/a9mpcore: Fix introspection problems with the "a9mpcore_priv" device Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13 21:53   ` [Qemu-arm] " Eduardo Habkost
2018-07-13 21:53     ` [Qemu-devel] " Eduardo Habkost
2018-07-13  8:27 ` [Qemu-devel] [PATCH v2 10/16] hw/arm/fsl-imx6: Fix introspection problems with the "fsl, imx6" device Thomas Huth
2018-07-13  8:27   ` Thomas Huth
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 11/16] hw/arm/fsl-imx7: Fix introspection problems with the "fsl, imx7" device Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 12/16] hw/arm/fsl-imx25: Fix introspection problem with the "fsl, imx25" device Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 13/16] hw/arm/fsl-imx31: Fix introspection problem with the "fsl, imx31" device Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 14/16] hw/cpu/arm11mpcore: Fix introspection problem with 'arm11mpcore_priv' Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 15/16] hw/*/realview: Fix introspection problem with 'realview_mpcore' & 'realview_gic' Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13  8:27 ` [Qemu-arm] [PATCH v2 16/16] hw/arm/allwinner-a10: Fix introspection problem with 'allwinner-a10' Thomas Huth
2018-07-13  8:27   ` [Qemu-devel] " Thomas Huth
2018-07-13 10:56 ` [Qemu-arm] [Qemu-devel] [PATCH v2 00/16] Fix crashes with introspection of ARM devices Richard Henderson
2018-07-13 10:56   ` Richard Henderson
2018-07-13 22:00 ` [Qemu-arm] " Eduardo Habkost
2018-07-13 22:00   ` [Qemu-devel] " Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531470464-21522-1-git-send-email-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=afaerber@suse.de \
    --cc=alistair@alistair23.me \
    --cc=armbru@redhat.com \
    --cc=b.galvani@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sundeep.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.