Re: [PATCH v2] usb: isp1760: add peripheral/device controller chip id

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sudeep,

On Wednesday 04 March 2015 17:04:43 Sudeep Holla wrote:
> On 04/03/15 16:11, Laurent Pinchart wrote:
> > Hi Sudeep,
> 
> > On Wednesday 04 March 2015 15:56:12 Sudeep Holla wrote:
> [...]
> 
> >> Also I don't see any message on the host side. Let me know if there's
> >> something wrong in my config or test commands.
> > 
> > Looks like a driver bug to me, .udc_start() and .udc_stop() should use
> > spin_(un)lock_irq(). Would you like to submit a patch ? I can also do it.
> 
> Thanks for the quick response. Yes I can submit that as I do have the
> patch already. Though it removes above dump for possible deadlock, it's
> still not working. So I was not sure if that's the right fix. Anyways I
> will post that patch and you can review :)
> 
> BTW, if you see above the log also contains "g_mass_storage gadget:
> userspace failed to provide iSerialNumber". Is this OK ? or is this the
> reason for not seeing any activity on host side.

That should be ok.

To rule out the possible low-level issues, have you checked that the ISP1761 
OC1_N/VBUS pin is properly connected to the VBUS power supply coming from the 
host ?

-- 
Regards,

Laurent Pinchart