All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>, Felipe Balbi <balbi@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] usb: isp1760: add peripheral/device controller chip id
Date: Wed, 04 Mar 2015 17:04:43 +0000	[thread overview]
Message-ID: <54F73B2B.3050305@arm.com> (raw)
In-Reply-To: <38531734.64FvIzp7Ky@avalon>



On 04/03/15 16:11, Laurent Pinchart wrote:
> Hi Sudeep,
>
> On Wednesday 04 March 2015 15:56:12 Sudeep Holla wrote:

[...]

>>
>> Also I don't see any message on the host side. Let me know if there's
>> something wrong in my config or test commands.
>
> Looks like a driver bug to me, .udc_start() and .udc_stop() should use
> spin_(un)lock_irq(). Would you like to submit a patch ? I can also do it.
>

Thanks for the quick response. Yes I can submit that as I do have the
patch already. Though it removes above dump for possible deadlock, it's
still not working. So I was not sure if that's the right fix. Anyways I
will post that patch and you can review :)

BTW, if you see above the log also contains "g_mass_storage gadget:
userspace failed to provide iSerialNumber". Is this OK ? or is this the
reason for not seeing any activity on host side.

Regards,
Sudeep


  reply	other threads:[~2015-03-04 17:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 17:53 [PATCH] usb: isp1760: fix peripheral/device controller chip id Sudeep Holla
2015-02-25 22:27 ` Laurent Pinchart
2015-02-26 10:24   ` Sudeep Holla
2015-02-26 11:47 ` [PATCH v2] usb: isp1760: add " Sudeep Holla
2015-02-26 18:53   ` Laurent Pinchart
2015-03-04 15:56     ` Sudeep Holla
2015-03-04 16:11       ` Laurent Pinchart
2015-03-04 17:04         ` Sudeep Holla [this message]
2015-03-05 11:12           ` Laurent Pinchart
2015-03-09 15:49       ` Felipe Balbi
2015-03-09 15:58         ` Sudeep Holla
2015-03-09 16:13           ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F73B2B.3050305@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.