* [PATCH v3 2/3] soc: imx: gpc: clean up
@ 2018-07-24 9:46 ` Sven Schmitt
0 siblings, 0 replies; 4+ messages in thread
From: Sven Schmitt @ 2018-07-24 9:46 UTC (permalink / raw)
To: linux-arm-kernel
Remove unused #defines.
Signed-off-by: Sven Schmitt <sven.schmitt@mixed-mode.de>
---
drivers/soc/imx/gpc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
index 5126185e68c6..35cc1d2dc4d5 100644
--- a/drivers/soc/imx/gpc.c
+++ b/drivers/soc/imx/gpc.c
@@ -24,15 +24,11 @@
#define GPC_PGC_CTRL_OFFS 0x0
#define GPC_PGC_PUPSCR_OFFS 0x4
#define GPC_PGC_PDNSCR_OFFS 0x8
-#define GPC_PGC_SW2ISO_SHIFT 0x8
-#define GPC_PGC_SW_SHIFT 0x0
#define GPC_PGC_PCI_PDN 0x200
#define GPC_PGC_PCI_SR 0x20c
#define GPC_PGC_GPU_PDN 0x260
-#define GPC_PGC_GPU_PUPSCR 0x264
-#define GPC_PGC_GPU_PDNSCR 0x268
#define GPC_PGC_GPU_SR 0x26c
#define GPC_PGC_DISP_PDN 0x240
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 2/3] soc: imx: gpc: clean up
@ 2018-07-24 9:46 ` Sven Schmitt
0 siblings, 0 replies; 4+ messages in thread
From: Sven Schmitt @ 2018-07-24 9:46 UTC (permalink / raw)
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, fabio.estevam@nxp.com, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: etnaviv@lists.freedesktop.org, l.stach@pengutronix.de
Remove unused #defines.
Signed-off-by: Sven Schmitt <sven.schmitt@mixed-mode.de>
---
drivers/soc/imx/gpc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
index 5126185e68c6..35cc1d2dc4d5 100644
--- a/drivers/soc/imx/gpc.c
+++ b/drivers/soc/imx/gpc.c
@@ -24,15 +24,11 @@
#define GPC_PGC_CTRL_OFFS 0x0
#define GPC_PGC_PUPSCR_OFFS 0x4
#define GPC_PGC_PDNSCR_OFFS 0x8
-#define GPC_PGC_SW2ISO_SHIFT 0x8
-#define GPC_PGC_SW_SHIFT 0x0
#define GPC_PGC_PCI_PDN 0x200
#define GPC_PGC_PCI_SR 0x20c
#define GPC_PGC_GPU_PDN 0x260
-#define GPC_PGC_GPU_PUPSCR 0x264
-#define GPC_PGC_GPU_PDNSCR 0x268
#define GPC_PGC_GPU_SR 0x26c
#define GPC_PGC_DISP_PDN 0x240
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 2/3] soc: imx: gpc: clean up
2018-07-24 9:46 ` Sven Schmitt
@ 2018-07-24 11:45 ` Leonard Crestez
-1 siblings, 0 replies; 4+ messages in thread
From: Leonard Crestez @ 2018-07-24 11:45 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2018-07-24 at 09:46 +0000, Sven Schmitt wrote:
> Remove unused #defines.
This should be the title of the patch, "clean up" is too vague.
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -24,15 +24,11 @@
> #define GPC_PGC_CTRL_OFFS 0x0
> #define GPC_PGC_PUPSCR_OFFS 0x4
> #define GPC_PGC_PDNSCR_OFFS 0x8
> -#define GPC_PGC_SW2ISO_SHIFT 0x8
> -#define GPC_PGC_SW_SHIFT 0x0
It would be cleaner if you used these defines when reading the sw/iso
values.
>
> #define GPC_PGC_PCI_PDN 0x200
> #define GPC_PGC_PCI_SR 0x20c
>
> #define GPC_PGC_GPU_PDN 0x260
> -#define GPC_PGC_GPU_PUPSCR 0x264
> -#define GPC_PGC_GPU_PDNSCR 0x268
> #define GPC_PGC_GPU_SR 0x26c
Each PGC has a fixed size and layout, maybe we could just have defines
for the offset of the PGC? It would be somewhat similar to gpcv2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 2/3] soc: imx: gpc: clean up
@ 2018-07-24 11:45 ` Leonard Crestez
0 siblings, 0 replies; 4+ messages in thread
From: Leonard Crestez @ 2018-07-24 11:45 UTC (permalink / raw)
To: Sven.Schmitt@mixed-mode.de
Cc: dl-linux-imx, linux-kernel@vger.kernel.org,
etnaviv@lists.freedesktop.org, Fabio Estevam, shawnguo@kernel.org,
linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de,
kernel@pengutronix.de, s.hauer@pengutronix.de
On Tue, 2018-07-24 at 09:46 +0000, Sven Schmitt wrote:
> Remove unused #defines.
This should be the title of the patch, "clean up" is too vague.
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -24,15 +24,11 @@
> #define GPC_PGC_CTRL_OFFS 0x0
> #define GPC_PGC_PUPSCR_OFFS 0x4
> #define GPC_PGC_PDNSCR_OFFS 0x8
> -#define GPC_PGC_SW2ISO_SHIFT 0x8
> -#define GPC_PGC_SW_SHIFT 0x0
It would be cleaner if you used these defines when reading the sw/iso
values.
>
> #define GPC_PGC_PCI_PDN 0x200
> #define GPC_PGC_PCI_SR 0x20c
>
> #define GPC_PGC_GPU_PDN 0x260
> -#define GPC_PGC_GPU_PUPSCR 0x264
> -#define GPC_PGC_GPU_PDNSCR 0x268
> #define GPC_PGC_GPU_SR 0x26c
Each PGC has a fixed size and layout, maybe we could just have defines
for the offset of the PGC? It would be somewhat similar to gpcv2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-24 11:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-24 9:46 [PATCH v3 2/3] soc: imx: gpc: clean up Sven Schmitt
2018-07-24 9:46 ` Sven Schmitt
2018-07-24 11:45 ` Leonard Crestez
2018-07-24 11:45 ` Leonard Crestez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.