From: Pkshih <pkshih@realtek.com>
To: "yuehaibing@huawei.com" <yuehaibing@huawei.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"colin.king@canonical.com" <colin.king@canonical.com>
Subject: Re: [PATCH] rtlwifi: btcoex: Fix if == else warnings in halbtc8723b2ant.c
Date: Mon, 6 Aug 2018 06:13:47 +0000 [thread overview]
Message-ID: <1533564825.4334.1.camel@realtek.com> (raw)
In-Reply-To: <20180806045440.11920-1-yuehaibing@huawei.com>
T24gTW9uLCAyMDE4LTA4LTA2IGF0IDEyOjU0ICswODAwLCBZdWVIYWliaW5nIHdyb3RlOg0KPiBG
aXggZm9sbG93aW5nIGNvY2NpbmVsbGUgd2FybmluZzoNCj4gDQo+IC4vZHJpdmVycy9uZXQvd2ly
ZWxlc3MvcmVhbHRlay9ydGx3aWZpL2J0Y29leGlzdC9oYWxidGM4NzIzYjJhbnQuYzoyOTUyOjIt
NDogV0FSTklORzogcG9zc2libGUNCj4gY29uZGl0aW9uIHdpdGggbm8gZWZmZWN0IChpZiA9PSBl
bHNlKQ0KPiAuL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnRsd2lmaS9idGNvZXhpc3Qv
aGFsYnRjODcyM2IyYW50LmM6Mjk2MToyLTQ6IFdBUk5JTkc6IHBvc3NpYmxlDQo+IGNvbmRpdGlv
biB3aXRoIG5vIGVmZmVjdCAoaWYgPT0gZWxzZSkNCj4gLi9kcml2ZXJzL25ldC93aXJlbGVzcy9y
ZWFsdGVrL3J0bHdpZmkvYnRjb2V4aXN0L2hhbGJ0Yzg3MjNiMmFudC5jOjMwMTE6Mi00OiBXQVJO
SU5HOiBwb3NzaWJsZQ0KPiBjb25kaXRpb24gd2l0aCBubyBlZmZlY3QgKGlmID09IGVsc2UpDQo+
IC4vZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydGx3aWZpL2J0Y29leGlzdC9oYWxidGM4
NzIzYjJhbnQuYzozMDIwOjItNDogV0FSTklORzogcG9zc2libGUNCj4gY29uZGl0aW9uIHdpdGgg
bm8gZWZmZWN0IChpZiA9PSBlbHNlKQ0KPiAuL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsv
cnRsd2lmaS9idGNvZXhpc3QvaGFsYnRjODcyM2IyYW50LmM6MzQzOToyLTQ6IFdBUk5JTkc6IHBv
c3NpYmxlDQo+IGNvbmRpdGlvbiB3aXRoIG5vIGVmZmVjdCAoaWYgPT0gZWxzZSkNCj4gLi9kcml2
ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvYnRjb2V4aXN0L2hhbGJ0Yzg3MjNiMmFu
dC5jOjM0NDg6Mi00OiBXQVJOSU5HOiBwb3NzaWJsZQ0KPiBjb25kaXRpb24gd2l0aCBubyBlZmZl
Y3QgKGlmID09IGVsc2UpDQo+IC4vZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydGx3aWZp
L2J0Y29leGlzdC9oYWxidGM4NzIzYjJhbnQuYzozMzM5OjItNDogV0FSTklORzogcG9zc2libGUN
Cj4gY29uZGl0aW9uIHdpdGggbm8gZWZmZWN0IChpZiA9PSBlbHNlKQ0KPiAuL2RyaXZlcnMvbmV0
L3dpcmVsZXNzL3JlYWx0ZWsvcnRsd2lmaS9idGNvZXhpc3QvaGFsYnRjODcyM2IyYW50LmM6MzM0
ODoyLTQ6IFdBUk5JTkc6IHBvc3NpYmxlDQo+IGNvbmRpdGlvbiB3aXRoIG5vIGVmZmVjdCAoaWYg
PT0gZWxzZSkNCj4gLi9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvYnRjb2V4
aXN0L2hhbGJ0Yzg3MjNiMmFudC5jOjMwNzQ6Mi00OiBXQVJOSU5HOiBwb3NzaWJsZQ0KPiBjb25k
aXRpb24gd2l0aCBubyBlZmZlY3QgKGlmID09IGVsc2UpDQo+IC4vZHJpdmVycy9uZXQvd2lyZWxl
c3MvcmVhbHRlay9ydGx3aWZpL2J0Y29leGlzdC9oYWxidGM4NzIzYjJhbnQuYzozMDgzOjItNDog
V0FSTklORzogcG9zc2libGUNCj4gY29uZGl0aW9uIHdpdGggbm8gZWZmZWN0IChpZiA9PSBlbHNl
KQ0KPiAuL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnRsd2lmaS9idGNvZXhpc3QvaGFs
YnRjODcyM2IyYW50LmM6MzE5MjoyLTQ6IFdBUk5JTkc6IHBvc3NpYmxlDQo+IGNvbmRpdGlvbiB3
aXRoIG5vIGVmZmVjdCAoaWYgPT0gZWxzZSkNCj4gLi9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFs
dGVrL3J0bHdpZmkvYnRjb2V4aXN0L2hhbGJ0Yzg3MjNiMmFudC5jOjMyMDE6Mi00OiBXQVJOSU5H
OiBwb3NzaWJsZQ0KPiBjb25kaXRpb24gd2l0aCBubyBlZmZlY3QgKGlmID09IGVsc2UpDQo+IC4v
ZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydGx3aWZpL2J0Y29leGlzdC9oYWxidGM4NzIz
YjJhbnQuYzozMjY3OjItNDogV0FSTklORzogcG9zc2libGUNCj4gY29uZGl0aW9uIHdpdGggbm8g
ZWZmZWN0IChpZiA9PSBlbHNlKQ0KPiAuL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnRs
d2lmaS9idGNvZXhpc3QvaGFsYnRjODcyM2IyYW50LmM6MzI3NjoyLTQ6IFdBUk5JTkc6IHBvc3Np
YmxlDQo+IGNvbmRpdGlvbiB3aXRoIG5vIGVmZmVjdCAoaWYgPT0gZWxzZSkNCj4gLi9kcml2ZXJz
L25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvYnRjb2V4aXN0L2hhbGJ0Yzg3MjNiMmFudC5j
OjMxMjQ6Mi00OiBXQVJOSU5HOiBwb3NzaWJsZQ0KPiBjb25kaXRpb24gd2l0aCBubyBlZmZlY3Qg
KGlmID09IGVsc2UpDQo+IC4vZHJpdmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydGx3aWZpL2J0
Y29leGlzdC9oYWxidGM4NzIzYjJhbnQuYzozMTMzOjItNDogV0FSTklORzogcG9zc2libGUNCj4g
Y29uZGl0aW9uIHdpdGggbm8gZWZmZWN0IChpZiA9PSBlbHNlKQ0KPiAuL2RyaXZlcnMvbmV0L3dp
cmVsZXNzL3JlYWx0ZWsvcnRsd2lmaS9idGNvZXhpc3QvaGFsYnRjODcyM2IyYW50LmM6MjgyMToy
LTQ6IFdBUk5JTkc6IHBvc3NpYmxlDQo+IGNvbmRpdGlvbiB3aXRoIG5vIGVmZmVjdCAoaWYgPT0g
ZWxzZSkNCj4gLi9kcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvYnRjb2V4aXN0
L2hhbGJ0Yzg3MjNiMmFudC5jOjI4MzA6Mi00OiBXQVJOSU5HOiBwb3NzaWJsZQ0KPiBjb25kaXRp
b24gd2l0aCBubyBlZmZlY3QgKGlmID09IGVsc2UpDQoNCkFja2VkLWJ5OiBQaW5nLUtlIFNoaWgg
PHBrc2hpaEByZWFsdGVrLmNvbT4NCg0KPiANCj4gU2lnbmVkLW9mZi1ieTogWXVlSGFpYmluZyA8
eXVlaGFpYmluZ0BodWF3ZWkuY29tPg0KPiAtLS0NCg==
WARNING: multiple messages have this Message-ID (diff)
From: Pkshih <pkshih@realtek.com>
To: "yuehaibing@huawei.com" <yuehaibing@huawei.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"colin.king@canonical.com" <colin.king@canonical.com>
Subject: Re: [PATCH] rtlwifi: btcoex: Fix if == else warnings in halbtc8723b2ant.c
Date: Mon, 6 Aug 2018 06:13:47 +0000 [thread overview]
Message-ID: <1533564825.4334.1.camel@realtek.com> (raw)
In-Reply-To: <20180806045440.11920-1-yuehaibing@huawei.com>
On Mon, 2018-08-06 at 12:54 +0800, YueHaibing wrote:
> Fix following coccinelle warning:
>
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2952:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2961:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3011:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3020:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3439:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3448:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3339:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3348:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3074:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3083:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3192:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3201:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3267:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3276:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3124:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3133:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2821:2-4: WARNING: possible
> condition with no effect (if == else)
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2830:2-4: WARNING: possible
> condition with no effect (if == else)
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
next prev parent reply other threads:[~2018-08-06 8:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 4:54 [PATCH] rtlwifi: btcoex: Fix if == else warnings in halbtc8723b2ant.c YueHaibing
2018-08-06 6:13 ` Pkshih [this message]
2018-08-06 6:13 ` Pkshih
2018-08-06 21:42 ` valdis.kletnieks
2018-08-06 21:42 ` valdis.kletnieks-PjAqaU27lzQ
2018-08-07 14:23 ` Larry Finger
2018-08-08 1:48 ` Pkshih
2018-08-08 1:48 ` Pkshih
2018-08-09 15:15 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533564825.4334.1.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=Larry.Finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.