diff for duplicates of <1533569985.11050.9.camel@analog.com> diff --git a/a/1.txt b/N1/1.txt index f76eeca..c3904ef 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,22 @@ -T24gTHUsIDIwMTgtMDgtMDYgYXQgMTU6MzkgKzAxMDAsIE1hcmsgQnJvd24gd3JvdGU6DQo+IE9u -IE1vbiwgQXVnIDA2LCAyMDE4IGF0IDAzOjA0OjQ0UE0gKzAzMDAsIFN0ZWZhbiBQb3BhIHdyb3Rl -Og0KPiANCj4gPiANCj4gPiArCWlmICghcmVnbWFwX3ZvbGF0aWxlKG1hcCwgcmVnKSB8fCAhcmVn -bWFwX3JlYWRhYmxlKG1hcCwgcmVnKSkNCj4gPiB7DQo+ID4gKwkJcmV0ID0gLUVJTlZBTDsNCj4g -PiArCQlnb3RvIG91dF91bmxvY2s7DQo+ID4gKwl9DQo+IEkgc3VnZ2VzdGVkIGhhdmluZyBhbiBl -eHBsaWNpdCBvcGVyYXRpb24gdG8gY2hlY2sgaWYgYSByZWdpc3RlciBzdXBwb3J0cw0KPiB0aGlz -IG1vZGUgb2Ygb3BlcmF0aW9uIHdoZW4gSSByZXZpZXdlZCBhbiBlYXJsaWVyIHZlcnNpb24sIEkg -ZGlkbid0DQo+IG5vdGljZSBhIHJlcGx5IG9uIHRoYXQ/DQoNCkhpIE1hcmssDQoNClNvcnJ5LCBJ -IGdvdCBjb25mdXNlZCBhYm91dCB3aGF0IG5lZWRzIHRvIGJlIGRvbmUuIFNob3VsZCBJIGFkZCBh -IG5ldyBmaWVsZA0KdG8gdGhlwqByZWdtYXBfY29uZmlnIHN0cnVjdCB3aGljaCB3aWxsIGJlIGNo -ZWNrZWQgZHVyaW5nIHRoZSBmdW5jdGlvbiBjYWxsPw0KU29tZXRoaW5nIGxpa2XCoGNhbl9tdWx0 -aV93cml0ZT8gSG93IGRvIHlvdSBzdWdnZXN0IGl0IHNob3VsZCBiZSBjYWxsZWQ/IElzDQpyZWFk -YWJsZV9ub2luY19yZWcgb2s/DQoNClRoYW5rIHlvdSENClN0ZWZhbg== +On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote: +> On Mon, Aug 06, 2018 at 03:04:44PM +0300, Stefan Popa wrote: +> +> > +> > + if (!regmap_volatile(map, reg) || !regmap_readable(map, reg)) +> > { +> > + ret = -EINVAL; +> > + goto out_unlock; +> > + } +> I suggested having an explicit operation to check if a register supports +> this mode of operation when I reviewed an earlier version, I didn't +> notice a reply on that? + +Hi Mark, + +Sorry, I got confused about what needs to be done. Should I add a new field +to the regmap_config struct which will be checked during the function call? +Something like can_multi_write? How do you suggest it should be called? Is +readable_noinc_reg ok? + +Thank you! +Stefan diff --git a/a/content_digest b/N1/content_digest index faa0c39..da9dec1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -23,18 +23,27 @@ " davem@davemloft.net <davem@davemloft.net>\0" "\00:1\0" "b\0" - "T24gTHUsIDIwMTgtMDgtMDYgYXQgMTU6MzkgKzAxMDAsIE1hcmsgQnJvd24gd3JvdGU6DQo+IE9u\n" - "IE1vbiwgQXVnIDA2LCAyMDE4IGF0IDAzOjA0OjQ0UE0gKzAzMDAsIFN0ZWZhbiBQb3BhIHdyb3Rl\n" - "Og0KPiANCj4gPiANCj4gPiArCWlmICghcmVnbWFwX3ZvbGF0aWxlKG1hcCwgcmVnKSB8fCAhcmVn\n" - "bWFwX3JlYWRhYmxlKG1hcCwgcmVnKSkNCj4gPiB7DQo+ID4gKwkJcmV0ID0gLUVJTlZBTDsNCj4g\n" - "PiArCQlnb3RvIG91dF91bmxvY2s7DQo+ID4gKwl9DQo+IEkgc3VnZ2VzdGVkIGhhdmluZyBhbiBl\n" - "eHBsaWNpdCBvcGVyYXRpb24gdG8gY2hlY2sgaWYgYSByZWdpc3RlciBzdXBwb3J0cw0KPiB0aGlz\n" - "IG1vZGUgb2Ygb3BlcmF0aW9uIHdoZW4gSSByZXZpZXdlZCBhbiBlYXJsaWVyIHZlcnNpb24sIEkg\n" - "ZGlkbid0DQo+IG5vdGljZSBhIHJlcGx5IG9uIHRoYXQ/DQoNCkhpIE1hcmssDQoNClNvcnJ5LCBJ\n" - "IGdvdCBjb25mdXNlZCBhYm91dCB3aGF0IG5lZWRzIHRvIGJlIGRvbmUuIFNob3VsZCBJIGFkZCBh\n" - "IG5ldyBmaWVsZA0KdG8gdGhlwqByZWdtYXBfY29uZmlnIHN0cnVjdCB3aGljaCB3aWxsIGJlIGNo\n" - "ZWNrZWQgZHVyaW5nIHRoZSBmdW5jdGlvbiBjYWxsPw0KU29tZXRoaW5nIGxpa2XCoGNhbl9tdWx0\n" - "aV93cml0ZT8gSG93IGRvIHlvdSBzdWdnZXN0IGl0IHNob3VsZCBiZSBjYWxsZWQ/IElzDQpyZWFk\n" - YWJsZV9ub2luY19yZWcgb2s/DQoNClRoYW5rIHlvdSENClN0ZWZhbg== + "On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote:\n" + "> On Mon, Aug 06, 2018 at 03:04:44PM +0300, Stefan Popa wrote:\n" + "> \n" + "> > \n" + "> > +\tif (!regmap_volatile(map, reg) || !regmap_readable(map, reg))\n" + "> > {\n" + "> > +\t\tret = -EINVAL;\n" + "> > +\t\tgoto out_unlock;\n" + "> > +\t}\n" + "> I suggested having an explicit operation to check if a register supports\n" + "> this mode of operation when I reviewed an earlier version, I didn't\n" + "> notice a reply on that?\n" + "\n" + "Hi Mark,\n" + "\n" + "Sorry, I got confused about what needs to be done. Should I add a new field\n" + "to the\302\240regmap_config struct which will be checked during the function call?\n" + "Something like\302\240can_multi_write? How do you suggest it should be called? Is\n" + "readable_noinc_reg ok?\n" + "\n" + "Thank you!\n" + Stefan -a71e431397f7a7f5b83b3d77da65288792fc7353e8f16d1619369202703ee8d9 +2fa9467d9aded65f53dfe26d0d5c1ca91befdca9d84761c7c8519eaf9ce7630b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.