From: "Popa, Stefan Serban" <StefanSerban.Popa@analog.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "lars@metafoo.de" <lars@metafoo.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jic23@kernel.org" <jic23@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"leonard.crestez@intel.com" <leonard.crestez@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API
Date: Mon, 6 Aug 2018 15:39:53 +0000 [thread overview]
Message-ID: <1533569985.11050.9.camel@analog.com> (raw)
In-Reply-To: <20180806143901.GP2414@sirena.org.uk>
T24gTHUsIDIwMTgtMDgtMDYgYXQgMTU6MzkgKzAxMDAsIE1hcmsgQnJvd24gd3JvdGU6DQo+IE9u
IE1vbiwgQXVnIDA2LCAyMDE4IGF0IDAzOjA0OjQ0UE0gKzAzMDAsIFN0ZWZhbiBQb3BhIHdyb3Rl
Og0KPiANCj4gPiANCj4gPiArCWlmICghcmVnbWFwX3ZvbGF0aWxlKG1hcCwgcmVnKSB8fCAhcmVn
bWFwX3JlYWRhYmxlKG1hcCwgcmVnKSkNCj4gPiB7DQo+ID4gKwkJcmV0ID0gLUVJTlZBTDsNCj4g
PiArCQlnb3RvIG91dF91bmxvY2s7DQo+ID4gKwl9DQo+IEkgc3VnZ2VzdGVkIGhhdmluZyBhbiBl
eHBsaWNpdCBvcGVyYXRpb24gdG8gY2hlY2sgaWYgYSByZWdpc3RlciBzdXBwb3J0cw0KPiB0aGlz
IG1vZGUgb2Ygb3BlcmF0aW9uIHdoZW4gSSByZXZpZXdlZCBhbiBlYXJsaWVyIHZlcnNpb24sIEkg
ZGlkbid0DQo+IG5vdGljZSBhIHJlcGx5IG9uIHRoYXQ/DQoNCkhpIE1hcmssDQoNClNvcnJ5LCBJ
IGdvdCBjb25mdXNlZCBhYm91dCB3aGF0IG5lZWRzIHRvIGJlIGRvbmUuIFNob3VsZCBJIGFkZCBh
IG5ldyBmaWVsZA0KdG8gdGhlwqByZWdtYXBfY29uZmlnIHN0cnVjdCB3aGljaCB3aWxsIGJlIGNo
ZWNrZWQgZHVyaW5nIHRoZSBmdW5jdGlvbiBjYWxsPw0KU29tZXRoaW5nIGxpa2XCoGNhbl9tdWx0
aV93cml0ZT8gSG93IGRvIHlvdSBzdWdnZXN0IGl0IHNob3VsZCBiZSBjYWxsZWQ/IElzDQpyZWFk
YWJsZV9ub2luY19yZWcgb2s/DQoNClRoYW5rIHlvdSENClN0ZWZhbg==
WARNING: multiple messages have this Message-ID (diff)
From: "Popa, Stefan Serban" <StefanSerban.Popa@analog.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "lars@metafoo.de" <lars@metafoo.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jic23@kernel.org" <jic23@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"leonard.crestez@intel.com" <leonard.crestez@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API
Date: Mon, 6 Aug 2018 15:39:53 +0000 [thread overview]
Message-ID: <1533569985.11050.9.camel@analog.com> (raw)
In-Reply-To: <20180806143901.GP2414@sirena.org.uk>
On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote:
> On Mon, Aug 06, 2018 at 03:04:44PM +0300, Stefan Popa wrote:
>
> >
> > + if (!regmap_volatile(map, reg) || !regmap_readable(map, reg))
> > {
> > + ret = -EINVAL;
> > + goto out_unlock;
> > + }
> I suggested having an explicit operation to check if a register supports
> this mode of operation when I reviewed an earlier version, I didn't
> notice a reply on that?
Hi Mark,
Sorry, I got confused about what needs to be done. Should I add a new field
to the regmap_config struct which will be checked during the function call?
Something like can_multi_write? How do you suggest it should be called? Is
readable_noinc_reg ok?
Thank you!
Stefan
next prev parent reply other threads:[~2018-08-06 15:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 12:04 [PATCH v4 0/6] iio: accel: Add adxl372 driver Stefan Popa
2018-08-06 12:04 ` Stefan Popa
2018-08-06 12:04 ` [PATCH v4 1/6] iio: adxl372: New driver for Analog Devices ADXL372 Accelerometer Stefan Popa
2018-08-06 12:04 ` Stefan Popa
2018-08-10 19:25 ` Marcus Folkesson
2018-08-06 12:04 ` [PATCH v4 2/6] dt-bindings: iio: accel: Add docs for ADXL372 Stefan Popa
2018-08-06 12:04 ` Stefan Popa
2018-08-07 14:58 ` Rob Herring
2018-08-06 12:04 ` [PATCH v4 3/6] regmap: Add regmap_noinc_read API Stefan Popa
2018-08-06 12:04 ` Stefan Popa
2018-08-06 14:39 ` Mark Brown
2018-08-06 15:39 ` Popa, Stefan Serban [this message]
2018-08-06 15:39 ` Popa, Stefan Serban
2018-08-06 16:04 ` Mark Brown
2018-08-08 9:59 ` [PATCH v4 3/6] regmap: Add regmap_noinc_read API [UNSCANNED] Charles Keepax
2018-08-08 9:59 ` Charles Keepax
2018-08-06 12:04 ` [PATCH v4 4/6] iio:adxl372: Add FIFO and interrupts support Stefan Popa
2018-08-06 12:04 ` Stefan Popa
2018-08-10 7:20 ` Dan Carpenter
2018-08-10 7:20 ` Dan Carpenter
2018-08-06 12:04 ` [PATCH v4 5/6] iio:adxl372: Add sampling frequency support Stefan Popa
2018-08-06 12:04 ` Stefan Popa
2018-08-10 19:58 ` Marcus Folkesson
2018-08-06 12:04 ` [PATCH v4 6/6] iio:adxl372: Add filter bandwidth support Stefan Popa
2018-08-06 12:04 ` Stefan Popa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533569985.11050.9.camel@analog.com \
--to=stefanserban.popa@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=leonard.crestez@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.