All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Popa, Stefan Serban" <StefanSerban.Popa@analog.com>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"knaack.h@gmx.de" <knaack.h@gmx.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"leonard.crestez@intel.com" <leonard.crestez@intel.com>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API [UNSCANNED]
Date: Wed, 8 Aug 2018 10:59:05 +0100	[thread overview]
Message-ID: <20180808095905.GG32322@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20180806160402.GR2414@sirena.org.uk>

On Mon, Aug 06, 2018 at 05:04:02PM +0100, Mark Brown wrote:
> On Mon, Aug 06, 2018 at 03:39:53PM +0000, Popa, Stefan Serban wrote:
> > On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote:
> 
> > > I suggested having an explicit operation to check if a register supports
> > > this mode of operation when I reviewed an earlier version, I didn't
> > > notice a reply on that?
> 
> > Sorry, I got confused about what needs to be done. Should I add a new field
> > to the regmap_config struct which will be checked during the function call?
> > Something like can_multi_write? How do you suggest it should be called? Is
> > readable_noinc_reg ok?
> 
> Like I said last time I'd suggest making it more like the readable and
> volatile checks - I'm fairly sure I've seen devices that don't
> autoincrement only for some registers.

I can confirm I have seen hardware that autoincrements for some
registers and not for others.

Thanks,
Charles

WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Popa, Stefan Serban" <StefanSerban.Popa@analog.com>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"knaack.h@gmx.de" <knaack.h@gmx.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"leonard.crestez@intel.com" <leonard.crestez@intel.com>,
	davem@davemlo
Subject: Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API [UNSCANNED]
Date: Wed, 8 Aug 2018 10:59:05 +0100	[thread overview]
Message-ID: <20180808095905.GG32322@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20180806160402.GR2414@sirena.org.uk>

On Mon, Aug 06, 2018 at 05:04:02PM +0100, Mark Brown wrote:
> On Mon, Aug 06, 2018 at 03:39:53PM +0000, Popa, Stefan Serban wrote:
> > On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote:
> 
> > > I suggested having an explicit operation to check if a register supports
> > > this mode of operation when I reviewed an earlier version, I didn't
> > > notice a reply on that?
> 
> > Sorry, I got confused about what needs to be done. Should I add a new field
> > to the regmap_config struct which will be checked during the function call?
> > Something like can_multi_write? How do you suggest it should be called? Is
> > readable_noinc_reg ok?
> 
> Like I said last time I'd suggest making it more like the readable and
> volatile checks - I'm fairly sure I've seen devices that don't
> autoincrement only for some registers.

I can confirm I have seen hardware that autoincrements for some
registers and not for others.

Thanks,
Charles

  reply	other threads:[~2018-08-08 12:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-06 12:04 [PATCH v4 0/6] iio: accel: Add adxl372 driver Stefan Popa
2018-08-06 12:04 ` Stefan Popa
2018-08-06 12:04 ` [PATCH v4 1/6] iio: adxl372: New driver for Analog Devices ADXL372 Accelerometer Stefan Popa
2018-08-06 12:04   ` Stefan Popa
2018-08-10 19:25   ` Marcus Folkesson
2018-08-06 12:04 ` [PATCH v4 2/6] dt-bindings: iio: accel: Add docs for ADXL372 Stefan Popa
2018-08-06 12:04   ` Stefan Popa
2018-08-07 14:58   ` Rob Herring
2018-08-06 12:04 ` [PATCH v4 3/6] regmap: Add regmap_noinc_read API Stefan Popa
2018-08-06 12:04   ` Stefan Popa
2018-08-06 14:39   ` Mark Brown
2018-08-06 15:39     ` Popa, Stefan Serban
2018-08-06 15:39       ` Popa, Stefan Serban
2018-08-06 16:04       ` Mark Brown
2018-08-08  9:59         ` Charles Keepax [this message]
2018-08-08  9:59           ` [PATCH v4 3/6] regmap: Add regmap_noinc_read API [UNSCANNED] Charles Keepax
2018-08-06 12:04 ` [PATCH v4 4/6] iio:adxl372: Add FIFO and interrupts support Stefan Popa
2018-08-06 12:04   ` Stefan Popa
2018-08-10  7:20   ` Dan Carpenter
2018-08-10  7:20     ` Dan Carpenter
2018-08-06 12:04 ` [PATCH v4 5/6] iio:adxl372: Add sampling frequency support Stefan Popa
2018-08-06 12:04   ` Stefan Popa
2018-08-10 19:58   ` Marcus Folkesson
2018-08-06 12:04 ` [PATCH v4 6/6] iio:adxl372: Add filter bandwidth support Stefan Popa
2018-08-06 12:04   ` Stefan Popa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180808095905.GG32322@imbe.wolfsonmicro.main \
    --to=ckeepax@opensource.cirrus.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=StefanSerban.Popa@analog.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=leonard.crestez@intel.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.