From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@codeaurora.org>,
Anilkumar Kolli <akolli@codeaurora.org>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [RFC v2] ath10k: report tx rate using ieee80211_tx_status()
Date: Mon, 03 Sep 2018 12:18:42 +0200 [thread overview]
Message-ID: <1535969922.3437.37.camel@sipsolutions.net> (raw)
In-Reply-To: <87k1o6d8hw.fsf@kamboji.qca.qualcomm.com>
On Fri, 2018-08-31 at 15:29 +0300, Kalle Valo wrote:
> Too me this feels like a bad idea but I'm not familiar enough with
> mac80211 to really comment on this. What kind of implications does this
> have for Mesh or ATF, for example? Adding Johannes and Toke to hear
> about their opinion about this.
The biggest implication is probably radiotap. Beyond that, it's using
this to report the "last rate" to nl80211, but that's not all super
useful anyway.
The retry count is also affected, and since you report "somewhat
liberally" that would lead to erroneous statistics.
I'd recommend against doing this and disentangling the necessary code in
mac80211, e.g. with ieee80211_tx_status_ext() or adding similar APIs.
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@codeaurora.org>,
Anilkumar Kolli <akolli@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@toke.dk>
Subject: Re: [RFC v2] ath10k: report tx rate using ieee80211_tx_status()
Date: Mon, 03 Sep 2018 12:18:42 +0200 [thread overview]
Message-ID: <1535969922.3437.37.camel@sipsolutions.net> (raw)
In-Reply-To: <87k1o6d8hw.fsf@kamboji.qca.qualcomm.com>
On Fri, 2018-08-31 at 15:29 +0300, Kalle Valo wrote:
> Too me this feels like a bad idea but I'm not familiar enough with
> mac80211 to really comment on this. What kind of implications does this
> have for Mesh or ATF, for example? Adding Johannes and Toke to hear
> about their opinion about this.
The biggest implication is probably radiotap. Beyond that, it's using
this to report the "last rate" to nl80211, but that's not all super
useful anyway.
The retry count is also affected, and since you report "somewhat
liberally" that would lead to erroneous statistics.
I'd recommend against doing this and disentangling the necessary code in
mac80211, e.g. with ieee80211_tx_status_ext() or adding similar APIs.
johannes
next prev parent reply other threads:[~2018-09-03 10:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 6:23 [RFC v2] ath10k: report tx rate using ieee80211_tx_status() Anilkumar Kolli
2018-04-21 6:23 ` Anilkumar Kolli
2018-04-24 8:02 ` Kalle Valo
2018-04-24 8:02 ` Kalle Valo
2018-04-25 9:59 ` Anilkumar Kolli
2018-04-25 9:59 ` Anilkumar Kolli
2018-04-25 14:03 ` Kalle Valo
2018-04-25 14:03 ` Kalle Valo
2018-08-21 6:04 ` Anilkumar Kolli
2018-08-21 6:04 ` Anilkumar Kolli
2018-08-21 7:46 ` Kalle Valo
2018-08-21 7:46 ` Kalle Valo
2018-08-31 12:29 ` Kalle Valo
2018-08-31 12:29 ` Kalle Valo
2018-08-31 14:22 ` Toke Høiland-Jørgensen
2018-08-31 14:22 ` Toke Høiland-Jørgensen
2018-09-03 5:37 ` Anilkumar Kolli
2018-09-03 5:37 ` Anilkumar Kolli
2018-09-03 10:13 ` Toke Høiland-Jørgensen
2018-09-03 10:13 ` Toke Høiland-Jørgensen
2018-09-03 10:19 ` Anilkumar Kolli
2018-09-03 10:19 ` Anilkumar Kolli
2018-09-03 10:18 ` Johannes Berg [this message]
2018-09-03 10:18 ` Johannes Berg
2018-09-06 7:10 ` Anilkumar Kolli
2018-09-06 7:10 ` Anilkumar Kolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535969922.3437.37.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akolli@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.