From: Johannes Berg <johannes@sipsolutions.net>
To: David Miller <davem@davemloft.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, mkubecek@suse.cz
Subject: Re: [PATCH 1/2] netlink: add NLA_REJECT policy type
Date: Mon, 17 Sep 2018 11:39:54 +0200 [thread overview]
Message-ID: <1537177194.2957.7.camel@sipsolutions.net> (raw)
In-Reply-To: <20180913.155934.742447935316828936.davem@davemloft.net>
On Thu, 2018-09-13 at 15:59 -0700, David Miller wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
> Date: Thu, 13 Sep 2018 10:46:02 +0200
>
> > + NL_SET_BAD_ATTR(extack, nla);
> > + if (extack && !extack->_msg)
> > + NL_SET_ERR_MSG(extack,
> > + "Attribute failed policy validation");
>
> Given the lively discussion that resulted from this conditional I am
> pretty sure we want to override existing messages.
>
> If we have an existing message, and we continued to process and
> parse anyways, then the existing message was informational or
> a warning.
>
> The message should be overridden when the action will be to fail, as
> it will be here when we return -EINVAL.
Not just -EINVAL, but yeah, I've just reworked the patch to do this.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mkubecek-AlSwsSmVLrQ@public.gmane.org
Subject: Re: [PATCH 1/2] netlink: add NLA_REJECT policy type
Date: Mon, 17 Sep 2018 11:39:54 +0200 [thread overview]
Message-ID: <1537177194.2957.7.camel@sipsolutions.net> (raw)
In-Reply-To: <20180913.155934.742447935316828936.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On Thu, 2018-09-13 at 15:59 -0700, David Miller wrote:
> From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
> Date: Thu, 13 Sep 2018 10:46:02 +0200
>
> > + NL_SET_BAD_ATTR(extack, nla);
> > + if (extack && !extack->_msg)
> > + NL_SET_ERR_MSG(extack,
> > + "Attribute failed policy validation");
>
> Given the lively discussion that resulted from this conditional I am
> pretty sure we want to override existing messages.
>
> If we have an existing message, and we continued to process and
> parse anyways, then the existing message was informational or
> a warning.
>
> The message should be overridden when the action will be to fail, as
> it will be here when we return -EINVAL.
Not just -EINVAL, but yeah, I've just reworked the patch to do this.
johannes
next prev parent reply other threads:[~2018-09-17 15:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 8:46 [PATCH 1/2] netlink: add NLA_REJECT policy type Johannes Berg
2018-09-13 8:46 ` Johannes Berg
2018-09-13 8:46 ` [PATCH 2/2] netlink: add ethernet address policy types Johannes Berg
2018-09-13 11:58 ` Michal Kubecek
2018-09-13 11:58 ` Michal Kubecek
2018-09-13 12:02 ` Johannes Berg
2018-09-13 12:12 ` Michal Kubecek
2018-09-13 12:16 ` Johannes Berg
2018-09-13 12:24 ` Michal Kubecek
2018-09-13 12:24 ` Michal Kubecek
2018-09-13 12:46 ` Johannes Berg
2018-09-13 12:46 ` Johannes Berg
2018-09-13 16:03 ` Michal Kubecek
2018-09-13 19:41 ` Marcelo Ricardo Leitner
2018-09-13 20:39 ` Michal Kubecek
2018-09-17 7:45 ` Johannes Berg
2018-09-13 10:49 ` [PATCH 1/2] netlink: add NLA_REJECT policy type Michal Kubecek
2018-09-13 11:25 ` Johannes Berg
2018-09-13 11:25 ` Johannes Berg
2018-09-13 12:05 ` Michal Kubecek
2018-09-13 19:20 ` Marcelo Ricardo Leitner
2018-09-13 20:43 ` Michal Kubecek
2018-09-13 19:30 ` Marcelo Ricardo Leitner
2018-09-13 21:27 ` Michal Kubecek
2018-09-13 21:58 ` Marcelo Ricardo Leitner
2018-09-17 9:38 ` Johannes Berg
2018-09-17 9:38 ` Johannes Berg
2018-09-17 20:17 ` Marcelo Ricardo Leitner
2018-09-18 12:34 ` Jamal Hadi Salim
2018-09-18 12:34 ` Jamal Hadi Salim
2018-09-18 12:39 ` Johannes Berg
2018-09-18 12:55 ` Jamal Hadi Salim
2018-09-18 12:57 ` Johannes Berg
2018-09-18 13:12 ` Jamal Hadi Salim
2018-09-18 16:42 ` Johannes Berg
2018-09-13 22:59 ` David Miller
2018-09-17 9:39 ` Johannes Berg [this message]
2018-09-17 9:39 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537177194.2957.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.