From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] i2c: sh_mobile: fix uninitialized var when debug is enabled
Date: Sat, 20 Dec 2014 20:51:29 +0200 [thread overview]
Message-ID: <1538093.pfjOnlVSo3@avalon> (raw)
In-Reply-To: <1419064602-8529-1-git-send-email-wsa@the-dreams.de>
Hi Wolfram,
Thank you for tha patch.
On Saturday 20 December 2014 09:36:42 Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> drivers/i2c/busses/i2c-sh_mobile.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-sh_mobile.c
> b/drivers/i2c/busses/i2c-sh_mobile.c index a12297e7680a..440d5dbc8b5f
> 100644
> --- a/drivers/i2c/busses/i2c-sh_mobile.c
> +++ b/drivers/i2c/busses/i2c-sh_mobile.c
> @@ -550,6 +550,7 @@ static struct dma_chan
> *sh_mobile_i2c_request_dma_chan(struct device *dev,
>
> chan = dma_request_slave_channel_reason(dev, chan_name);
> if (IS_ERR(chan)) {
> + ret = PTR_ERR(chan);
> dev_dbg(dev, "request_channel failed for %s (%d)\n", chan_name, ret);
You could just do
dev_dbg(dev, "request_channel failed for %s (%d)\n", chan_name,
PTR_ERR(chan));
but that's up to you.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> return chan;
> }
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] i2c: sh_mobile: fix uninitialized var when debug is enabled
Date: Sat, 20 Dec 2014 18:51:29 +0000 [thread overview]
Message-ID: <1538093.pfjOnlVSo3@avalon> (raw)
In-Reply-To: <1419064602-8529-1-git-send-email-wsa@the-dreams.de>
Hi Wolfram,
Thank you for tha patch.
On Saturday 20 December 2014 09:36:42 Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> drivers/i2c/busses/i2c-sh_mobile.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-sh_mobile.c
> b/drivers/i2c/busses/i2c-sh_mobile.c index a12297e7680a..440d5dbc8b5f
> 100644
> --- a/drivers/i2c/busses/i2c-sh_mobile.c
> +++ b/drivers/i2c/busses/i2c-sh_mobile.c
> @@ -550,6 +550,7 @@ static struct dma_chan
> *sh_mobile_i2c_request_dma_chan(struct device *dev,
>
> chan = dma_request_slave_channel_reason(dev, chan_name);
> if (IS_ERR(chan)) {
> + ret = PTR_ERR(chan);
> dev_dbg(dev, "request_channel failed for %s (%d)\n", chan_name, ret);
You could just do
dev_dbg(dev, "request_channel failed for %s (%d)\n", chan_name,
PTR_ERR(chan));
but that's up to you.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> return chan;
> }
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-12-20 18:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 8:36 [PATCH] i2c: sh_mobile: fix uninitialized var when debug is enabled Wolfram Sang
2014-12-20 8:36 ` Wolfram Sang
2014-12-20 18:51 ` Laurent Pinchart [this message]
2014-12-20 18:51 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538093.pfjOnlVSo3@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.