From: Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
'Russell King - ARM Linux'
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
oselas-/6JGXy0y6WNX4V3MAk3apN53zsg1cpMQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
'Ben Dooks' <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
augulis.darius-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: s3c64xx: mini6410: Correct card detect type for HSMMC1
Date: Mon, 21 Oct 2013 00:42:48 +0200 [thread overview]
Message-ID: <1538561.RlaZEsIrlT@thinkpad> (raw)
In-Reply-To: <5264529C.1000601-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Hi Kukjin,
On Monday 21 of October 2013 07:01:00 Kukjin Kim wrote:
> On 10/18/13 08:38, Kukjin Kim wrote:
> > Tomasz Figa wrote:
> >> Hi Kukjin,
> >
> > Hi,
> >
> >> On Sunday 29 of September 2013 18:12:01 Tomasz Figa wrote:
> >>> According to board schematics, for HSMMC1 a GPIO line is used to
> >>> detect
> >>> card presence, while currently it is being configured for internal
> >>> card
> >>> detect line, which is multiplexed with card detect line of HSMMC0 and
> >>> thus breaking it.
> >>>
> >>> This patch adds proper sdhci platform data setting card detect type
> >>> to
> >>> external GPIO and fixing operation of HSMMC0.
> >>>
> >>> Signed-off-by: Tomasz Figa<tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >>> ---
> >>>
> >>> arch/arm/mach-s3c64xx/mach-mini6410.c | 10 ++++++++++
> >>> 1 file changed, 10 insertions(+)
> >>
> >> Would you mind taking this patch to your tree?
> >
> > Applied, thanks.
> > Kukjin
>
> Uhm...just small concern...it's possible to support dt for mini6410 but
> basic. I need to hold this on...
May I ask you to explain your concern about this?
I believe this bug fix is fine, since we still support board files for
s3c64xx and DT based support is experimental at the moment.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3c64xx: mini6410: Correct card detect type for HSMMC1
Date: Mon, 21 Oct 2013 00:42:48 +0200 [thread overview]
Message-ID: <1538561.RlaZEsIrlT@thinkpad> (raw)
In-Reply-To: <5264529C.1000601@samsung.com>
Hi Kukjin,
On Monday 21 of October 2013 07:01:00 Kukjin Kim wrote:
> On 10/18/13 08:38, Kukjin Kim wrote:
> > Tomasz Figa wrote:
> >> Hi Kukjin,
> >
> > Hi,
> >
> >> On Sunday 29 of September 2013 18:12:01 Tomasz Figa wrote:
> >>> According to board schematics, for HSMMC1 a GPIO line is used to
> >>> detect
> >>> card presence, while currently it is being configured for internal
> >>> card
> >>> detect line, which is multiplexed with card detect line of HSMMC0 and
> >>> thus breaking it.
> >>>
> >>> This patch adds proper sdhci platform data setting card detect type
> >>> to
> >>> external GPIO and fixing operation of HSMMC0.
> >>>
> >>> Signed-off-by: Tomasz Figa<tomasz.figa@gmail.com>
> >>> ---
> >>>
> >>> arch/arm/mach-s3c64xx/mach-mini6410.c | 10 ++++++++++
> >>> 1 file changed, 10 insertions(+)
> >>
> >> Would you mind taking this patch to your tree?
> >
> > Applied, thanks.
> > Kukjin
>
> Uhm...just small concern...it's possible to support dt for mini6410 but
> basic. I need to hold this on...
May I ask you to explain your concern about this?
I believe this bug fix is fine, since we still support board files for
s3c64xx and DT based support is experimental at the moment.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
linux-samsung-soc@vger.kernel.org,
"'Russell King - ARM Linux'" <linux@arm.linux.org.uk>,
oselas@community.pengutronix.de, linux-kernel@vger.kernel.org,
"'Ben Dooks'" <ben-linux@fluff.org>,
augulis.darius@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: s3c64xx: mini6410: Correct card detect type for HSMMC1
Date: Mon, 21 Oct 2013 00:42:48 +0200 [thread overview]
Message-ID: <1538561.RlaZEsIrlT@thinkpad> (raw)
In-Reply-To: <5264529C.1000601@samsung.com>
Hi Kukjin,
On Monday 21 of October 2013 07:01:00 Kukjin Kim wrote:
> On 10/18/13 08:38, Kukjin Kim wrote:
> > Tomasz Figa wrote:
> >> Hi Kukjin,
> >
> > Hi,
> >
> >> On Sunday 29 of September 2013 18:12:01 Tomasz Figa wrote:
> >>> According to board schematics, for HSMMC1 a GPIO line is used to
> >>> detect
> >>> card presence, while currently it is being configured for internal
> >>> card
> >>> detect line, which is multiplexed with card detect line of HSMMC0 and
> >>> thus breaking it.
> >>>
> >>> This patch adds proper sdhci platform data setting card detect type
> >>> to
> >>> external GPIO and fixing operation of HSMMC0.
> >>>
> >>> Signed-off-by: Tomasz Figa<tomasz.figa@gmail.com>
> >>> ---
> >>>
> >>> arch/arm/mach-s3c64xx/mach-mini6410.c | 10 ++++++++++
> >>> 1 file changed, 10 insertions(+)
> >>
> >> Would you mind taking this patch to your tree?
> >
> > Applied, thanks.
> > Kukjin
>
> Uhm...just small concern...it's possible to support dt for mini6410 but
> basic. I need to hold this on...
May I ask you to explain your concern about this?
I believe this bug fix is fine, since we still support board files for
s3c64xx and DT based support is experimental at the moment.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-10-20 22:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 16:12 [PATCH] ARM: s3c64xx: mini6410: Correct card detect type for HSMMC1 Tomasz Figa
2013-09-29 16:12 ` Tomasz Figa
2013-10-16 18:33 ` Tomasz Figa
2013-10-16 18:33 ` Tomasz Figa
2013-10-17 23:38 ` Kukjin Kim
2013-10-17 23:38 ` Kukjin Kim
2013-10-20 22:01 ` Kukjin Kim
2013-10-20 22:01 ` Kukjin Kim
2013-10-20 22:01 ` Kukjin Kim
[not found] ` <5264529C.1000601-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-10-20 22:42 ` Tomasz Figa [this message]
2013-10-20 22:42 ` Tomasz Figa
2013-10-20 22:42 ` Tomasz Figa
-- strict thread matches above, loose matches on Subject: below --
2013-12-13 20:19 Tomasz Figa
2013-12-13 20:19 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538561.RlaZEsIrlT@thinkpad \
--to=tomasz.figa-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=augulis.darius-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oselas-/6JGXy0y6WNX4V3MAk3apN53zsg1cpMQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.