From: Oliver Neukum <oneukum@suse.com>
To: Tobias Herzog <t-herzog@gmx.de>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: [1/2] cdc-acm: do not reset notification buffer index upon urb unlinking
Date: Thu, 04 Oct 2018 15:33:14 +0200 [thread overview]
Message-ID: <1538659994.1254.3.camel@suse.com> (raw)
On Sa, 2018-09-22 at 22:11 +0200, Tobias Herzog wrote:
> Resetting the write index of the notification buffer on urb unlink (e.g.
> closing a cdc-acm device from userspace) may lead to wrong interpretation
> of further received notifications, in case the index is not 0 when urb
> unlink happens (i.e. when parts of a notification already have been
> transferred). On the device side there is no "reset" of the notification
> transimission and thus we would get out of sync with the device.
>
> Signed-off-by: Tobias Herzog <t-herzog@gmx.de>
Acked-by: Oliver Neukum <oneukum@suse.com>
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Neukum <oneukum@suse.com>
To: Tobias Herzog <t-herzog@gmx.de>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] cdc-acm: do not reset notification buffer index upon urb unlinking
Date: Thu, 04 Oct 2018 15:33:14 +0200 [thread overview]
Message-ID: <1538659994.1254.3.camel@suse.com> (raw)
In-Reply-To: <1537647071-2691-1-git-send-email-t-herzog@gmx.de>
On Sa, 2018-09-22 at 22:11 +0200, Tobias Herzog wrote:
> Resetting the write index of the notification buffer on urb unlink (e.g.
> closing a cdc-acm device from userspace) may lead to wrong interpretation
> of further received notifications, in case the index is not 0 when urb
> unlink happens (i.e. when parts of a notification already have been
> transferred). On the device side there is no "reset" of the notification
> transimission and thus we would get out of sync with the device.
>
> Signed-off-by: Tobias Herzog <t-herzog@gmx.de>
Acked-by: Oliver Neukum <oneukum@suse.com>
next reply other threads:[~2018-10-04 13:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 13:33 Oliver Neukum [this message]
2018-10-04 13:33 ` [PATCH 1/2] cdc-acm: do not reset notification buffer index upon urb unlinking Oliver Neukum
-- strict thread matches above, loose matches on Subject: below --
2018-10-04 13:34 [2/2] cdc-acm: correct counting of UART states in serial state notification Oliver Neukum
2018-10-04 13:34 ` [PATCH 2/2] " Oliver Neukum
2018-10-04 13:32 [1/2] cdc-acm: do not reset notification buffer index upon urb unlinking Oliver Neukum
2018-10-04 13:32 ` [PATCH 1/2] " Oliver Neukum
2018-10-02 17:34 [2/2] cdc-acm: correct counting of UART states in serial state notification Greg Kroah-Hartman
2018-10-02 17:34 ` [PATCH 2/2] " Greg KH
2018-09-22 20:11 [2/2] " Tobias Herzog
2018-09-22 20:11 ` [PATCH 2/2] " Tobias Herzog
2018-09-22 20:11 [1/2] cdc-acm: do not reset notification buffer index upon urb unlinking Tobias Herzog
2018-09-22 20:11 ` [PATCH 1/2] " Tobias Herzog
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538659994.1254.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=t-herzog@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.