All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <damien.lemoal@wdc.com>,
	linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Matias Bjorling <matias.bjorling@wdc.com>
Subject: Re: [PATCH 06/11] block: Introduce BLKGETZONESZ ioctl
Date: Wed, 10 Oct 2018 09:53:26 -0700	[thread overview]
Message-ID: <1539190406.195557.4.camel@acm.org> (raw)
In-Reply-To: <20181010015239.24930-7-damien.lemoal@wdc.com>

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

On Wed, 2018-10-10 at 10:52 +0900, Damien Le Moal wrote:
>  #define BLKREPORTZONE	_IOWR(0x12, 130, struct blk_zone_report)
>  #define BLKRESETZONE	_IOW(0x12, 131, struct blk_zone_range)
> +#define BLKGETZONESZ	_IOW(0x12, 132, unsigned int)

From Documentation/ioctl/botching-up-ioctls.txt, a collection of lessons learned
the hard way about ioctls:

 * Only use fixed sized integers. To avoid conflicts with typedefs in userspace
   the kernel has special types like __u32, __s64. Use them.

Please follow that advice.

Thanks,

Bart.


[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <damien.lemoal@wdc.com>,
	linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Matias Bjorling <matias.bjorling@wdc.com>
Subject: Re: [dm-devel] [PATCH 06/11] block: Introduce BLKGETZONESZ ioctl
Date: Wed, 10 Oct 2018 09:53:26 -0700	[thread overview]
Message-ID: <1539190406.195557.4.camel@acm.org> (raw)
In-Reply-To: <20181010015239.24930-7-damien.lemoal@wdc.com>

On Wed, 2018-10-10 at 10:52 +0900, Damien Le Moal wrote:
>  #define BLKREPORTZONE	_IOWR(0x12, 130, struct blk_zone_report)
>  #define BLKRESETZONE	_IOW(0x12, 131, struct blk_zone_range)
> +#define BLKGETZONESZ	_IOW(0x12, 132, unsigned int)

>From Documentation/ioctl/botching-up-ioctls.txt, a collection of lessons learned
the hard way about ioctls:

 * Only use fixed sized integers. To avoid conflicts with typedefs in userspace
   the kernel has special types like __u32, __s64. Use them.

Please follow that advice.

Thanks,

Bart.

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <damien.lemoal@wdc.com>,
	linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Matias Bjorling <matias.bjorling@wdc.com>
Subject: Re: [PATCH 06/11] block: Introduce BLKGETZONESZ ioctl
Date: Wed, 10 Oct 2018 09:53:26 -0700	[thread overview]
Message-ID: <1539190406.195557.4.camel@acm.org> (raw)
In-Reply-To: <20181010015239.24930-7-damien.lemoal@wdc.com>

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

On Wed, 2018-10-10 at 10:52 +0900, Damien Le Moal wrote:
>  #define BLKREPORTZONE	_IOWR(0x12, 130, struct blk_zone_report)
>  #define BLKRESETZONE	_IOW(0x12, 131, struct blk_zone_range)
> +#define BLKGETZONESZ	_IOW(0x12, 132, unsigned int)

>From Documentation/ioctl/botching-up-ioctls.txt, a collection of lessons learned
the hard way about ioctls:

 * Only use fixed sized integers. To avoid conflicts with typedefs in userspace
   the kernel has special types like __u32, __s64. Use them.

Please follow that advice.

Thanks,

Bart.


[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  parent reply	other threads:[~2018-10-10 16:53 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10  1:52 [PATCH 00/11] Zoned block device support improvements Damien Le Moal
2018-10-10  1:52 ` [PATCH 01/11] scsi: sd_zbc: Rearrange code Damien Le Moal
2018-10-10 13:25   ` Christoph Hellwig
2018-10-10 13:25     ` Christoph Hellwig
2018-10-10  1:52 ` [PATCH 02/11] scsi: sd_zbc: Reduce boot device scan and revalidate time Damien Le Moal
2018-10-10 13:26   ` Christoph Hellwig
2018-10-10 13:26     ` Christoph Hellwig
2018-10-10  1:52 ` [PATCH 03/11] scsi: sd_zbc: Fix sd_zbc_check_zones() error checks Damien Le Moal
2018-10-10 13:26   ` Christoph Hellwig
2018-10-10 13:26     ` Christoph Hellwig
2018-10-10  1:52 ` [PATCH 04/11] block: Introduce blkdev_nr_zones() helper Damien Le Moal
2018-10-10 13:26   ` Christoph Hellwig
2018-10-10 13:26     ` Christoph Hellwig
2018-10-10  1:52 ` [PATCH 05/11] block: Limit allocation of zone descriptors for report zones Damien Le Moal
2018-10-10 13:27   ` Christoph Hellwig
2018-10-10 13:27     ` Christoph Hellwig
2018-10-10  1:52 ` [PATCH 06/11] block: Introduce BLKGETZONESZ ioctl Damien Le Moal
2018-10-10 13:27   ` Christoph Hellwig
2018-10-10 13:27     ` Christoph Hellwig
2018-10-10 16:53   ` Bart Van Assche [this message]
2018-10-10 16:53     ` Bart Van Assche
2018-10-10 16:53     ` [dm-devel] " Bart Van Assche
2018-10-10  1:52 ` [PATCH 07/11] block: Introduce BLKGETNRZONES ioctl Damien Le Moal
2018-10-10 13:27   ` Christoph Hellwig
2018-10-10 13:27     ` Christoph Hellwig
2018-10-10  1:52 ` [PATCH 08/11] block: Improve zone reset execution Damien Le Moal
2018-10-10 13:28   ` Christoph Hellwig
2018-10-10 13:28     ` Christoph Hellwig
2018-10-10  1:52 ` [PATCH 09/11] block: Expose queue nr_zones in sysfs Damien Le Moal
2018-10-10 13:28   ` Christoph Hellwig
2018-10-10 13:28     ` Christoph Hellwig
2018-10-10 14:05   ` kbuild test robot
2018-10-10 14:05     ` kbuild test robot
2018-10-10 18:44   ` kbuild test robot
2018-10-10 18:44     ` kbuild test robot
2018-10-10  1:52 ` [PATCH 10/11] block: add a report_zones method Damien Le Moal
2018-10-10 14:15   ` Mike Snitzer
2018-10-10 14:15     ` Mike Snitzer
2018-10-10 16:15     ` Mike Snitzer
2018-10-10 16:15       ` Mike Snitzer
2018-10-10 14:40   ` kbuild test robot
2018-10-10 14:40     ` kbuild test robot
2018-10-10 15:34   ` Mike Snitzer
2018-10-10 15:34     ` Mike Snitzer
2018-10-10 16:25   ` kbuild test robot
2018-10-10 16:25     ` kbuild test robot
2018-10-10  1:52 ` [PATCH 11/11] block: Introduce revalidate_disk_zones() Damien Le Moal
2018-10-10 13:34   ` Christoph Hellwig
2018-10-10 13:34     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539190406.195557.4.camel@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matias.bjorling@wdc.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.