From: Trent Piepho <tpiepho@impinj.com>
To: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"talel@amazon.com" <talel@amazon.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
"jonnyc@amazon.com" <jonnyc@amazon.com>,
"ronenk@amazon.com" <ronenk@amazon.com>,
"barakw@amazon.com" <barakw@amazon.com>
Subject: Re: [PATCH 2/2] dw: spi: add support for Alpine spi controller
Date: Wed, 10 Oct 2018 22:08:59 +0000 [thread overview]
Message-ID: <1539209339.1944.23.camel@impinj.com> (raw)
In-Reply-To: <1539184516-8200-2-git-send-email-talel@amazon.com>
On Wed, 2018-10-10 at 18:15 +0300, Talel Shenhar wrote:
> Add support for a new devicetree compatible string called
> 'al,alpine-apb-ssi', which is necessary for the Amazon Alpine spi
> controller. 'al,alpine-dw-apb-ssi' is used in the dw spi driver if
> specified in the devicetree. Otherwise, fall back to driver default
> behavior, i.e. original dw IP hw driver behavior.
>
> Signed-off-by: Talel Shenhar <talel@amazon.com>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Shouldn't this be "amzn,alpine-apb-ssi"? The convention, and this IS
documented, is to the use company's stock ticker symbol as the prefix,
so as to have something grounded in the real world. I don't know of
anyone else using a product line name as the company name in their dt
bindings. Example, "snps,dw-apb-ssi", is named for Synopsis, not the
Designware line.
next prev parent reply other threads:[~2018-10-10 22:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 7:08 [PATCH 1/2] dt-bindings: spi: dw: add cs-override property Talel Shenhar
2018-10-10 7:08 ` Talel Shenhar
2018-10-10 7:08 ` [PATCH 2/2] dw: spi: add 'cs-override' DT property support Talel Shenhar
2018-10-10 7:08 ` Talel Shenhar
2018-10-10 10:18 ` [PATCH 1/2] dt-bindings: spi: dw: add cs-override property Mark Brown
2018-10-10 10:34 ` Talel Shenhar
2018-10-10 10:34 ` Talel Shenhar
2018-10-10 11:29 ` David Woodhouse
2018-10-10 11:29 ` David Woodhouse
2018-10-10 11:23 ` Talel Shenhar
2018-10-10 11:23 ` Talel Shenhar
2018-10-10 11:27 ` Mark Brown
2018-10-10 11:58 ` Woodhouse, David
2018-10-10 12:27 ` Mark Brown
2018-10-10 22:52 ` Trent Piepho
2018-10-10 15:15 ` [PATCH 1/2] dt-bindings: spi: dw: add compatible for Alpine spi controller Talel Shenhar
2018-10-10 15:15 ` Talel Shenhar
2018-10-10 15:15 ` [PATCH 2/2] dw: spi: add support " Talel Shenhar
2018-10-10 15:15 ` Talel Shenhar
2018-10-10 22:08 ` Trent Piepho [this message]
2018-10-11 11:20 ` [PATCH 1/2] dt-bindings: spi: dw: add compatible for Amazon's " Talel Shenhar
2018-10-11 11:20 ` Talel Shenhar
2018-10-11 11:20 ` [PATCH 2/2] dw: spi: add support " Talel Shenhar
2018-10-11 11:20 ` Talel Shenhar
2018-10-11 14:58 ` Applied "dw: spi: add support for Amazon's Alpine spi controller" to the spi tree Mark Brown
2018-10-11 14:58 ` Mark Brown
2018-10-11 14:58 ` Mark Brown
2018-10-11 13:44 ` [PATCH 1/2] dt-bindings: spi: dw: add compatible for Amazon's Alpine spi controller Mark Brown
2018-10-11 14:58 ` Applied "spi: dw: add compatible for Amazon's Alpine spi controller" to the spi tree Mark Brown
2018-10-11 14:58 ` Mark Brown
2018-10-11 14:58 ` Mark Brown
2018-10-11 11:22 ` [PATCH 2/2] dw: spi: add support for Alpine spi controller Talel Shenhar
2018-10-10 22:21 ` [PATCH 1/2] dt-bindings: spi: dw: add cs-override property Trent Piepho
2018-10-11 7:39 ` Talel Shenhar
2018-10-11 7:39 ` Talel Shenhar
2018-10-11 13:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539209339.1944.23.camel@impinj.com \
--to=tpiepho@impinj.com \
--cc=barakw@amazon.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=jonnyc@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.