From: bvanassche@acm.org (Bart Van Assche)
Subject: [PATCH] Revert "workqueue: re-add lockdep dependencies for flushing"
Date: Mon, 22 Oct 2018 14:47:50 -0700 [thread overview]
Message-ID: <1540244870.128590.39.camel@acm.org> (raw)
In-Reply-To: <13901aed5074f4b1fbd259d03928efb6ab40c65a.camel@sipsolutions.net>
On Mon, 2018-10-22@22:14 +0200, Johannes Berg wrote:
> I must also say that I'm disappointed you'd try to do things this way.
> I'd be (have been?) willing to actually help you understand the problem
> and add the annotations, but rather than answer my question ("where do I
> find the right git tree"!) you just send a revert patch.
Sorry that I had not yet provided that information. You should have
received this information through another e-mail thread. See also
http://lists.infradead.org/pipermail/linux-nvme/2018-October/020493.html.
> To do that, you have to understand what recursion is valid (I'm guessing
> there's some sort of layering involved), and I'm far from understanding
> anything about the code that triggered this report.
I don't think there is any kind of recursion involved in the NVMe code
that triggered the lockdep complaint. Sagi, please correct me if I got this
wrong.
Bart.
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Johannes Berg <johannes@sipsolutions.net>, Tejun Heo <tj@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme @ lists . infradead . org"
<linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] Revert "workqueue: re-add lockdep dependencies for flushing"
Date: Mon, 22 Oct 2018 14:47:50 -0700 [thread overview]
Message-ID: <1540244870.128590.39.camel@acm.org> (raw)
In-Reply-To: <13901aed5074f4b1fbd259d03928efb6ab40c65a.camel@sipsolutions.net>
On Mon, 2018-10-22 at 22:14 +0200, Johannes Berg wrote:
> I must also say that I'm disappointed you'd try to do things this way.
> I'd be (have been?) willing to actually help you understand the problem
> and add the annotations, but rather than answer my question ("where do I
> find the right git tree"!) you just send a revert patch.
Sorry that I had not yet provided that information. You should have
received this information through another e-mail thread. See also
http://lists.infradead.org/pipermail/linux-nvme/2018-October/020493.html.
> To do that, you have to understand what recursion is valid (I'm guessing
> there's some sort of layering involved), and I'm far from understanding
> anything about the code that triggered this report.
I don't think there is any kind of recursion involved in the NVMe code
that triggered the lockdep complaint. Sagi, please correct me if I got this
wrong.
Bart.
next prev parent reply other threads:[~2018-10-22 21:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 15:18 [PATCH] Revert "workqueue: re-add lockdep dependencies for flushing" Bart Van Assche
2018-10-22 15:18 ` Bart Van Assche
2018-10-22 20:14 ` Johannes Berg
2018-10-22 20:14 ` Johannes Berg
2018-10-22 20:28 ` Johannes Berg
2018-10-22 20:28 ` Johannes Berg
2018-10-22 20:54 ` Bart Van Assche
2018-10-22 20:54 ` Bart Van Assche
2018-10-22 21:04 ` Johannes Berg
2018-10-22 21:04 ` Johannes Berg
2018-10-22 21:26 ` Bart Van Assche
2018-10-22 21:26 ` Bart Van Assche
2018-10-23 19:44 ` Johannes Berg
2018-10-23 19:44 ` Johannes Berg
2018-10-23 19:58 ` Johannes Berg
2018-10-23 19:58 ` Johannes Berg
2018-10-23 1:17 ` Bart Van Assche
2018-10-23 1:17 ` Bart Van Assche
2018-10-23 19:50 ` Johannes Berg
2018-10-23 19:50 ` Johannes Berg
2018-10-23 20:24 ` Johannes Berg
2018-10-23 20:24 ` Johannes Berg
2018-10-22 21:47 ` Bart Van Assche [this message]
2018-10-22 21:47 ` Bart Van Assche
2018-10-23 0:43 ` Sagi Grimberg
2018-10-23 0:43 ` Sagi Grimberg
2018-10-23 19:26 ` Johannes Berg
2018-10-23 19:26 ` Johannes Berg
2018-10-23 21:30 ` Sagi Grimberg
2018-10-23 21:30 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540244870.128590.39.camel@acm.org \
--to=bvanassche@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.