From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Dan Williams <dan.j.williams@intel.com>,
tj@kernel.org, Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] ahci: compile out msi/msix infrastructure
Date: Sat, 05 Dec 2015 23:22:49 +0100 [thread overview]
Message-ID: <1540836.svMP4lTcYC@wuerfel> (raw)
In-Reply-To: <20151204195830.2300.48789.stgit@dwillia2-desk3.jf.intel.com>
On Friday 04 December 2015 11:58:30 Dan Williams wrote:
> +#ifdef CONFIG_PCI_MSI
> +static inline int ahci_irq_vector(struct ahci_host_priv *hpriv, int port)
> +{
> + if (hpriv->flags & AHCI_HFLAG_MULTI_MSIX)
> + return hpriv->msix[i].vector;
> + else
> + return hpriv->irq + i;
> +}
>
My randconfig tests now noticed that 'i' is undeclared here. I suppose it
should be 'port' instead of 'i'?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ahci: compile out msi/msix infrastructure
Date: Sat, 05 Dec 2015 23:22:49 +0100 [thread overview]
Message-ID: <1540836.svMP4lTcYC@wuerfel> (raw)
In-Reply-To: <20151204195830.2300.48789.stgit@dwillia2-desk3.jf.intel.com>
On Friday 04 December 2015 11:58:30 Dan Williams wrote:
> +#ifdef CONFIG_PCI_MSI
> +static inline int ahci_irq_vector(struct ahci_host_priv *hpriv, int port)
> +{
> + if (hpriv->flags & AHCI_HFLAG_MULTI_MSIX)
> + return hpriv->msix[i].vector;
> + else
> + return hpriv->irq + i;
> +}
>
My randconfig tests now noticed that 'i' is undeclared here. I suppose it
should be 'port' instead of 'i'?
Arnd
next prev parent reply other threads:[~2015-12-05 22:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 19:58 [PATCH] ahci: compile out msi/msix infrastructure Dan Williams
2015-12-04 19:58 ` Dan Williams
2015-12-04 21:46 ` Arnd Bergmann
2015-12-04 21:46 ` Arnd Bergmann
2015-12-05 22:22 ` Arnd Bergmann [this message]
2015-12-05 22:22 ` Arnd Bergmann
2015-12-05 22:25 ` Arnd Bergmann
2015-12-05 22:25 ` Arnd Bergmann
2015-12-06 0:05 ` Dan Williams
2015-12-06 0:05 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540836.svMP4lTcYC@wuerfel \
--to=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.