From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kbingham@kernel.org>
Cc: linux-renesas-soc@vger.kernel.org,
Simon Horman <horms@verge.net.au>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] arm64: dts: renesas: r8a77995: add FCPVD nodes
Date: Tue, 13 Feb 2018 14:32:22 +0200 [thread overview]
Message-ID: <1541765.WkmPmS7X3L@avalon> (raw)
In-Reply-To: <1518474330-8713-3-git-send-email-kbingham@kernel.org>
Hi Kieran,
Thank you for the patch.
On Tuesday, 13 February 2018 00:25:27 EET Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> The FCPVD handles the interface between the VSPD and memory.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I would however squash this with patch 1/4 from the same series.
> ---
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index
> 6cf935d307d9..196a917afea6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -700,6 +700,24 @@
> resets = <&cpg 607>;
> iommus = <&ipmmu_vp0 5>;
> };
> +
> + fcpvd0: fcp@fea27000 {
> + compatible = "renesas,fcpv";
> + reg = <0 0xfea27000 0 0x200>;
> + clocks = <&cpg CPG_MOD 603>;
> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> + resets = <&cpg 603>;
> + iommus = <&ipmmu_vi0 8>;
> + };
> +
> + fcpvd1: fcp@fea2f000 {
> + compatible = "renesas,fcpv";
> + reg = <0 0xfea2f000 0 0x200>;
> + clocks = <&cpg CPG_MOD 602>;
> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> + resets = <&cpg 602>;
> + iommus = <&ipmmu_vi0 9>;
> + };
> };
>
> timer {
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] arm64: dts: renesas: r8a77995: add FCPVD nodes
Date: Tue, 13 Feb 2018 14:32:22 +0200 [thread overview]
Message-ID: <1541765.WkmPmS7X3L@avalon> (raw)
In-Reply-To: <1518474330-8713-3-git-send-email-kbingham@kernel.org>
Hi Kieran,
Thank you for the patch.
On Tuesday, 13 February 2018 00:25:27 EET Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> The FCPVD handles the interface between the VSPD and memory.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I would however squash this with patch 1/4 from the same series.
> ---
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index
> 6cf935d307d9..196a917afea6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -700,6 +700,24 @@
> resets = <&cpg 607>;
> iommus = <&ipmmu_vp0 5>;
> };
> +
> + fcpvd0: fcp at fea27000 {
> + compatible = "renesas,fcpv";
> + reg = <0 0xfea27000 0 0x200>;
> + clocks = <&cpg CPG_MOD 603>;
> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> + resets = <&cpg 603>;
> + iommus = <&ipmmu_vi0 8>;
> + };
> +
> + fcpvd1: fcp at fea2f000 {
> + compatible = "renesas,fcpv";
> + reg = <0 0xfea2f000 0 0x200>;
> + clocks = <&cpg CPG_MOD 602>;
> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> + resets = <&cpg 602>;
> + iommus = <&ipmmu_vi0 9>;
> + };
> };
>
> timer {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-02-13 12:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 22:25 [PATCH 0/4] arm64: dts: renesas: r8a77995: Add VSP support Kieran Bingham
2018-02-12 22:25 ` [PATCH 1/4] arm64: dts: renesas: r8a77995: add FCPVB node Kieran Bingham
2018-02-12 22:25 ` Kieran Bingham
2018-02-12 22:25 ` Kieran Bingham
2018-02-13 12:31 ` Laurent Pinchart
2018-02-13 12:31 ` Laurent Pinchart
2018-02-15 16:01 ` Simon Horman
2018-02-15 16:01 ` Simon Horman
2018-02-12 22:25 ` [PATCH 2/4] arm64: dts: renesas: r8a77995: add FCPVD nodes Kieran Bingham
2018-02-12 22:25 ` Kieran Bingham
2018-02-12 22:25 ` Kieran Bingham
2018-02-13 12:32 ` Laurent Pinchart [this message]
2018-02-13 12:32 ` Laurent Pinchart
2018-02-15 16:14 ` Simon Horman
2018-02-15 16:14 ` Simon Horman
2018-02-15 16:20 ` Kieran Bingham
2018-02-15 16:20 ` Kieran Bingham
2018-02-15 16:20 ` Kieran Bingham
2018-02-15 16:38 ` Simon Horman
2018-02-15 16:38 ` Simon Horman
2018-02-12 22:25 ` [PATCH 3/4] arm64: dts: renesas: r8a77995: add VSPBS instance Kieran Bingham
2018-02-12 22:25 ` Kieran Bingham
2018-02-12 22:25 ` Kieran Bingham
2018-02-13 12:44 ` Laurent Pinchart
2018-02-13 12:44 ` Laurent Pinchart
2018-02-12 22:25 ` [PATCH 4/4] arm64: dts: renesas: r8a77995: add VSPD instances Kieran Bingham
2018-02-12 22:25 ` Kieran Bingham
2018-02-12 22:25 ` Kieran Bingham
2018-02-13 12:45 ` Laurent Pinchart
2018-02-13 12:45 ` Laurent Pinchart
2018-02-13 12:45 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541765.WkmPmS7X3L@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=kbingham@kernel.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.