From: Oliver Neukum <oneukum@suse.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
nsaaenzjulienne@suse.de, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: usb: hub: add I/O error retry & reset routine
Date: Mon, 19 Nov 2018 10:20:39 +0100 [thread overview]
Message-ID: <1542619239.2630.6.camel@suse.com> (raw)
On Do, 2018-11-15 at 18:14 +0100, Nicolas Saenz Julienne wrote:
Hi,
what Alan said, in addition you need to stop the error handling
when the device is suspended or reset.
> @@ -713,8 +751,10 @@ static void hub_irq(struct urb *urb)
> return;
>
> status = usb_submit_urb(hub->urb, GFP_ATOMIC);
> - if (status != 0 && status != -ENODEV && status != -EPERM)
> + if (status != 0 && status != -ENODEV && status != -EPERM) {
This also needs to check for -ESHUTDOWN
Regards
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Neukum <oneukum@suse.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
nsaaenzjulienne@suse.de, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: hub: add I/O error retry & reset routine
Date: Mon, 19 Nov 2018 10:20:39 +0100 [thread overview]
Message-ID: <1542619239.2630.6.camel@suse.com> (raw)
In-Reply-To: <20181115171418.23522-1-nsaenzjulienne@suse.de>
On Do, 2018-11-15 at 18:14 +0100, Nicolas Saenz Julienne wrote:
Hi,
what Alan said, in addition you need to stop the error handling
when the device is suspended or reset.
> @@ -713,8 +751,10 @@ static void hub_irq(struct urb *urb)
> return;
>
> status = usb_submit_urb(hub->urb, GFP_ATOMIC);
> - if (status != 0 && status != -ENODEV && status != -EPERM)
> + if (status != 0 && status != -ENODEV && status != -EPERM) {
This also needs to check for -ESHUTDOWN
Regards
Oliver
next reply other threads:[~2018-11-19 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 9:20 Oliver Neukum [this message]
2018-11-19 9:20 ` [PATCH] usb: hub: add I/O error retry & reset routine Oliver Neukum
-- strict thread matches above, loose matches on Subject: below --
2018-11-16 16:21 Alan Stern
2018-11-16 16:21 ` [PATCH] " Alan Stern
2018-11-16 10:49 Nicolas Saenz Julienne
2018-11-16 10:49 ` [PATCH] " Nicolas Saenz Julienne
2018-11-15 19:24 Alan Stern
2018-11-15 19:24 ` [PATCH] " Alan Stern
2018-11-15 17:14 Nicolas Saenz Julienne
2018-11-15 17:14 ` [PATCH] " Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542619239.2630.6.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsaaenzjulienne@suse.de \
--cc=nsaenzjulienne@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.