From: Oliver Neukum <oneukum@suse.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
stern@rowland.harvard.edu
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: [v3] usb: hub: add retry routine after intr URB submit error
Date: Tue, 20 Nov 2018 15:57:10 +0100 [thread overview]
Message-ID: <1542725830.28362.12.camel@suse.com> (raw)
On Di, 2018-11-20 at 15:34 +0100, Nicolas Saenz Julienne wrote:
> The hub sends hot-plug events to the host trough it's interrupt URB. The
> driver takes care of completing the URB and re-submitting it. Completion
> errors are handled in the hub_event() work, yet submission errors are
> ignored, rendering the device unresponsive. All further events are lost.
>
Hi,
almost. There is no point in kicking of an error handling while aq
reset is underway. You are checking only "quiescing" but not
"in_reset".
Regards
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Neukum <oneukum@suse.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
stern@rowland.harvard.edu
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] usb: hub: add retry routine after intr URB submit error
Date: Tue, 20 Nov 2018 15:57:10 +0100 [thread overview]
Message-ID: <1542725830.28362.12.camel@suse.com> (raw)
In-Reply-To: <20181120143438.18296-1-nsaenzjulienne@suse.de>
On Di, 2018-11-20 at 15:34 +0100, Nicolas Saenz Julienne wrote:
> The hub sends hot-plug events to the host trough it's interrupt URB. The
> driver takes care of completing the URB and re-submitting it. Completion
> errors are handled in the hub_event() work, yet submission errors are
> ignored, rendering the device unresponsive. All further events are lost.
>
Hi,
almost. There is no point in kicking of an error handling while aq
reset is underway. You are checking only "quiescing" but not
"in_reset".
Regards
Oliver
next reply other threads:[~2018-11-20 14:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 14:57 Oliver Neukum [this message]
2018-11-20 14:57 ` [PATCH v3] usb: hub: add retry routine after intr URB submit error Oliver Neukum
-- strict thread matches above, loose matches on Subject: below --
2019-01-07 21:25 [v3] " Oliver Neukum
2019-01-07 21:25 ` [PATCH v3] " Oliver Neukum
2019-01-07 18:59 [v3] " Alan Stern
2019-01-07 18:59 ` [PATCH v3] " Alan Stern
2019-01-07 16:33 [v3] " Greg Kroah-Hartman
2019-01-07 16:33 ` [PATCH v3] " Greg KH
2018-11-20 15:17 [v3] " Nicolas Saenz Julienne
2018-11-20 15:17 ` [PATCH v3] " Nicolas Saenz Julienne
2018-11-20 15:12 [v3] " Oliver Neukum
2018-11-20 15:12 ` [PATCH v3] " Oliver Neukum
2018-11-20 14:34 [v3] " Nicolas Saenz Julienne
2018-11-20 14:34 ` [PATCH v3] " Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542725830.28362.12.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.