All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] target: add device vendor_id configfs attribute
Date: Tue, 20 Nov 2018 18:03:14 +0000	[thread overview]
Message-ID: <1542736994.185366.77.camel@acm.org> (raw)
In-Reply-To: <20181119210636.22979-4-ddiss@suse.de>

On Tue, 2018-11-20 at 19:00 +-0100, David Disseldorp wrote:
+AD4 I tend to agree that it's dangerous, but chose to stay somewhat
+AD4 consistent with the other t10+AF8-wwn strings that are treated as though
+AD4 they may not be NULL terminated.
+AD4 
+AD4 If you're in favour adding an extra terminator byte here, then I think
+AD4 it'd make sense to do the same for model+AFsAXQ, revision+AFsAXQ and unit+AF8-serial+AFsAXQ
+AD4 too. Are you okay with that approach?

Sure, I would welcome that change.

Thanks,

Bart.

  parent reply	other threads:[~2018-11-20 18:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-19 21:06 [PATCH v3 3/4] target: add device vendor_id configfs attribute David Disseldorp
2018-11-20 17:24 ` Bart Van Assche
2018-11-20 18:00 ` David Disseldorp
2018-11-20 18:03 ` Bart Van Assche [this message]
2018-11-28 15:37 ` David Disseldorp
2018-11-28 16:08 ` Bart Van Assche
2018-11-28 16:28 ` David Disseldorp
2018-11-28 16:36 ` Bart Van Assche
2018-11-28 16:44 ` David Disseldorp
2018-11-28 16:47 ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1542736994.185366.77.camel@acm.org \
    --to=bvanassche@acm.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.