From: Bart Van Assche <bvanassche@acm.org>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] target: add device vendor_id configfs attribute
Date: Wed, 28 Nov 2018 16:47:39 +0000 [thread overview]
Message-ID: <1543423659.185366.104.camel@acm.org> (raw)
In-Reply-To: <20181119210636.22979-4-ddiss@suse.de>
On Wed, 2018-11-28 at 17:44 +-0100, David Disseldorp wrote:
+AD4 Hi Bart,
+AD4
+AD4 On Wed, 28 Nov 2018 08:36:19 -0800, Bart Van Assche wrote:
+AD4
+AD4 +AD4 Maybe I'm missing something, but why is zeroing of unused bytes in these functions
+AD4 +AD4 necessary? Would the following be correct if all strings in struct t10+AF8-wwn would be
+AD4 +AD4 '+AFw-0'-terminated?
+AD4
+AD4 Your patch looks good to me. Mind if I tack it on to the end of my
+AD4 t10+AF8-wwn.vendor/model/revision+AFs-size+-1+AF0 patchset, with your authorship?
Sure, that sounds fine to me.
Bart.
prev parent reply other threads:[~2018-11-28 16:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 21:06 [PATCH v3 3/4] target: add device vendor_id configfs attribute David Disseldorp
2018-11-20 17:24 ` Bart Van Assche
2018-11-20 18:00 ` David Disseldorp
2018-11-20 18:03 ` Bart Van Assche
2018-11-28 15:37 ` David Disseldorp
2018-11-28 16:08 ` Bart Van Assche
2018-11-28 16:28 ` David Disseldorp
2018-11-28 16:36 ` Bart Van Assche
2018-11-28 16:44 ` David Disseldorp
2018-11-28 16:47 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543423659.185366.104.camel@acm.org \
--to=bvanassche@acm.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.