From: Trent Piepho <tpiepho@impinj.com>
To: "festevam@gmail.com" <festevam@gmail.com>,
"hancock@sedsystems.ca" <hancock@sedsystems.ca>,
"tharvey@gateworks.com" <tharvey@gateworks.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"hongxing.zhu@nxp.com" <hongxing.zhu@nxp.com>
Subject: Re: iMX6 PCIe MSI issues
Date: Tue, 27 Nov 2018 18:53:25 +0000 [thread overview]
Message-ID: <1543344805.18519.71.camel@impinj.com> (raw)
In-Reply-To: <4a582df8-f7dc-3ad5-42d7-33924eb57b0a@sedsystems.ca>
On Mon, 2018-11-26 at 13:24 -0600, Robert Hancock wrote:
>
> > Also, I think the new irq domain stuff in 4.17 breaks irq accounting to
> > the GIC chain interrupt (152) to the dwc msi domain. It'll always show
> > as zero in /proc/interrupts. But I've mostly been working in 4.16 so
> > I'm not sure about the precise interaction of irq domains and
> > /proc/interrupts yet.
>
> I'm not actually seeing the MSI interrupt showing up in /proc/interrupts
> at all in 4.19. From adding some debug output into the dwc PCIe code, it
> appears it's using Linux IRQ 24 as the chaining interrupt, but there's
> no entry in /proc/interrupts for either Linux IRQ 24 or GIC vector 152.
> Not sure if there is supposed to be or not. It does appear that the
> vector isn't masked in the GIC in any case, however, and when I force
> the interrupt into the GIC pending register, things seem to happen
> properly after that.
In 4.16, the MSI chaining interrupt does show up in /proc/interrupts
and does increment. Also shows up as trace events too.
In 4.17, it no longer appears in /proc/interrupts. Finding the Linux
irq number is non-obvious, as you've seen. It will show up in
/sys/kernel/irq and /sys/kernel/debug/irq/irqs, but the count is always
zero. IMHO, not an improvement.
So if you're using that count in /sys to determine that the GIC irq
never fired, then it's not conclusive. It always reads zero.
But the same problem 2014 would obviously predate the 4.17 kernel.
WARNING: multiple messages have this Message-ID (diff)
From: tpiepho@impinj.com (Trent Piepho)
To: linux-arm-kernel@lists.infradead.org
Subject: iMX6 PCIe MSI issues
Date: Tue, 27 Nov 2018 18:53:25 +0000 [thread overview]
Message-ID: <1543344805.18519.71.camel@impinj.com> (raw)
In-Reply-To: <4a582df8-f7dc-3ad5-42d7-33924eb57b0a@sedsystems.ca>
On Mon, 2018-11-26 at 13:24 -0600, Robert Hancock wrote:
>
> > Also, I think the new irq domain stuff in 4.17 breaks irq accounting to
> > the GIC chain interrupt (152) to the dwc msi domain. It'll always show
> > as zero in /proc/interrupts. But I've mostly been working in 4.16 so
> > I'm not sure about the precise interaction of irq domains and
> > /proc/interrupts yet.
>
> I'm not actually seeing the MSI interrupt showing up in /proc/interrupts
> at all in 4.19. From adding some debug output into the dwc PCIe code, it
> appears it's using Linux IRQ 24 as the chaining interrupt, but there's
> no entry in /proc/interrupts for either Linux IRQ 24 or GIC vector 152.
> Not sure if there is supposed to be or not. It does appear that the
> vector isn't masked in the GIC in any case, however, and when I force
> the interrupt into the GIC pending register, things seem to happen
> properly after that.
In 4.16, the MSI chaining interrupt does show up in /proc/interrupts
and does increment. Also shows up as trace events too.
In 4.17, it no longer appears in /proc/interrupts. Finding the Linux
irq number is non-obvious, as you've seen. It will show up in
/sys/kernel/irq and /sys/kernel/debug/irq/irqs, but the count is always
zero. IMHO, not an improvement.
So if you're using that count in /sys to determine that the GIC irq
never fired, then it's not conclusive. It always reads zero.
But the same problem 2014 would obviously predate the 4.17 kernel.
next prev parent reply other threads:[~2018-11-27 18:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 22:17 iMX6 PCIe MSI issues Robert Hancock
2018-11-26 1:53 ` Richard Zhu
2018-11-26 16:22 ` Robert Hancock
2018-11-26 16:31 ` Fabio Estevam
2018-11-26 16:31 ` Fabio Estevam
2018-11-26 17:09 ` Trent Piepho
2018-11-26 17:09 ` Trent Piepho
2018-11-26 19:24 ` Robert Hancock
2018-11-26 19:24 ` Robert Hancock
2018-11-27 18:53 ` Trent Piepho [this message]
2018-11-27 18:53 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543344805.18519.71.camel@impinj.com \
--to=tpiepho@impinj.com \
--cc=festevam@gmail.com \
--cc=hancock@sedsystems.ca \
--cc=hongxing.zhu@nxp.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.