From: Mimi Zohar <zohar@linux.ibm.com>
To: Thiago Jung Bauermann <bauerman@linux.ibm.com>,
Nayna Jain <nayna@linux.ibm.com>
Cc: linux-efi@vger.kernel.org, mpe@ellerman.id.au,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
dhowells@redhat.com, seth.forshee@canonical.com,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
ebiederm@xmission.com, jforbes@redhat.com,
linux-integrity@vger.kernel.org, vgoyal@redhat.com
Subject: Re: [PATCH v2 7/7] ima: Support platform keyring for kernel appraisal
Date: Wed, 12 Dec 2018 19:18:21 -0500 [thread overview]
Message-ID: <1544660301.3956.3.camel@linux.ibm.com> (raw)
In-Reply-To: <8736r2fw88.fsf@morokweng.localdomain>
On Wed, 2018-12-12 at 16:14 -0200, Thiago Jung Bauermann wrote:
[snip]
> Subject: [PATCH] ima: Only use the platform keyring if it's enabled
>
> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Good catch! Thanks.
Mimi
> ---
> security/integrity/ima/ima_appraise.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c
> index e8f520450895..f6ac405daabb 100644
> --- a/security/integrity/ima/ima_appraise.c
> +++ b/security/integrity/ima/ima_appraise.c
> @@ -297,7 +297,8 @@ int ima_appraise_measurement(enum ima_hooks func,
> status = INTEGRITY_UNKNOWN;
> break;
> }
> - if (rc && func == KEXEC_KERNEL_CHECK)
> + if (IS_ENABLED(CONFIG_INTEGRITY_PLATFORM_KEYRING) && rc &&
> + func == KEXEC_KERNEL_CHECK)
> rc = integrity_digsig_verify(INTEGRITY_KEYRING_PLATFORM,
> (const char *)xattr_value,
> xattr_len,
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Thiago Jung Bauermann <bauerman@linux.ibm.com>,
Nayna Jain <nayna@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
jforbes@redhat.com, seth.forshee@canonical.com,
kexec@lists.infradead.org, keyrings@vger.kernel.org,
vgoyal@redhat.com, ebiederm@xmission.com, mpe@ellerman.id.au
Subject: Re: [PATCH v2 7/7] ima: Support platform keyring for kernel appraisal
Date: Thu, 13 Dec 2018 00:18:21 +0000 [thread overview]
Message-ID: <1544660301.3956.3.camel@linux.ibm.com> (raw)
In-Reply-To: <8736r2fw88.fsf@morokweng.localdomain>
On Wed, 2018-12-12 at 16:14 -0200, Thiago Jung Bauermann wrote:
[snip]
> Subject: [PATCH] ima: Only use the platform keyring if it's enabled
>
> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Good catch! Thanks.
Mimi
> ---
> security/integrity/ima/ima_appraise.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c
> index e8f520450895..f6ac405daabb 100644
> --- a/security/integrity/ima/ima_appraise.c
> +++ b/security/integrity/ima/ima_appraise.c
> @@ -297,7 +297,8 @@ int ima_appraise_measurement(enum ima_hooks func,
> status = INTEGRITY_UNKNOWN;
> break;
> }
> - if (rc && func = KEXEC_KERNEL_CHECK)
> + if (IS_ENABLED(CONFIG_INTEGRITY_PLATFORM_KEYRING) && rc &&
> + func = KEXEC_KERNEL_CHECK)
> rc = integrity_digsig_verify(INTEGRITY_KEYRING_PLATFORM,
> (const char *)xattr_value,
> xattr_len,
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Thiago Jung Bauermann <bauerman@linux.ibm.com>,
Nayna Jain <nayna@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
jforbes@redhat.com, seth.forshee@canonical.com,
kexec@lists.infradead.org, keyrings@vger.kernel.org,
vgoyal@redhat.com, ebiederm@xmission.com, mpe@ellerman.id.au
Subject: Re: [PATCH v2 7/7] ima: Support platform keyring for kernel appraisal
Date: Wed, 12 Dec 2018 19:18:21 -0500 [thread overview]
Message-ID: <1544660301.3956.3.camel@linux.ibm.com> (raw)
In-Reply-To: <8736r2fw88.fsf@morokweng.localdomain>
On Wed, 2018-12-12 at 16:14 -0200, Thiago Jung Bauermann wrote:
[snip]
> Subject: [PATCH] ima: Only use the platform keyring if it's enabled
>
> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Good catch! Thanks.
Mimi
> ---
> security/integrity/ima/ima_appraise.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c
> index e8f520450895..f6ac405daabb 100644
> --- a/security/integrity/ima/ima_appraise.c
> +++ b/security/integrity/ima/ima_appraise.c
> @@ -297,7 +297,8 @@ int ima_appraise_measurement(enum ima_hooks func,
> status = INTEGRITY_UNKNOWN;
> break;
> }
> - if (rc && func == KEXEC_KERNEL_CHECK)
> + if (IS_ENABLED(CONFIG_INTEGRITY_PLATFORM_KEYRING) && rc &&
> + func == KEXEC_KERNEL_CHECK)
> rc = integrity_digsig_verify(INTEGRITY_KEYRING_PLATFORM,
> (const char *)xattr_value,
> xattr_len,
next prev parent reply other threads:[~2018-12-13 0:19 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-08 20:26 [PATCH v2 0/7] add platform/firmware keys support for kernel verification by IMA Nayna Jain
2018-12-08 20:38 ` Nayna Jain
2018-12-08 20:26 ` Nayna Jain
2018-12-08 20:26 ` [PATCH v2 1/7] integrity: Define a trusted platform keyring Nayna Jain
2018-12-08 20:38 ` Nayna Jain
2018-12-08 20:26 ` Nayna Jain
2018-12-09 4:48 ` Nayna Jain
2018-12-09 4:52 ` Nayna Jain
2018-12-09 4:48 ` Nayna Jain
2018-12-13 0:15 ` Thiago Jung Bauermann
2018-12-13 0:15 ` Thiago Jung Bauermann
2018-12-13 0:15 ` Thiago Jung Bauermann
2018-12-11 18:27 ` James Morris
2018-12-11 18:27 ` James Morris
2018-12-11 18:27 ` James Morris
2018-12-08 20:27 ` [PATCH v2 2/7] integrity: Load certs to the " Nayna Jain
2018-12-08 20:39 ` Nayna Jain
2018-12-08 20:27 ` Nayna Jain
2018-12-11 18:30 ` James Morris
2018-12-11 18:30 ` James Morris
2018-12-11 18:30 ` James Morris
2018-12-13 0:17 ` Thiago Jung Bauermann
2018-12-13 0:17 ` Thiago Jung Bauermann
2018-12-13 0:17 ` Thiago Jung Bauermann
2018-12-08 20:27 ` [PATCH v2 3/7] efi: Add EFI signature data types Nayna Jain
2018-12-08 20:39 ` Nayna Jain
2018-12-08 20:27 ` Nayna Jain
2018-12-11 18:30 ` James Morris
2018-12-11 18:30 ` James Morris
2018-12-11 18:30 ` James Morris
2018-12-08 20:27 ` [PATCH v2 4/7] efi: Add an EFI signature blob parser Nayna Jain
2018-12-08 20:39 ` Nayna Jain
2018-12-08 20:27 ` Nayna Jain
2018-12-08 20:27 ` [PATCH v2 5/7] efi: Import certificates from UEFI Secure Boot Nayna Jain
2018-12-08 20:39 ` Nayna Jain
2018-12-08 20:27 ` Nayna Jain
2018-12-11 18:47 ` James Morris
2018-12-11 18:47 ` James Morris
2018-12-11 18:47 ` James Morris
2018-12-12 17:31 ` Nayna Jain
2018-12-12 17:43 ` Nayna Jain
2018-12-12 17:31 ` Nayna Jain
2018-12-12 21:32 ` [PATCH v2a " Nayna Jain
2018-12-12 21:44 ` Nayna Jain
2018-12-12 21:32 ` Nayna Jain
2018-12-08 20:27 ` [PATCH v2 6/7] efi: Allow the "db" UEFI variable to be suppressed Nayna Jain
2018-12-08 20:39 ` Nayna Jain
2018-12-08 20:27 ` Nayna Jain
2018-12-11 18:49 ` James Morris
2018-12-11 18:49 ` James Morris
2018-12-11 18:49 ` James Morris
2018-12-11 18:49 ` James Morris
2018-12-08 20:27 ` [PATCH v2 7/7] ima: Support platform keyring for kernel appraisal Nayna Jain
2018-12-08 20:39 ` Nayna Jain
2018-12-08 20:27 ` Nayna Jain
2018-12-11 18:53 ` James Morris
2018-12-11 18:53 ` James Morris
2018-12-11 18:53 ` James Morris
2018-12-12 18:14 ` Thiago Jung Bauermann
2018-12-12 18:14 ` Thiago Jung Bauermann
2018-12-12 18:14 ` Thiago Jung Bauermann
2018-12-12 18:14 ` Thiago Jung Bauermann
2018-12-13 0:18 ` Mimi Zohar [this message]
2018-12-13 0:18 ` Mimi Zohar
2018-12-13 0:18 ` Mimi Zohar
2018-12-13 0:19 ` Thiago Jung Bauermann
2018-12-13 0:19 ` Thiago Jung Bauermann
2018-12-13 0:19 ` Thiago Jung Bauermann
2018-12-09 18:39 ` [PATCH v2 0/7] add platform/firmware keys support for kernel verification by IMA Mimi Zohar
2018-12-09 18:39 ` Mimi Zohar
2018-12-09 18:39 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544660301.3956.3.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=bauerman@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jforbes@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nayna@linux.ibm.com \
--cc=seth.forshee@canonical.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.